| Message ID | 1716458390-20120-6-git-send-email-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: imx: clk-audiomix: Improvement for audiomix | expand |
> Subject: [PATCH v5 5/5] clk: imx: clk-audiomix: Corrent parent clock for > earc_phy and audpll > > According to Reference Manual of i.MX8MP The parent clock of "earc_phy" is > "sai_pll_out_div2", The parent clock of "audpll" is "osc_24m". > > Add CLK_GATE_PARENT() macro for usage of specifying parent clock. > > Fixes: 6cd95f7b151c ("clk: imx: imx8mp: Add audiomix block control") > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> According to Reference Manual of i.MX8MP > The parent clock of "earc_phy" is "sai_pll_out_div2", > The parent clock of "audpll" is "osc_24m". … > Fixes: 6cd95f7b151c ("clk: imx: imx8mp: Add audiomix block control") Does such information indicate that the word “Correct” would be more appropriate (instead of “Corrent”) in the summary phrase? Regards, Markus
On Sat, May 25, 2024 at 3:55 PM Markus Elfring <Markus.Elfring@web.de> wrote: > > > According to Reference Manual of i.MX8MP > > The parent clock of "earc_phy" is "sai_pll_out_div2", > > The parent clock of "audpll" is "osc_24m". > … > > Fixes: 6cd95f7b151c ("clk: imx: imx8mp: Add audiomix block control") > > Does such information indicate that the word “Correct” would be more appropriate > (instead of “Corrent”) in the summary phrase? Yes, thanks for pointing out the typo. best regards Shengjiu Wang > > Regards, > Markus
diff --git a/drivers/clk/imx/clk-imx8mp-audiomix.c b/drivers/clk/imx/clk-imx8mp-audiomix.c index cef01f1fa0b4..01ac923a10ee 100644 --- a/drivers/clk/imx/clk-imx8mp-audiomix.c +++ b/drivers/clk/imx/clk-imx8mp-audiomix.c @@ -156,6 +156,15 @@ static const struct clk_parent_data clk_imx8mp_audiomix_pll_bypass_sels[] = { PDM_SEL, 2, 0 \ } +#define CLK_GATE_PARENT(gname, cname, pname) \ + { \ + gname"_cg", \ + IMX8MP_CLK_AUDIOMIX_##cname, \ + { .fw_name = pname, .name = pname }, NULL, 1, \ + CLKEN0 + 4 * !!(IMX8MP_CLK_AUDIOMIX_##cname / 32), \ + 1, IMX8MP_CLK_AUDIOMIX_##cname % 32 \ + } + struct clk_imx8mp_audiomix_sel { const char *name; int clkid; @@ -173,14 +182,14 @@ static struct clk_imx8mp_audiomix_sel sels[] = { CLK_GATE("earc", EARC_IPG), CLK_GATE("ocrama", OCRAMA_IPG), CLK_GATE("aud2htx", AUD2HTX_IPG), - CLK_GATE("earc_phy", EARC_PHY), + CLK_GATE_PARENT("earc_phy", EARC_PHY, "sai_pll_out_div2"), CLK_GATE("sdma2", SDMA2_ROOT), CLK_GATE("sdma3", SDMA3_ROOT), CLK_GATE("spba2", SPBA2_ROOT), CLK_GATE("dsp", DSP_ROOT), CLK_GATE("dspdbg", DSPDBG_ROOT), CLK_GATE("edma", EDMA_ROOT), - CLK_GATE("audpll", AUDPLL_ROOT), + CLK_GATE_PARENT("audpll", AUDPLL_ROOT, "osc_24m"), CLK_GATE("mu2", MU2_ROOT), CLK_GATE("mu3", MU3_ROOT), CLK_PDM,
According to Reference Manual of i.MX8MP The parent clock of "earc_phy" is "sai_pll_out_div2", The parent clock of "audpll" is "osc_24m". Add CLK_GATE_PARENT() macro for usage of specifying parent clock. Fixes: 6cd95f7b151c ("clk: imx: imx8mp: Add audiomix block control") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> --- drivers/clk/imx/clk-imx8mp-audiomix.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-)