From patchwork Sat Mar 23 15:34:53 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13600675 Received: from EUR03-VI1-obe.outbound.protection.outlook.com (mail-vi1eur03on2079.outbound.protection.outlook.com [40.107.103.79]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9D4905675F for ; Sat, 23 Mar 2024 15:35:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.103.79 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711208130; cv=fail; b=lK5MNoD3h3F0geo8nfNlLT6aRkuyEd/FmGO/fJIzVyPHYbRT/KiaHiO5lYKXhQxKYOIQq0+TmaG7UMsUR3W4DYlycrCeL6MQ03r6kRL9QAJrUd2wejzaq4OgbmkQBQecCxaER75AnfwT5USQhOu5+grkcLMwc6b0eVgIHBc42WA= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1711208130; c=relaxed/simple; bh=jmlf1mu9SIIEHrRpBqByG+5+aDGIj5pcURPTe4jRfQw=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Y0hqNu4YGXzwvZKmU93kEfF8bIT6EN+lolDrZaj/Rw2SXx4H/9PZ4xoAJ6r6AwMLEcW/nZGBsDpfBq74HIHElViDfa6pgdM/5o+SUDYjC8lzZL9YpE05qjJgxL5y2an3UGX7/2uyllXyFRRr1ILfZfSZnyjcFS+tCK1/qNdS0aw= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=SGXMSiGO; arc=fail smtp.client-ip=40.107.103.79 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="SGXMSiGO" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=XZsuDn79WnXL0JUhfptrCqiMPgdwnYN86VA+/AIiJNyFiUnV4cVIAyPA790/WhCpvaHZbTXh0VZ/sM2/mTR6Jw6LlkaJK42MqagghB47wCKsTBGGQf2Z0kRNWdqSfkzHHaFvZNv2i2pmJz/xnOz0lZ+QJC9zx0XgQIUyAjzUTu1hJWblD2BH2FYTj/VMcRpHNT+FzWdySemtIx19LuTRRs61NpwY9/JFpXZcNgAThXKA9ir27ljJVTWx++mX3hgCPmAsYkvjOLJhwZCPOY4NzWUILQ9LWxTvzMPAHzoN5YvPUFRtroEkMDPJRjmAG3UfRpo/W1Heg26nZcEyXolPIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=imaT9IItAsYq0kzb6hA89QzoqQlsZKPxNqqPWFASA1I=; b=fVauPk/bSwHJ8Tad/BVUt+MPqZJHfpo9XnGvP5W2D2MvUUQSKYIXEnGU/Tg8RoxR8hXMHcUUUicI+o01UouszB3dpA/9xQPrbkczl2Ovkj6iHi+THW+LV8BMIllOFo4o/wZSZJgjZsiqrRBVLxjM2w9GhETGJbUGY+8JOunnxNBekSMevyQh3dKBQOB3cy/+8MAJSSK7tRTutTGBT5WZQFqmqc1Bue0T/hJBeQ6nwfsV6yrOXLfgxWXKaD9GJAaE/ZsDXJWlbHXYuSGZcjNpB3FnxEcN9axietobEiOViFHgngra8fPciTiolBOf0EPsqivf5A3hSnWSKeqexTwj7g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=imaT9IItAsYq0kzb6hA89QzoqQlsZKPxNqqPWFASA1I=; b=SGXMSiGOEasPY/PPboIAJcXBVD2Qe64nqlJWvhhw2d4ypmJA1eMIuE9h4+x6MN2/c8v9x6/FfL04lxoIP2P7pkbMO8iDQKueIKE/z/mk93cmtm6dJ3wm4WXRC2kw/2uCl7y8/m6Q4c3dSrZJHiybtt7kXLueMeBnNTEkGXc4T8s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PA4PR04MB7981.eurprd04.prod.outlook.com (2603:10a6:102:c0::24) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7409.26; Sat, 23 Mar 2024 15:35:25 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::3168:91:27c6:edf6%3]) with mapi id 15.20.7409.026; Sat, 23 Mar 2024 15:35:25 +0000 From: Frank Li Date: Sat, 23 Mar 2024 11:34:53 -0400 Subject: [PATCH v3 4/5] dt-bindings: dma: fsl-edma: add fsl,imx8ulp-edma compatible string Message-Id: <20240323-8ulp_edma-v3-4-c0e981027c05@nxp.com> References: <20240323-8ulp_edma-v3-0-c0e981027c05@nxp.com> In-Reply-To: <20240323-8ulp_edma-v3-0-c0e981027c05@nxp.com> To: Vinod Koul , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Peng Fan Cc: imx@lists.linux.dev, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Frank Li , Joy Zou X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1711208112; l=3937; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=UmrfX1DWfzT62mckua+anmk2tRhZNJCIIZ6G3njiUg4=; b=qhueX0+1U1qmjr4RqY4hiT92RLSAsXV/HlEa0iX1ZO3XgixIBT1sL8ZMjIOXiuylBX6FzbijE TqgjqFN3rPZBL6fqojV4+y9ZYM+/VSLcNjCy6+udwaWxSOHtY4MjqOh X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BYAPR05CA0026.namprd05.prod.outlook.com (2603:10b6:a03:c0::39) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PA4PR04MB7981:EE_ X-MS-Office365-Filtering-Correlation-Id: 20db2aa6-17fb-4f95-1b34-08dc4b4edc6f X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 2IuXSQz70Bva61DvXVpyrdi4x68MYkNuGl389KQPHuIRGKRdoxqctyEk19JkF7ADFzpXqNSQkQHHC9WbnDtFIGxcMdf5DDBFZFpR4gsc2URJkP7f+bGISmEWF/F7ntvvCItLuW5r+0Zh7nl4Xq5IhE1PHRTn6CeEo2RW+WjDYUAg4lP5IfMHlpU5tgVWJGUaMacRW/aKoHGHkqSTkJH5NWOzthuB2xLgaYZsT0vZLTrTVZWa/4vrB2JAy8bDupDxyO0gN9wfsQIfCxXDTFLtqp8ogyI23xuw3+UtgBGU+S+hou88NUZP6TGwp0aV+UQbWWTfw8gzf0GrKxZbDhANtKfnQ7qz8e2usUBVnRe2SDw2qcHu4QYTjpDru6V/bwZuv0jYdBff5wLc7Ric1MXBtYNHcJI6wLI0DTK/9lwsqIPNLU9zg473TuBDB41wmCqPDnywYzs4027YiCo/uFH4bBO8mmCKoqa2xaVuOA4pgNFSBCYCXjTp6zMc9iBlpOaTW7GLEGWo/fKRh1RApPNuEvei1REkVYiSrdzMshvZ4t+Sl4p+aU5l2+t+QDhQx2bNcIoNmec1UVb+wGSrdRXTPpmXaoij2Kjq2BMQtgonZKvYvNK0gmfUf6S6QuhbRx6GgUePv8TMPc8VyPqi3HJBzEpiOvRkMWLIhF+Sgce5KM4= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230031)(366007)(376005)(52116005)(1800799015)(38350700005);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?DitSJKweAIlVpTrPKb5epvbCsr+i?= =?utf-8?q?9hGvdwwJjLWOIrH8SM6nThGf8iGng+kx7L2bOTsAYx+y/HmfKDwORfigd0sKCnO4i?= =?utf-8?q?iO6c5PcQ1MqV2AW4xDHRv/BE1lRWfiVgZahy49IFzBMqgiqzkQaYiop0tWui4hnM6?= =?utf-8?q?G5JHCCoZ4QztMiiawuXReMazNMu/rffZSNsRphqfFjPYq+ck2sn1oRv4B7UGdpIOn?= =?utf-8?q?RBdAScbfK4OKBleVBkOPP7JPJjdaJRL4Nga9KdRcmIGZsxFhGho/1omYktvvC24JE?= =?utf-8?q?ZDsFArw7vziFypM0ofeztLQdRMgE3mcp8ys2lJ90RMEZD1NXQF9OuShQZJAMmlIQD?= =?utf-8?q?QxfNoqRH2+NMJBWrnaLIvegVoPWbHSlVrqIMUotF8QJNBvyoMdrBKevpIXTcm7uE3?= =?utf-8?q?+3abG4oLk6PSoNJCKWUNhEJvncPba8s5sI/jizs2FUUUehC0qz4vWELHiXX7YwQfF?= =?utf-8?q?+iD9xagDTVDWRtsANZN6pT6oV7tWTf0AwHum8UQiU5RSNZvlFTAMGOQi951qFtVaq?= =?utf-8?q?46HzJYCcSenbiFNnzaH8VB1FWhptHBTKVbY1wX5Hgj0mIo08w2BMC+GXm5P6rRbL8?= =?utf-8?q?cY+eVW8/am0OXUCwxdocV0WCeLPil1EBTHzuNP3ZBdJFqi5Yu1HSlK3pXL6EV11Go?= =?utf-8?q?Mo/k2q1R7wzw4ecgY6TOJotgNooWym7gm8CZ7BNk8Lqs8+4OmHNGOnYt6tNe9/Gtw?= =?utf-8?q?dS/60dkjTWf/PUWhIJ4J2cna0FSMv0VwZtFVufVszp1de8NS8Gje0r2D7PuTpGtJK?= =?utf-8?q?1/p9Nt+e8lkW0I6v0S0nToaR/wvINWpxFzpIwc4WEqEIf/yYLWtmYUY7O2c1ovlt4?= =?utf-8?q?PJV7qbRRUxuaJgx9TXKZ8dvHzwyFlL73MF1ixAxSD8qkQQxu0Mmzy/JfgYy5YTFHk?= =?utf-8?q?/lUES36Vk9Z63BdWHUB9VSeEj1dPcLW682wEdyJtk1b6fkJzLvoXr6Ibh/31ceNkf?= =?utf-8?q?Hr3FQV+96LUCKCzeNMhq4RKGBAi1T07/OTQdo427De0qP2Nlbiy9avuMWBGb2LY0z?= =?utf-8?q?xvSocdt7z1+IDtQtwpk6wBw92pfhRw6yIqu23RMWCV/0cjLl9PENBngUu4s1HAZuV?= =?utf-8?q?3W/a7pNb71ykDhjYKP7T5NgqlEII3m/d7dsrGrqFYVHlO6nKaUqOro/zFIVX7CgW1?= =?utf-8?q?B0XjnbBkXVT2e34dzqHlGBPy70EDg72GeGzdwOTeK4ttMH91dhM/Imu0CO0yZ6IOA?= =?utf-8?q?tOSRPclG2syhGum/f5xKT69JUsRBiWj90llQU3toaODUUQKurC7W8MglD2AiEepKn?= =?utf-8?q?QGtUE9E3byLxkXtjqP+1S5Y5WDUNaiokPloKp0TeuhZD/7JdSlVU0LsI6qle/szbX?= =?utf-8?q?BSbUKjrPGPpvp9FNSnabnS094MapeQQq7cu/hWx5pBzzyUXLxXLzKhbhw4iDJJpqs?= =?utf-8?q?ogPBPlb8LCLq9q4+HwVJ+Kof+HfBppU7gpVE6aRmQQtTijCcG7jS0bhycqvZzZ/LP?= =?utf-8?q?xu0MsN9oTSdoa3McFjJAlpbUr3qFLklnImljjx2SajorklsAT7iNZDXsyyHuVkJXx?= =?utf-8?q?OY1VrZRXjZF7?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 20db2aa6-17fb-4f95-1b34-08dc4b4edc6f X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 23 Mar 2024 15:35:25.8388 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: oYFL34A3Jr2w1zmcpBHOeJqYqmdELd19PH+ZA0FlHS/ZjvLlkzn2EgjO4ltSisLUgZ4zmIKMikCzSdDYRleJgQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7981 From: Joy Zou Introduce the compatible string 'fsl,imx8ulp-edma' to enable support for the i.MX8ULP's eDMA, alongside adjusting the clock numbering. The i.MX8ULP eDMA architecture features one clock for each DMA channel and an additional clock for the core controller. Given a maximum of 32 DMA channels, the maximum clock number consequently increases to 33. Signed-off-by: Joy Zou Signed-off-by: Frank Li Reviewed-by: Rob Herring --- Notes: Changes in v3: - Change clock name form CHXX-CLK to chxx - Fix typeo 'clock' - Add dma-cell description - About clock-names: items: oneOf: - const: dma - pattern: ... Which already detect naming wrong, for example: clock-names = "dma", "ch00", "ch01", "ch02", "ch03", .... "ch28", "ch29", "ch30", "abcc"; arch/arm64/boot/dts/freescale/imx8ulp-evk.dtb: dma-controller@29010000: clock-names:32: 'oneOf' conditional failed, one must be fixed: 'dma' was expected 'abcc' does not match '^ch(0[0-9]|[1-2][0-9]|3[01])$' Only lose order check, such as ch00, dma, ch03, ch02, can pass check. I think it is good enough. I tried rob's suggestion, but met some technology issue. Detail see https://lore.kernel.org/imx/20240229-8ulp_edma-v2-0-9d12f883c8f7@nxp.com/T/#mc5767dd505d4b7cfc66586a0631684a57e735476 .../devicetree/bindings/dma/fsl,edma.yaml | 40 ++++++++++++++++++++-- 1 file changed, 38 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/bindings/dma/fsl,edma.yaml b/Documentation/devicetree/bindings/dma/fsl,edma.yaml index aa51d278cb67b..825f4715499e5 100644 --- a/Documentation/devicetree/bindings/dma/fsl,edma.yaml +++ b/Documentation/devicetree/bindings/dma/fsl,edma.yaml @@ -23,6 +23,7 @@ properties: - fsl,imx7ulp-edma - fsl,imx8qm-adma - fsl,imx8qm-edma + - fsl,imx8ulp-edma - fsl,imx93-edma3 - fsl,imx93-edma4 - fsl,imx95-edma5 @@ -43,6 +44,17 @@ properties: maxItems: 64 "#dma-cells": + description: | + Specifies the number of cells needed to encode an DMA channel. + + Encode for cells number 2: + cell 0: index of dma channel mux instance. + cell 1: peripheral dma request id. + + Encode for cells number 3: + cell 0: peripheral dma request id. + cell 1: dma channel priority. + cell 2: bitmask, defined at include/dt-bindings/dma/fsl-edma.h enum: - 2 - 3 @@ -53,11 +65,11 @@ properties: clocks: minItems: 1 - maxItems: 2 + maxItems: 33 clock-names: minItems: 1 - maxItems: 2 + maxItems: 33 big-endian: description: | @@ -108,6 +120,7 @@ allOf: properties: clocks: minItems: 2 + maxItems: 2 clock-names: items: - const: dmamux0 @@ -136,6 +149,7 @@ allOf: properties: clock: minItems: 2 + maxItems: 2 clock-names: items: - const: dma @@ -151,6 +165,28 @@ allOf: dma-channels: const: 32 + - if: + properties: + compatible: + contains: + const: fsl,imx8ulp-edma + then: + properties: + clocks: + minItems: 33 + clock-names: + minItems: 33 + items: + oneOf: + - const: dma + - pattern: "^ch(0[0-9]|[1-2][0-9]|3[01])$" + + interrupt-names: false + interrupts: + minItems: 32 + "#dma-cells": + const: 3 + unevaluatedProperties: false examples: