| Message ID | 20240403150355.189229-23-git@luigi311.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | imx258 improvement series | expand |
On 03/04/2024 17:03, git@luigi311.com wrote: > From: Luis Garcia <git@luigi311.com> > > Add powerdown-gpio binding as it is required for some boards > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > Signed-off-by: Luis Garcia <git@luigi311.com> > --- Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
Hi! > From: Luis Garcia <git@luigi311.com> > > Add powerdown-gpio binding as it is required for some boards "." at end of sentence. > Signed-off-by: Ondrej Jirman <megi@xff.cz> > Signed-off-by: Luis Garcia <git@luigi311.com> If the patch is from Ondrej, he should be in From:, I believe. Best regards, Pavel
On 4/3/24 12:49, Pavel Machek wrote: > Hi! > >> From: Luis Garcia <git@luigi311.com> >> >> Add powerdown-gpio binding as it is required for some boards > > "." at end of sentence. > >> Signed-off-by: Ondrej Jirman <megi@xff.cz> >> Signed-off-by: Luis Garcia <git@luigi311.com> > > If the patch is from Ondrej, he should be in From:, I believe. > > Best regards, > Pavel Ohh your right, this was broken out from another patch and didn't set it to be his actual commit same with the other ones. They were based on his downstream changes and just modified to match up with what Dave had set the values too. I'll set it to him for the next revision. Thanks!
Hi Luigi, On Wed, Apr 03, 2024 at 09:03:51AM -0600, git@luigi311.com wrote: > From: Luis Garcia <git@luigi311.com> > > Add powerdown-gpio binding as it is required for some boards > > Signed-off-by: Ondrej Jirman <megi@xff.cz> > Signed-off-by: Luis Garcia <git@luigi311.com> > --- > Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > index c978abc0cdb3..33338139e6e8 100644 > --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml > @@ -36,6 +36,10 @@ properties: > reg: > maxItems: 1 > > + powerdown-gpios: > + description: > + Reference to the GPIO connected to the PWDN pin, if any. The sensor datasheet does not mention this one so I presume this is unrelated to the sensor. Could it be for GPIO regulator control instead? > + > reset-gpios: > description: |- > Reference to the GPIO connected to the XCLR pin, if any.
On 4/3/24 12:49, Pavel Machek wrote: > Hi! > >> From: Luis Garcia <git@luigi311.com> >> >> Add powerdown-gpio binding as it is required for some boards > > "." at end of sentence. > >> Signed-off-by: Ondrej Jirman <megi@xff.cz> >> Signed-off-by: Luis Garcia <git@luigi311.com> > > If the patch is from Ondrej, he should be in From:, I believe. > > Best regards, > Pavel Forgot to change the from in v4 but should be in v5
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml index c978abc0cdb3..33338139e6e8 100644 --- a/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx258.yaml @@ -36,6 +36,10 @@ properties: reg: maxItems: 1 + powerdown-gpios: + description: + Reference to the GPIO connected to the PWDN pin, if any. + reset-gpios: description: |- Reference to the GPIO connected to the XCLR pin, if any.