diff mbox series

[5/5] pinctrl: realtek: fix module autoloading

Message ID 20240410170150.248428-5-krzk@kernel.org (mailing list archive)
State Superseded
Headers show
Series [1/5] pinctrl: freescale: imx8ulp: fix module autoloading | expand

Commit Message

Krzysztof Kozlowski April 10, 2024, 5:01 p.m. UTC 
Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
based on the alias from of_device_id table.  Pin controllers are
considered core components, so usually they are built-in, however these

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
---
 drivers/pinctrl/realtek/pinctrl-rtd1315e.c | 1 +
 drivers/pinctrl/realtek/pinctrl-rtd1319d.c | 1 +
 2 files changed, 2 insertions(+)

Comments

Fabio Estevam April 10, 2024, 11:36 p.m. UTC | #1 
On Wed, Apr 10, 2024 at 2:02 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>
> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
> based on the alias from of_device_id table.  Pin controllers are
> considered core components, so usually they are built-in, however these

You forgot to complete the sentence.
Krzysztof Kozlowski April 11, 2024, 6:40 a.m. UTC | #2 
On 11/04/2024 01:36, Fabio Estevam wrote:
> On Wed, Apr 10, 2024 at 2:02 PM Krzysztof Kozlowski <krzk@kernel.org> wrote:
>>
>> Add MODULE_DEVICE_TABLE(), so the module could be properly autoloaded
>> based on the alias from of_device_id table.  Pin controllers are
>> considered core components, so usually they are built-in, however these
> 
> You forgot to complete the sentence.

Yanked too little,
Yanked not enough,
Can cause a spittle,
From one's mouth.

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1315e.c b/drivers/pinctrl/realtek/pinctrl-rtd1315e.c
index 10afc736a52b..86f919122bed 100644
--- a/drivers/pinctrl/realtek/pinctrl-rtd1315e.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd1315e.c
@@ -1414,6 +1414,7 @@  static const struct of_device_id rtd1315e_pinctrl_of_match[] = {
 	{ .compatible = "realtek,rtd1315e-pinctrl", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, rtd1315e_pinctrl_of_match);
 
 static struct platform_driver rtd1315e_pinctrl_driver = {
 	.driver = {
diff --git a/drivers/pinctrl/realtek/pinctrl-rtd1319d.c b/drivers/pinctrl/realtek/pinctrl-rtd1319d.c
index b1a654ac30dc..474c337d2d05 100644
--- a/drivers/pinctrl/realtek/pinctrl-rtd1319d.c
+++ b/drivers/pinctrl/realtek/pinctrl-rtd1319d.c
@@ -1584,6 +1584,7 @@  static const struct of_device_id rtd1319d_pinctrl_of_match[] = {
 	{ .compatible = "realtek,rtd1319d-pinctrl", },
 	{},
 };
+MODULE_DEVICE_TABLE(of, rtd1319d_pinctrl_of_match);
 
 static struct platform_driver rtd1319d_pinctrl_driver = {
 	.driver = {