diff mbox series

[4/7] arm64: dts: imx8qm-mek: add pwm and i2c in lvds subsystem

Message ID 20240606-imx8qm-dts-usb-v1-4-565721b64f25@nxp.com (mailing list archive)
State Superseded
Headers show
Series arm64: dts: imx8qm: add subsystem lvds and mipi | expand

Commit Message

Frank Li June 6, 2024, 6:46 p.m. UTC 
Add pwm[0,1] and i2c[0,1] in lvds subsystem.

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
 arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 92 ++++++++++++++++++++++++++++
 1 file changed, 92 insertions(+)

Comments

Peng Fan June 7, 2024, 1:33 a.m. UTC | #1 
> Subject: [PATCH 4/7] arm64: dts: imx8qm-mek: add pwm and i2c in lvds
> subsystem
> 
> Add pwm[0,1] and i2c[0,1] in lvds subsystem.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Fabio Estevam June 7, 2024, 1:38 a.m. UTC | #2 
On Thu, Jun 6, 2024 at 3:47 PM Frank Li <Frank.Li@nxp.com> wrote:

> +               brightness-levels = < 0  1  2  3  4  5  6  7  8  9
> +                                    10 11 12 13 14 15 16 17 18 19
> +                                    20 21 22 23 24 25 26 27 28 29
> +                                    30 31 32 33 34 35 36 37 38 39
> +                                    40 41 42 43 44 45 46 47 48 49
> +                                    50 51 52 53 54 55 56 57 58 59
> +                                    60 61 62 63 64 65 66 67 68 69
> +                                    70 71 72 73 74 75 76 77 78 79
> +                                    80 81 82 83 84 85 86 87 88 89
> +                                    90 91 92 93 94 95 96 97 98 99
> +                                   100>;

You can use this instead:

num-interpolated-steps = <100>;
Alexander Stein June 7, 2024, 6:19 a.m. UTC | #3 
Hi,

Am Donnerstag, 6. Juni 2024, 20:46:58 CEST schrieb Frank Li:
> Add pwm[0,1] and i2c[0,1] in lvds subsystem.
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
>  arch/arm64/boot/dts/freescale/imx8qm-mek.dts | 92 ++++++++++++++++++++++++++++
>  1 file changed, 92 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> index dbd478af2e474..80cb834d56bc2 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> +++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
> @@ -93,6 +93,42 @@ rsc_table1: memory@901ff000 {
>  		};
>  	};
>  
> +	lvds_backlight0: backlight-lvds0 {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm_lvds0 0 100000 0>;
> +
> +		brightness-levels = < 0  1  2  3  4  5  6  7  8  9
> +				     10 11 12 13 14 15 16 17 18 19
> +				     20 21 22 23 24 25 26 27 28 29
> +				     30 31 32 33 34 35 36 37 38 39
> +				     40 41 42 43 44 45 46 47 48 49
> +				     50 51 52 53 54 55 56 57 58 59
> +				     60 61 62 63 64 65 66 67 68 69
> +				     70 71 72 73 74 75 76 77 78 79
> +				     80 81 82 83 84 85 86 87 88 89
> +				     90 91 92 93 94 95 96 97 98 99
> +				    100>;
> +		default-brightness-level = <80>;
> +	};
> +
> +	lvds_backlight1: backlight-lvds1 {
> +		compatible = "pwm-backlight";
> +		pwms = <&pwm_lvds1 0 100000 0>;
> +
> +		brightness-levels = < 0  1  2  3  4  5  6  7  8  9
> +				     10 11 12 13 14 15 16 17 18 19
> +				     20 21 22 23 24 25 26 27 28 29
> +				     30 31 32 33 34 35 36 37 38 39
> +				     40 41 42 43 44 45 46 47 48 49
> +				     50 51 52 53 54 55 56 57 58 59
> +				     60 61 62 63 64 65 66 67 68 69
> +				     70 71 72 73 74 75 76 77 78 79
> +				     80 81 82 83 84 85 86 87 88 89
> +				     90 91 92 93 94 95 96 97 98 99
> +				    100>;
> +		default-brightness-level = <80>;
> +	};
> +
>  	reg_usdhc2_vmmc: usdhc2-vmmc {
>  		compatible = "regulator-fixed";
>  		regulator-name = "SD1_SPWR";
> @@ -334,6 +370,24 @@ wm8960: audio-codec@1a {
>  	};
>  };
>  
> +&i2c1_lvds0 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;

These two properties should be part of the .dtsi.

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_lvds0_lpi2c1>;
> +	clock-frequency = <100000>;
> +	status = "okay";
> +};
> +
> +&i2c1_lvds1 {
> +	#address-cells = <1>;
> +	#size-cells = <0>;

These two properties should be part of the .dtsi.

Best regards,
Alexander

> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_lvds1_lpi2c1>;
> +	clock-frequency = <100000>;
> +	status = "okay";
> +};
> +
>  &flexcan1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_flexcan1>;
> @@ -449,6 +503,18 @@ &fec2 {
>  	status = "okay";
>  };
>  
> +&pwm_lvds0 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm_lvds0>;
> +	status = "okay";
> +};
> +
> +&pwm_lvds1 {
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&pinctrl_pwm_lvds1>;
> +	status = "okay";
> +};
> +
>  &usdhc1 {
>  	pinctrl-names = "default";
>  	pinctrl-0 = <&pinctrl_usdhc1>;
> @@ -675,6 +741,32 @@ IMX8QM_M41_GPIO0_01_DMA_UART3_TX			0x06000020
>  		>;
>  	};
>  
> +	pinctrl_lvds0_lpi2c1: lvds0lpi2c1grp {
> +		fsl,pins = <
> +			IMX8QM_LVDS0_I2C1_SCL_LVDS0_I2C1_SCL	0xc600004c
> +			IMX8QM_LVDS0_I2C1_SDA_LVDS0_I2C1_SDA	0xc600004c
> +		>;
> +	};
> +
> +	pinctrl_lvds1_lpi2c1: lvds1lpi2c1grp {
> +		fsl,pins = <
> +			IMX8QM_LVDS1_I2C1_SCL_LVDS1_I2C1_SCL	0xc600004c
> +			IMX8QM_LVDS1_I2C1_SDA_LVDS1_I2C1_SDA	0xc600004c
> +		>;
> +	};
> +
> +	pinctrl_pwm_lvds0: pwmlvds0grp {
> +		fsl,pins = <
> +			IMX8QM_LVDS0_GPIO00_LVDS0_PWM0_OUT		0x00000020
> +		>;
> +	};
> +
> +	pinctrl_pwm_lvds1: pwmlvds1grp {
> +		fsl,pins = <
> +			IMX8QM_LVDS1_GPIO00_LVDS1_PWM0_OUT		0x00000020
> +		>;
> +	};
> +
>  	pinctrl_sai0: sai0grp {
>  		fsl,pins = <
>  			IMX8QM_SPI0_CS1_AUD_SAI0_TXC				0x0600004c
> 
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
index dbd478af2e474..80cb834d56bc2 100644
--- a/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
+++ b/arch/arm64/boot/dts/freescale/imx8qm-mek.dts
@@ -93,6 +93,42 @@  rsc_table1: memory@901ff000 {
 		};
 	};
 
+	lvds_backlight0: backlight-lvds0 {
+		compatible = "pwm-backlight";
+		pwms = <&pwm_lvds0 0 100000 0>;
+
+		brightness-levels = < 0  1  2  3  4  5  6  7  8  9
+				     10 11 12 13 14 15 16 17 18 19
+				     20 21 22 23 24 25 26 27 28 29
+				     30 31 32 33 34 35 36 37 38 39
+				     40 41 42 43 44 45 46 47 48 49
+				     50 51 52 53 54 55 56 57 58 59
+				     60 61 62 63 64 65 66 67 68 69
+				     70 71 72 73 74 75 76 77 78 79
+				     80 81 82 83 84 85 86 87 88 89
+				     90 91 92 93 94 95 96 97 98 99
+				    100>;
+		default-brightness-level = <80>;
+	};
+
+	lvds_backlight1: backlight-lvds1 {
+		compatible = "pwm-backlight";
+		pwms = <&pwm_lvds1 0 100000 0>;
+
+		brightness-levels = < 0  1  2  3  4  5  6  7  8  9
+				     10 11 12 13 14 15 16 17 18 19
+				     20 21 22 23 24 25 26 27 28 29
+				     30 31 32 33 34 35 36 37 38 39
+				     40 41 42 43 44 45 46 47 48 49
+				     50 51 52 53 54 55 56 57 58 59
+				     60 61 62 63 64 65 66 67 68 69
+				     70 71 72 73 74 75 76 77 78 79
+				     80 81 82 83 84 85 86 87 88 89
+				     90 91 92 93 94 95 96 97 98 99
+				    100>;
+		default-brightness-level = <80>;
+	};
+
 	reg_usdhc2_vmmc: usdhc2-vmmc {
 		compatible = "regulator-fixed";
 		regulator-name = "SD1_SPWR";
@@ -334,6 +370,24 @@  wm8960: audio-codec@1a {
 	};
 };
 
+&i2c1_lvds0 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lvds0_lpi2c1>;
+	clock-frequency = <100000>;
+	status = "okay";
+};
+
+&i2c1_lvds1 {
+	#address-cells = <1>;
+	#size-cells = <0>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_lvds1_lpi2c1>;
+	clock-frequency = <100000>;
+	status = "okay";
+};
+
 &flexcan1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_flexcan1>;
@@ -449,6 +503,18 @@  &fec2 {
 	status = "okay";
 };
 
+&pwm_lvds0 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm_lvds0>;
+	status = "okay";
+};
+
+&pwm_lvds1 {
+	pinctrl-names = "default";
+	pinctrl-0 = <&pinctrl_pwm_lvds1>;
+	status = "okay";
+};
+
 &usdhc1 {
 	pinctrl-names = "default";
 	pinctrl-0 = <&pinctrl_usdhc1>;
@@ -675,6 +741,32 @@  IMX8QM_M41_GPIO0_01_DMA_UART3_TX			0x06000020
 		>;
 	};
 
+	pinctrl_lvds0_lpi2c1: lvds0lpi2c1grp {
+		fsl,pins = <
+			IMX8QM_LVDS0_I2C1_SCL_LVDS0_I2C1_SCL	0xc600004c
+			IMX8QM_LVDS0_I2C1_SDA_LVDS0_I2C1_SDA	0xc600004c
+		>;
+	};
+
+	pinctrl_lvds1_lpi2c1: lvds1lpi2c1grp {
+		fsl,pins = <
+			IMX8QM_LVDS1_I2C1_SCL_LVDS1_I2C1_SCL	0xc600004c
+			IMX8QM_LVDS1_I2C1_SDA_LVDS1_I2C1_SDA	0xc600004c
+		>;
+	};
+
+	pinctrl_pwm_lvds0: pwmlvds0grp {
+		fsl,pins = <
+			IMX8QM_LVDS0_GPIO00_LVDS0_PWM0_OUT		0x00000020
+		>;
+	};
+
+	pinctrl_pwm_lvds1: pwmlvds1grp {
+		fsl,pins = <
+			IMX8QM_LVDS1_GPIO00_LVDS1_PWM0_OUT		0x00000020
+		>;
+	};
+
 	pinctrl_sai0: sai0grp {
 		fsl,pins = <
 			IMX8QM_SPI0_CS1_AUD_SAI0_TXC				0x0600004c