| Message ID | 20240627203308.476437-1-Frank.Li@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/1] spi: dt-bindings: fsl-dspi: add dmas and dma-names properties | expand |
On Thu, Jun 27, 2024 at 04:33:08PM -0400, Frank Li wrote: > Add dmas and dma-names properties because dspi support dma transfer. > Fix below warnings: > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: spi@2120000: Unevaluated properties are not allowed ('dma-names', 'dmas', 'little-endian' were unexpected) > from schema $id: http://devicetree.org/schemas/spi/fsl,dspi.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > --- For the contents: Reviewed-by: Vladimir Oltean <olteanv@gmail.com> and FWIW, I noticed this as well, but didn't want to put yet another roadblock in the conversion of a binding which was way overdue. I was planning to send a patch as well, once the binding was merged. But... to whose tree is this targeted? I only got a notification from Shawn for patch 3/3 (the device tree change), but none for the acceptance of the other 2 patches.
On Fri, Jun 28, 2024 at 12:53:38AM +0300, Vladimir Oltean wrote: > On Thu, Jun 27, 2024 at 04:33:08PM -0400, Frank Li wrote: > > Add dmas and dma-names properties because dspi support dma transfer. > > Fix below warnings: > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: spi@2120000: Unevaluated properties are not allowed ('dma-names', 'dmas', 'little-endian' were unexpected) > > from schema $id: http://devicetree.org/schemas/spi/fsl,dspi.yaml# > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > --- > > For the contents: > > Reviewed-by: Vladimir Oltean <olteanv@gmail.com> > > and FWIW, I noticed this as well, but didn't want to put yet another > roadblock in the conversion of a binding which was way overdue. > I was planning to send a patch as well, once the binding was merged. > > But... to whose tree is this targeted? I only got a notification > from Shawn for patch 3/3 (the device tree change), but none for the > acceptance of the other 2 patches. This patch base on the below patch: https://lore.kernel.org/imx/20240624-ls_qspi-v4-0-3d1c6f5005bf@nxp.com/T/#t Sorry, I miss understand 3 patches already picked. Actually only pick 3rd one. Frank
On Thu, Jun 27, 2024 at 06:07:08PM -0400, Frank Li wrote: > On Fri, Jun 28, 2024 at 12:53:38AM +0300, Vladimir Oltean wrote: > > On Thu, Jun 27, 2024 at 04:33:08PM -0400, Frank Li wrote: > > > Add dmas and dma-names properties because dspi support dma transfer. > > > Fix below warnings: > > > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: spi@2120000: Unevaluated properties are not allowed ('dma-names', 'dmas', 'little-endian' were unexpected) > > > from schema $id: http://devicetree.org/schemas/spi/fsl,dspi.yaml# > > > > > > Signed-off-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > > For the contents: > > > > Reviewed-by: Vladimir Oltean <olteanv@gmail.com> > > > > and FWIW, I noticed this as well, but didn't want to put yet another > > roadblock in the conversion of a binding which was way overdue. > > I was planning to send a patch as well, once the binding was merged. > > > > But... to whose tree is this targeted? I only got a notification > > from Shawn for patch 3/3 (the device tree change), but none for the > > acceptance of the other 2 patches. > > This patch base on the below patch: > https://lore.kernel.org/imx/20240624-ls_qspi-v4-0-3d1c6f5005bf@nxp.com/T/#t > > Sorry, I miss understand 3 patches already picked. Actually only pick 3rd > one. > > Frank > Yup. I guess it's best to resend a new version of the (reduced) series to the SPI tree now, with this patch rolled up into the dt-schema conversion, and the review tags preserved. But you might want to wait at least 24 hours since you sent this patch, to allow people a chance to respond.
On 27/06/2024 22:33, Frank Li wrote: > Add dmas and dma-names properties because dspi support dma transfer. > Fix below warnings: > arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: spi@2120000: Unevaluated properties are not allowed ('dma-names', 'dmas', 'little-endian' were unexpected) > from schema $id: http://devicetree.org/schemas/spi/fsl,dspi.yaml# > > Signed-off-by: Frank Li <Frank.Li@nxp.com> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
On Fri, Jun 28, 2024 at 12:53:38AM +0300, Vladimir Oltean wrote: > and FWIW, I noticed this as well, but didn't want to put yet another > roadblock in the conversion of a binding which was way overdue. > I was planning to send a patch as well, once the binding was merged. If I've seen a report that a new binding introduces errors then I'm very unlikely to apply it, I'd guess that's true for other maintainers too - it's probably best to fix reported errors promptly by default.
diff --git a/Documentation/devicetree/bindings/spi/fsl,dspi.yaml b/Documentation/devicetree/bindings/spi/fsl,dspi.yaml index eb3deac49bb1a..7ca8fceda7179 100644 --- a/Documentation/devicetree/bindings/spi/fsl,dspi.yaml +++ b/Documentation/devicetree/bindings/spi/fsl,dspi.yaml @@ -51,6 +51,16 @@ properties: items: - const: dspi + dmas: + items: + - description: DMA controller phandle and request line for TX + - description: DMA controller phandle and request line for RX + + dma-names: + items: + - const: tx + - const: rx + spi-num-chipselects: $ref: /schemas/types.yaml#/definitions/uint32 description:
Add dmas and dma-names properties because dspi support dma transfer. Fix below warnings: arch/arm64/boot/dts/freescale/fsl-ls1028a-kontron-sl28-var1.dtb: spi@2120000: Unevaluated properties are not allowed ('dma-names', 'dmas', 'little-endian' were unexpected) from schema $id: http://devicetree.org/schemas/spi/fsl,dspi.yaml# Signed-off-by: Frank Li <Frank.Li@nxp.com> --- Documentation/devicetree/bindings/spi/fsl,dspi.yaml | 10 ++++++++++ 1 file changed, 10 insertions(+)