From patchwork Mon Jul 8 17:08:05 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13726906 Received: from DU2PR03CU002.outbound.protection.outlook.com (mail-northeuropeazon11012024.outbound.protection.outlook.com [52.101.66.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B10F414A095 for ; Mon, 8 Jul 2024 17:08:32 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=52.101.66.24 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720458514; cv=fail; b=VhzPVDx24AjbB59cQt88ceGDalmtQPsgrDdMWgpvEWpsak4+mj5fzGcR57+dxi3a0o+42JcQ7OOb3UtTEBK5+w9m+qha8wI67EySq7CdFb2HN87htHnPoUrbyyyqkyP9S8hsvDfS8ni7skY4Daf3dEdzJvaeR+ept6M1rR8eY44= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1720458514; c=relaxed/simple; bh=SGtc8Ve8rC1yrCNM7OE5EflePLc4rQ0NW2nqZMfaMX0=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=Tb/fCWaKYiSQj5j0+dbuGZBvlU9Ega3G/HkBLlhYoTf7Fgus9rTA+ZdW7CNg71pYJ5LuLwj010XaWsmH7HsKVvPDIjT7rXS+3soidW9ZK7chFGKvPQmwepyC/Kz6j+wp19ZcvvJleCetWTvD8Zpb3uCbifSUqb/hIQs+psTNm70= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b=ET+EdSC1; arc=fail smtp.client-ip=52.101.66.24 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=nxp.com header.i=@nxp.com header.b="ET+EdSC1" ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=O2cVksMZaxqj25xj8gxe7z1SdCYDFkynWbE8Wr3Up0ba9lCh/CR3gkGWjH6kLdg3pXl8JHktaEKTdQMmxVnJKJA9vjiQs6epLEkKjA4IKNNan9ktrxBy+lMsXP077a+hIfpgp7zyoVC1XsutIL4L5IU+E+t0Gn3X0HRpmNCPuWEV+pLo2B/8i/MntJ5npdhyrplVIE07zDsaFVRcrSJAc3mXPIdQyWI6r2/SE9gTz2dkYAPLsVUOoU+yAW3TIIzf799ekL13i0P9vGeJ2gFNoD3DCcIWXetfo8S+bvtavl+jTuQFYiOocK/sjV5r+CIg3VScJOJqkdY3q0RJTtFPug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=gV08PDInB95HNGYt/mV+eg3/3PupCSil+Z3uzpzZ9oY=; b=Toyixv3dt8P/j5K6dVzHv2cjbAATyXOF6CkTlBhBoIB3YseC/fN3L5wqp5SUn6oi0/Co9PZe4EHH6VoxM57ypZF4QIwNXazFFVg7Eg4kjr6LO0V3cqaoIC7JM5lwizfovFQsZJoE4fMfC7coVrVJh+z9IWNg0XgsntRfLQnSlzYez1ycNh0scCM8t+HcBSyfo4eGt9uPi7EiojCq2ZoVbiB6+LJhgPbIafCnSbojzA5wtX0m/UxU2jo+3grP2/NRLI+ae6yxwL7Ag7Y6q9yrRp7RZ4LONnOqCcq1EXjOV6QF3v+OAImDECbxpP4NxGdl4OgBNGucveoYbpqC8o80AA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=gV08PDInB95HNGYt/mV+eg3/3PupCSil+Z3uzpzZ9oY=; b=ET+EdSC1KwMqp6IxNRnmwiRit5f00tY9FLzd1bpJGI9PMWLaEvPiOQnfCLtHLRJaSqQu8ghL6UMf8L/x4QOPZxWfCgzNI/YNI2M2Qb7+tc2CUP2CyPraU7+V1vfVmFySl2jOTgC33/Hk+rSsgIkWT9Zv3MNTzY3ZljCn43BHk34= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by DBBPR04MB7867.eurprd04.prod.outlook.com (2603:10a6:10:1e5::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7741.35; Mon, 8 Jul 2024 17:08:29 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%2]) with mapi id 15.20.7741.033; Mon, 8 Jul 2024 17:08:29 +0000 From: Frank Li Date: Mon, 08 Jul 2024 13:08:05 -0400 Subject: [PATCH v7 01/10] PCI: imx6: Fix establish link failure in EP mode for iMX8MM and iMX8MP Message-Id: <20240708-pci2_upstream-v7-1-ac00b8174f89@nxp.com> References: <20240708-pci2_upstream-v7-0-ac00b8174f89@nxp.com> In-Reply-To: <20240708-pci2_upstream-v7-0-ac00b8174f89@nxp.com> To: Richard Zhu , Lucas Stach , Lorenzo Pieralisi , =?utf-8?q?Krzysztof_Wilczy?= =?utf-8?q?=C5=84ski?= , Rob Herring , Bjorn Helgaas , Shawn Guo , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team , Philipp Zabel , Liam Girdwood , Mark Brown , Manivannan Sadhasivam , Krzysztof Kozlowski , Conor Dooley Cc: linux-pci@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, bpf@vger.kernel.org, devicetree@vger.kernel.org, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1720458497; l=1527; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=ANVarESKV+O6tlN/FaWd8tQfK1xN7/HQ77vO4gvZSgQ=; b=1IZKWaqEHxFdmX7g8K9hpBEVn4jluQEzZh/gw7sNY9OY+4CWjTi0yZKS+m18CnPYkR/XEjasO YSwPxAmbeqlBAMUpl+xf4HuEXPNxZt5QRGY6Xt8XEzZrpbUn6ZqgmBK X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: SJ0PR13CA0198.namprd13.prod.outlook.com (2603:10b6:a03:2c3::23) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|DBBPR04MB7867:EE_ X-MS-Office365-Filtering-Correlation-Id: 998b2198-f93d-4e16-6556-08dc9f7096b9 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|52116014|7416014|1800799024|38350700014|921020; X-Microsoft-Antispam-Message-Info: =?utf-8?q?LIagYC4h6WFCixljBU1tNZXM1DC1XFI?= =?utf-8?q?ZBiS+BxvwXPy8VfbfLlOrb3lvhewj8E1C2aynuB091t5+SeLdvnI6ct/WwhR1iQsc?= =?utf-8?q?8WmQQc+De7cFTR7ciDQ5UnyJJt4oGW/dfbB378583E8kfTut0oj1jwfIzxynEx2Sy?= =?utf-8?q?H5sWwdJqLAOA6ApmYHXSPBXv7/2gIXzUUn6QWfHOMx8jO7k68UDMlq3Nmmy/x47np?= =?utf-8?q?ueGVUMr9FwG0CaADNsO26qOdnm2YXH7Oah6I+5UwOu+6LaQiv/UGiHvXval9uhKX1?= =?utf-8?q?gfXQYizuNCiHMv0kLBgVw8FcyWLA3lBCFKpWV8TeRreGS/ylLJ8z0RIhEhVE6sy7h?= =?utf-8?q?Wh+FIVQXTkcYCE6RnTrLjsGZZEFGN2maDWLgvqZLvCK2bIwmOmRZYbkM2YnNqLo7a?= =?utf-8?q?/kBVzyoRXghoRJJXnd3zME1h3TX9zc80kpJkmj+XiBtChQOpVsaLDE//gtk9mQirZ?= =?utf-8?q?p8Se/oY3rfhCB/hWc6ghkaSVqrkRCaE00yctmH2Gb3xJeTK5m4d4xsy8gVyvjW5+B?= =?utf-8?q?n7WXIyXzsO3nrjmINmq1PKCYJFSJE1uCrqgdbmEqQ0/asfGPmLWvTc8QI9ucuI8SL?= =?utf-8?q?mIoZN0H8vb+ND+QAYnyvb7kpDrXSwGW9NMYwr74mw9QYZlqNtz32+p6I+yd/8S5bI?= =?utf-8?q?m8FZnZMYWTo+cMAcV/QHW6tQM4qoNqxkm95F/zqJcLFijeYG1k+gEBk9jAZUBGppu?= =?utf-8?q?/9aSP4gWb7pZAuYugYlvXq1qYZ/LSnEw8wstnxbaYMhcbyUEy+5PoPez3ZCsxoGiO?= =?utf-8?q?wqLAdrP1Vt/2EGmcH1DHNYobP+eNBrfMukelLUzHy/VUEdrckpnK87YGJ6qKFC3HI?= =?utf-8?q?t05jLexBicv6rAU+QdX87p3u/L6lu3V3PpKRQYcGcb83dPFkWhoFwW/ESHETOAdf8?= =?utf-8?q?EkMaf863tmDqubQnjVGSkFt31mEgA6Edha38LxcRLN/KRDhJxiOSTs2ZhL8v6eArK?= =?utf-8?q?O1oxYctau5P9F3JfkdpWZmwUq54eRDATsZCwaynZWxs9W8TCGxRBPlFuHtg7+6Ef6?= =?utf-8?q?ByYERP7ZpIPcmghfkM/HWkXKYIrh40I6aysafrweEwd2gEYnyVABV3jUNU0k0tgMJ?= =?utf-8?q?b9cSIjzJW7e0QdsCnGHdLtRarDQzYSWbRuyjTCVCtsPY6SdfL6DiVOnwtNazImzTL?= =?utf-8?q?1gV0aImpxLL6K9mid/EynHLtfj8Ghiks1+IH8I4ZG1WuFqSaXbwWNcX/D/i2mKrIt?= =?utf-8?q?POpKmIczZJw9m6+E4ggnZ0Okw9fUEc8CD6Dm3fZ6OYFnabxx9XAZn61ASYpyvyAmK?= =?utf-8?q?vJ+GfvU9fEL6qnm+6x8vedqymG+x06ipvK9pu1QTPa9f2YwzULEGcdg/1LSW9SHSc?= =?utf-8?q?WtKaPKlnHo49yo9iqlFagopRKbfusQ01Mi59l9ZHCX2JgRKSgIqMwRk=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(376014)(52116014)(7416014)(1800799024)(38350700014)(921020);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?dkmxei+UZSRr7ul/brhBCLctseKA?= =?utf-8?q?2CT6oSP2E49Tp5LUY5u4Z+E9pd5d6crpnUl6CwadmcCGkJYfSTqAx/uAepk1ErEo3?= =?utf-8?q?a4oCcHauRpSjA2SLv8O165fqUdOk7Jbxg0eMJZV7bn54vfns2Xqr6htZkAJavYQle?= =?utf-8?q?QZWLPYGKYpeAH1UDTQw+8Mz19ddmNfZRyEr9HyzyqjfUmFZGf+sPHX1FXC9ASIzqM?= =?utf-8?q?11gbe6Vv7X05aW9gjKPbYCLoL5OKa1bpyNGrm1VTiLTldEEQM58koM7S2rkERRJ/b?= =?utf-8?q?nbmZWaHl0yrfBDyeKZbObfseSRU9USvlY/NDE7hrWxSM67LehyJr6qE8HhZpZxazr?= =?utf-8?q?tY9204n9wfDphYkvqTUOl3PC+TYPPDauTZzSEjmu4KMh4vipnQn0oirlufXJT109I?= =?utf-8?q?2dyls0OgA2zypJ5LuyvtnVjhvt4cn9qvcFvHXzBBu0iDaZEreMQ4oQDcXwOgBDut8?= =?utf-8?q?bL4+I+R7P/FPz7HHqRVZM4VBKnUSnH4y1iBABMNcMPLszC03Y1KCuaAJsTjVD3xMY?= =?utf-8?q?RLPOCChm+i2/n12G2wsZlW2ASDu5MPcycHyPkmrlQVg+VOe54j29dQlarlKZLUx0g?= =?utf-8?q?NCJon8j4Vpo+tl/9vYT+WQ6XTgMejhKuzKfowPrPuEUCBcezh+DZlqlmgzgzL/89J?= =?utf-8?q?tnIkuRAzDB+Q7udSt289Ns/JLn3q1YOJO9SsdB/YP+f2MyzlfT+iZ1Re4n2mC7ikO?= =?utf-8?q?LNSP4HsIU2NGz4P9fST7CTke7xrZIMsOQ4WQEsJlPcpYrOXGBdPu2j0U/3aSYEnf4?= =?utf-8?q?283Vjx/0Z4z3B7UGfVPXZg6Zvwq70IIO9gKcPNafg36TLXTTuhEnw9/NAggriBDfz?= =?utf-8?q?JMWIH6HBNxuAp4iKFSdaA0AI9l7N7K4k/NnBaHSusIQhK0kuiT0M54xqPk20hOKsY?= =?utf-8?q?A53MuHE8j3higTuVx+xT0Xk/FW7ic+c9zRKp9+ZwJ5l6a1CKKVfUok1njyZFrJbEX?= =?utf-8?q?yZ7uxA1MAmhwLQp6hX/4sCMC4xVVrSRwmWm8zhnbycVCT/23vz0Jbn25S53SRZtFi?= =?utf-8?q?b3mXd1ZX7Ke+zUtkF4/LiXTcS08/Qaxr/15Ui7v5E0sPtdfeM5MoPJW6U0Bferkx3?= =?utf-8?q?L68DOWnVLeoTqwiJsq43cYFyGejS/fTn2Tr43+eGlaZLlDE29uTjwPuok1ldka71l?= =?utf-8?q?hQoKkxJEfJ6cW+fiod8sZLEi+f+Eqz2TUS5wcr5xXsJfsFBrr7yMUltTL6XDFiGq7?= =?utf-8?q?wuix7zeDQpFzeBTlJGWBYv4yEFdk+TU1o37mAIhLqvhWSPPfJ1XQwn5LjpwMx6WNr?= =?utf-8?q?dvZ41RWe+ZBx6rp84Iij7POaHXPhd8S42Mgw0GwJo5hVSi1xYhonOzjx9N4I6bmkY?= =?utf-8?q?e9TqVL1g5HV+hzZdh2SBmpBZJS5A89D/ec6Zu/wbYekSlaZCTGc0pQ9+VzS4fZD/7?= =?utf-8?q?AURgi61DSMOdidvOw2POLzZesd9IvH9VM2QaPQqih0ggSWGvSBAL7GyfXlVIdrbYK?= =?utf-8?q?Bj1jQGqK/iR0DEzW7Avaw/xWNNU7YQ95vIljaZSmMC3nvYQAwQGS2gDI=3D?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 998b2198-f93d-4e16-6556-08dc9f7096b9 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Jul 2024 17:08:29.4625 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 2XkY5T7VVNr4rsLXG6gtfc514zFaQ8m0zgC2FfkvSRG8aKk9e3Jn66LXA+Od4/L4cK3hY1ycnaUjACQ/eiB6TQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DBBPR04MB7867 From: Richard Zhu Add IMX6_PCIE_FLAG_HAS_APP_RESET flag to IMX8MM_EP and IMX8MP_EP drvdata. This flag was overlooked during code restructuring. It is crucial to release the app-reset from the System Reset Controller before initiating LTSSM to rectify the issue Fixes: 0c9651c21f2a ("PCI: imx6: Simplify reset handling by using *_FLAG_HAS_*_RESET") Signed-off-by: Richard Zhu Reviewed-by: Manivannan Sadhasivam Signed-off-by: Frank Li --- drivers/pci/controller/dwc/pci-imx6.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/pci/controller/dwc/pci-imx6.c b/drivers/pci/controller/dwc/pci-imx6.c index 917c69edee1d5..9a71b8aa09b3c 100644 --- a/drivers/pci/controller/dwc/pci-imx6.c +++ b/drivers/pci/controller/dwc/pci-imx6.c @@ -1578,7 +1578,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { }, [IMX8MM_EP] = { .variant = IMX8MM_EP, - .flags = IMX6_PCIE_FLAG_HAS_PHYDRV, + .flags = IMX6_PCIE_FLAG_HAS_APP_RESET | + IMX6_PCIE_FLAG_HAS_PHYDRV, .mode = DW_PCIE_EP_TYPE, .gpr = "fsl,imx8mm-iomuxc-gpr", .clk_names = imx8mm_clks, @@ -1589,7 +1590,8 @@ static const struct imx6_pcie_drvdata drvdata[] = { }, [IMX8MP_EP] = { .variant = IMX8MP_EP, - .flags = IMX6_PCIE_FLAG_HAS_PHYDRV, + .flags = IMX6_PCIE_FLAG_HAS_APP_RESET | + IMX6_PCIE_FLAG_HAS_PHYDRV, .mode = DW_PCIE_EP_TYPE, .gpr = "fsl,imx8mp-iomuxc-gpr", .clk_names = imx8mm_clks,