diff mbox series

[v1,3/4] loongarch: dts: remove non-existent DAC from 2k1000-ref

Message ID 20240717-preacher-sandal-2aeffa322b9f@spud (mailing list archive)
State In Next, archived
Headers show
Series Removal of non-existent DAC nodes | expand

Commit Message

Conor Dooley July 17, 2024, 9:37 a.m. UTC 
From: Conor Dooley <conor.dooley@microchip.com>

The 2k1000 reference boards do not have a Rohm DAC on them as far as I
can tell, and they certainly do not have a dh2228fv, as this device does
not actually exist! Remove the dac nodes from the devicetrees as it is
not acceptable to pretend to have a device on a board in order to bind
the spidev driver in Linux.

Signed-off-by: Conor Dooley <conor.dooley@microchip.com>
---
 arch/loongarch/boot/dts/loongson-2k1000-ref.dts | 5 -----
 1 file changed, 5 deletions(-)

Comments

Krzysztof Kozlowski July 17, 2024, 9:39 a.m. UTC | #1 
On 17/07/2024 11:37, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@microchip.com>
> 
> The 2k1000 reference boards do not have a Rohm DAC on them as far as I
> can tell, and they certainly do not have a dh2228fv, as this device does
> not actually exist! Remove the dac nodes from the devicetrees as it is
> not acceptable to pretend to have a device on a board in order to bind
> the spidev driver in Linux.
> 
> Signed-off-by: Conor Dooley <conor.dooley@microchip.com>

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>

Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/loongarch/boot/dts/loongson-2k1000-ref.dts b/arch/loongarch/boot/dts/loongson-2k1000-ref.dts
index 23cf26cc3e5f..3514ea78f525 100644
--- a/arch/loongarch/boot/dts/loongson-2k1000-ref.dts
+++ b/arch/loongarch/boot/dts/loongson-2k1000-ref.dts
@@ -90,11 +90,6 @@  &spi0 {
 
 	#address-cells = <1>;
 	#size-cells = <0>;
-	spidev@0 {
-		compatible = "rohm,dh2228fv";
-		spi-max-frequency = <100000000>;
-		reg = <0>;
-	};
 };
 
 &ehci0 {