| Message ID | 20240801110136.1031689-1-xu.yang_2@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] phy: fsl-imx8mq-usb: fix tuning parameter name | expand |
Hi, Am Donnerstag, 1. August 2024, 13:01:36 CEST schrieb Xu Yang: > According to fsl,imx8mq-usb-phy.yaml, this tuning parameter should be > fsl,phy-pcs-tx-deemph-3p5db-attenuation-db. > > Fixes: c971874a89e1 ("phy: fsl-imx8mq-usb: fix tuning parameter name") Maybe you accidently selected the wrong commit here. I think this should be Fixes: 63c85ad0cd811 ("phy: fsl-imx8mp-usb: add support for phy tuning") Best regards, Alexander > Cc: stable@vger.kernel.org > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > --- > Changes in v2: > - add fixes > --- > drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > index 0b9a59d5b8f0..adc6394626ce 100644 > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > @@ -176,7 +176,7 @@ static void imx8m_get_phy_tuning_data(struct imx8mq_usb_phy *imx_phy) > imx_phy->comp_dis_tune = > phy_comp_dis_tune_from_property(imx_phy->comp_dis_tune); > > - if (device_property_read_u32(dev, "fsl,pcs-tx-deemph-3p5db-attenuation-db", > + if (device_property_read_u32(dev, "fsl,phy-pcs-tx-deemph-3p5db-attenuation-db", > &imx_phy->pcs_tx_deemph_3p5db)) > imx_phy->pcs_tx_deemph_3p5db = PHY_TUNE_DEFAULT; > else >
On Thu, Aug 01, 2024 at 02:24:15PM +0200, Alexander Stein wrote: > Hi, > > Am Donnerstag, 1. August 2024, 13:01:36 CEST schrieb Xu Yang: > > According to fsl,imx8mq-usb-phy.yaml, this tuning parameter should be > > fsl,phy-pcs-tx-deemph-3p5db-attenuation-db. > > > > Fixes: c971874a89e1 ("phy: fsl-imx8mq-usb: fix tuning parameter name") > > Maybe you accidently selected the wrong commit here. I think this should be > Fixes: 63c85ad0cd811 ("phy: fsl-imx8mp-usb: add support for phy tuning") Thank you! I find the commit but wrongly paste another one. Best Regards, Xu Yang > > Best regards, > Alexander > > > Cc: stable@vger.kernel.org > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > > > > --- > > Changes in v2: > > - add fixes > > --- > > drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > > index 0b9a59d5b8f0..adc6394626ce 100644 > > --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > > +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c > > @@ -176,7 +176,7 @@ static void imx8m_get_phy_tuning_data(struct imx8mq_usb_phy *imx_phy) > > imx_phy->comp_dis_tune = > > phy_comp_dis_tune_from_property(imx_phy->comp_dis_tune); > > > > - if (device_property_read_u32(dev, "fsl,pcs-tx-deemph-3p5db-attenuation-db", > > + if (device_property_read_u32(dev, "fsl,phy-pcs-tx-deemph-3p5db-attenuation-db", > > &imx_phy->pcs_tx_deemph_3p5db)) > > imx_phy->pcs_tx_deemph_3p5db = PHY_TUNE_DEFAULT; > > else > > > > > -- > TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany > Amtsgericht München, HRB 105018 > Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider > http://www.tq-group.com/ > >
diff --git a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c index 0b9a59d5b8f0..adc6394626ce 100644 --- a/drivers/phy/freescale/phy-fsl-imx8mq-usb.c +++ b/drivers/phy/freescale/phy-fsl-imx8mq-usb.c @@ -176,7 +176,7 @@ static void imx8m_get_phy_tuning_data(struct imx8mq_usb_phy *imx_phy) imx_phy->comp_dis_tune = phy_comp_dis_tune_from_property(imx_phy->comp_dis_tune); - if (device_property_read_u32(dev, "fsl,pcs-tx-deemph-3p5db-attenuation-db", + if (device_property_read_u32(dev, "fsl,phy-pcs-tx-deemph-3p5db-attenuation-db", &imx_phy->pcs_tx_deemph_3p5db)) imx_phy->pcs_tx_deemph_3p5db = PHY_TUNE_DEFAULT; else
According to fsl,imx8mq-usb-phy.yaml, this tuning parameter should be fsl,phy-pcs-tx-deemph-3p5db-attenuation-db. Fixes: c971874a89e1 ("phy: fsl-imx8mq-usb: fix tuning parameter name") Cc: stable@vger.kernel.org Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- Changes in v2: - add fixes --- drivers/phy/freescale/phy-fsl-imx8mq-usb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)