diff mbox series

[v4,1/1] dt-bindings: memory-controllers: fsl,ifc: split child node differences

Message ID 20240909165358.2384975-1-Frank.Li@nxp.com (mailing list archive)
State In Next, archived
Headers show
Series [v4,1/1] dt-bindings: memory-controllers: fsl,ifc: split child node differences | expand

Commit Message

Frank Li Sept. 9, 2024, 4:53 p.m. UTC
ifc can connect nor, nand and fpag. Split "^.*@..." into "nand@..." and
"(flash|fpga|board-control|cpld)@..." to better describe the child's node
binding requirements.

Fix below warning:
arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
	failed to match any schema with compatible: ['fsl,ifc-nand']

Signed-off-by: Frank Li <Frank.Li@nxp.com>
---
Change from v3 to v4
- add pattern property for fpga.
- fine tune commit message.
Change from v2 to v3
- add partition child node for nand
- Only partition property is used at ppc
Change from v1 to v2
- add address-cells and size-cells
---
 .../memory-controllers/fsl/fsl,ifc.yaml       | 32 ++++++++++++++++---
 1 file changed, 27 insertions(+), 5 deletions(-)

Comments

Rob Herring (Arm) Sept. 11, 2024, 2:50 p.m. UTC | #1
On Mon, 09 Sep 2024 12:53:57 -0400, Frank Li wrote:
> ifc can connect nor, nand and fpag. Split "^.*@..." into "nand@..." and
> "(flash|fpga|board-control|cpld)@..." to better describe the child's node
> binding requirements.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
> 	failed to match any schema with compatible: ['fsl,ifc-nand']
> 
> Signed-off-by: Frank Li <Frank.Li@nxp.com>
> ---
> Change from v3 to v4
> - add pattern property for fpga.
> - fine tune commit message.
> Change from v2 to v3
> - add partition child node for nand
> - Only partition property is used at ppc
> Change from v1 to v2
> - add address-cells and size-cells
> ---
>  .../memory-controllers/fsl/fsl,ifc.yaml       | 32 ++++++++++++++++---
>  1 file changed, 27 insertions(+), 5 deletions(-)
> 

Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Krzysztof Kozlowski Sept. 30, 2024, 10:46 a.m. UTC | #2
On Mon, 09 Sep 2024 12:53:57 -0400, Frank Li wrote:
> ifc can connect nor, nand and fpag. Split "^.*@..." into "nand@..." and
> "(flash|fpga|board-control|cpld)@..." to better describe the child's node
> binding requirements.
> 
> Fix below warning:
> arch/arm64/boot/dts/freescale/fsl-ls1043a-qds.dtb: /soc/memory-controller@1530000/nand@1,0:
> 	failed to match any schema with compatible: ['fsl,ifc-nand']
> 
> [...]

Applied, thanks!

[1/1] dt-bindings: memory-controllers: fsl,ifc: split child node differences
      https://git.kernel.org/krzk/linux-mem-ctrl/c/89e6684538f59093d89eda50e30a6f2644b06ab6

Best regards,
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
index d1c3421bee107..f7cf0f91c1c02 100644
--- a/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
+++ b/Documentation/devicetree/bindings/memory-controllers/fsl/fsl,ifc.yaml
@@ -58,17 +58,39 @@  properties:
       access window as configured.
 
 patternProperties:
-  "^.*@[a-f0-9]+(,[a-f0-9]+)+$":
+  "^nand@[a-f0-9]+(,[a-f0-9]+)+$":
     type: object
-    description: |
-      Child device nodes describe the devices connected to IFC such as NOR (e.g.
-      cfi-flash) and NAND (fsl,ifc-nand). There might be board specific devices
-      like FPGAs, CPLDs, etc.
+    properties:
+      compatible:
+        const: fsl,ifc-nand
+
+      reg:
+        maxItems: 1
+
+      "#address-cells":
+        const: 1
+
+      "#size-cells":
+        const: 1
+
+    patternProperties:
+      "^partition@[0-9a-f]+":
+        $ref: /schemas/mtd/partitions/partition.yaml#
+        deprecated: true
 
     required:
       - compatible
       - reg
 
+    additionalProperties: false
+
+  "(flash|fpga|board-control|cpld)@[a-f0-9]+(,[a-f0-9]+)+$":
+    type: object
+    oneOf:
+      - $ref: /schemas/board/fsl,fpga-qixis.yaml#
+      - $ref: /schemas/mtd/mtd-physmap.yaml#
+    unevaluatedProperties: false
+
 required:
   - compatible
   - reg