diff mbox series

[1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency

Message ID 20241015073004.4066457-1-arnd@kernel.org (mailing list archive)
State In Next, archived
Headers show
Series [1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency | expand

Commit Message

Arnd Bergmann Oct. 15, 2024, 7:29 a.m. UTC
From: Arnd Bergmann <arnd@arndb.de>

The driver now uses the legacy bridge helper code but can be configured
to get built without it:

ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!

Add the required dependency, same as in the ldb driver.

Fixes: f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/imx/ipuv3/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Dmitry Baryshkov Oct. 18, 2024, 4:05 p.m. UTC | #1
On Tue, Oct 15, 2024 at 07:29:57AM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The driver now uses the legacy bridge helper code but can be configured
> to get built without it:
> 
> ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!
> 
> Add the required dependency, same as in the ldb driver.
> 
> Fixes: f94b9707a1c9 ("drm/imx: parallel-display: switch to imx_legacy_bridge / drm_bridge_connector")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
>  drivers/gpu/drm/imx/ipuv3/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Robert Foss Oct. 22, 2024, 1:50 p.m. UTC | #2
On Tue, 15 Oct 2024 07:29:57 +0000, Arnd Bergmann wrote:
> The driver now uses the legacy bridge helper code but can be configured
> to get built without it:
> 
> ERROR: modpost: "devm_imx_drm_legacy_bridge" [drivers/gpu/drm/imx/ipuv3/parallel-display.ko] undefined!
> 
> Add the required dependency, same as in the ldb driver.
> 
> [...]

Applied, thanks!

[1/2] drm/imx: parallel-display: add legacy bridge Kconfig dependency
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/ef214002e6b3
[2/2] drm/imx: legacy-bridge: add MODULE_DESCRIPTION
      https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/df606be44c16



Rob
diff mbox series

Patch

diff --git a/drivers/gpu/drm/imx/ipuv3/Kconfig b/drivers/gpu/drm/imx/ipuv3/Kconfig
index 0ea1feb84672..acaf25089001 100644
--- a/drivers/gpu/drm/imx/ipuv3/Kconfig
+++ b/drivers/gpu/drm/imx/ipuv3/Kconfig
@@ -15,6 +15,7 @@  config DRM_IMX_PARALLEL_DISPLAY
 	depends on DRM_IMX
 	select DRM_BRIDGE
 	select DRM_BRIDGE_CONNECTOR
+	select DRM_IMX_LEGACY_BRIDGE
 	select DRM_PANEL_BRIDGE
 	select VIDEOMODE_HELPERS