Message ID | 20241026112452.1523-1-yangyingliang@huaweicloud.com (mailing list archive) |
---|---|
State | In Next |
Headers | show |
Series | clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains() | expand |
On 24-10-26 19:24:52, Yang Yingliang wrote: > From: Yang Yingliang <yangyingliang@huawei.com> > > If device_link_add() fails, it returns NULL pointer not ERR_PTR(), > replace IS_ERR() with NULL pointer check, and return -EINVAL. > > Fixes: d3a0946d7ac9 ("clk: imx: imx8: add audio clock mux driver") > Signed-off-by: Yang Yingliang <yangyingliang@huawei.com> Reviewed-by: Abel Vesa <abel.vesa@linaro.org> > --- > drivers/clk/imx/clk-imx8-acm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c > index 6c351050b82a..c169fe53a35f 100644 > --- a/drivers/clk/imx/clk-imx8-acm.c > +++ b/drivers/clk/imx/clk-imx8-acm.c > @@ -294,9 +294,9 @@ static int clk_imx_acm_attach_pm_domains(struct device *dev, > DL_FLAG_STATELESS | > DL_FLAG_PM_RUNTIME | > DL_FLAG_RPM_ACTIVE); > - if (IS_ERR(dev_pm->pd_dev_link[i])) { > + if (!dev_pm->pd_dev_link[i]) { > dev_pm_domain_detach(dev_pm->pd_dev[i], false); > - ret = PTR_ERR(dev_pm->pd_dev_link[i]); > + ret = -EINVAL; > goto detach_pm; > } > } > -- > 2.33.0 >
On Sat, 26 Oct 2024 19:24:52 +0800, Yang Yingliang wrote: > If device_link_add() fails, it returns NULL pointer not ERR_PTR(), > replace IS_ERR() with NULL pointer check, and return -EINVAL. > > Applied, thanks! [1/1] clk: imx: imx8-acm: Fix return value check in clk_imx_acm_attach_pm_domains() commit: 81a206d736c19139d3863b79e7174f9e98b45499 Best regards,
diff --git a/drivers/clk/imx/clk-imx8-acm.c b/drivers/clk/imx/clk-imx8-acm.c index 6c351050b82a..c169fe53a35f 100644 --- a/drivers/clk/imx/clk-imx8-acm.c +++ b/drivers/clk/imx/clk-imx8-acm.c @@ -294,9 +294,9 @@ static int clk_imx_acm_attach_pm_domains(struct device *dev, DL_FLAG_STATELESS | DL_FLAG_PM_RUNTIME | DL_FLAG_RPM_ACTIVE); - if (IS_ERR(dev_pm->pd_dev_link[i])) { + if (!dev_pm->pd_dev_link[i]) { dev_pm_domain_detach(dev_pm->pd_dev[i], false); - ret = PTR_ERR(dev_pm->pd_dev_link[i]); + ret = -EINVAL; goto detach_pm; } }