diff mbox series

drm/imx/dcss: include drm/drm_bridge.h header

Message ID 20241028163527.2425783-1-arnd@kernel.org (mailing list archive)
State New
Headers show
Series drm/imx/dcss: include drm/drm_bridge.h header | expand

Commit Message

Arnd Bergmann Oct. 28, 2024, 4:35 p.m. UTC 
From: Arnd Bergmann <arnd@arndb.de>

Compile-testing random configurations leads to failures in
dcss-kms.c from a missing declaration:

drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
   95 |         ret = drm_bridge_attach(encoder, bridge, NULL,
      |               ^
drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
   96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
      |                                 ^

Include the header directly.

Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
 1 file changed, 1 insertion(+)

Comments

Laurentiu Palcu Nov. 4, 2024, 12:10 p.m. UTC | #1 
Hi Arnd,

On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> Compile-testing random configurations leads to failures in
> dcss-kms.c from a missing declaration:
> 
> drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
>    95 |         ret = drm_bridge_attach(encoder, bridge, NULL,
>       |               ^
> drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
>    96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
>       |                                 ^
> 
> Include the header directly.
> 
> Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>

Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or
Ville, can you help push this?

Thanks,
Laurentiu

> ---
>  drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> index 3ec721afc30c..63a335c62296 100644
> --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> @@ -5,6 +5,7 @@
>  
>  #include <drm/drm_atomic.h>
>  #include <drm/drm_atomic_helper.h>
> +#include <drm/drm_bridge.h>
>  #include <drm/drm_bridge_connector.h>
>  #include <drm/drm_client_setup.h>
>  #include <drm/drm_drv.h>
> -- 
> 2.39.5
>
Dmitry Baryshkov Nov. 4, 2024, 12:24 p.m. UTC | #2 
On Mon, Nov 04, 2024 at 02:10:54PM +0200, Laurentiu Palcu wrote:
> Hi Arnd,
> 
> On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
> > From: Arnd Bergmann <arnd@arndb.de>
> > 
> > Compile-testing random configurations leads to failures in
> > dcss-kms.c from a missing declaration:
> > 
> > drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
> >    95 |         ret = drm_bridge_attach(encoder, bridge, NULL,
> >       |               ^
> > drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'
> >    96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
> >       |                                 ^
> > 
> > Include the header directly.
> > 
> > Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
> > Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Reviewed-by: Laurentiu Palcu <laurentiu.palcu@oss.nxp.com>
> 
> Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or
> Ville, can you help push this?

I can pick it up.

However I think it is:

Fixes: e7033bdfd43b ("drm/imx/dcss: use drm_bridge_connector API")

With that

Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>


> 
> Thanks,
> Laurentiu
> 
> > ---
> >  drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > index 3ec721afc30c..63a335c62296 100644
> > --- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > +++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
> > @@ -5,6 +5,7 @@
> >  
> >  #include <drm/drm_atomic.h>
> >  #include <drm/drm_atomic_helper.h>
> > +#include <drm/drm_bridge.h>
> >  #include <drm/drm_bridge_connector.h>
> >  #include <drm/drm_client_setup.h>
> >  #include <drm/drm_drv.h>
> > -- 
> > 2.39.5
> >
Arnd Bergmann Nov. 4, 2024, 12:42 p.m. UTC | #3 
On Mon, Nov 4, 2024, at 13:24, Dmitry Baryshkov wrote:
> On Mon, Nov 04, 2024 at 02:10:54PM +0200, Laurentiu Palcu wrote:
>> On Mon, Oct 28, 2024 at 04:35:07PM +0000, Arnd Bergmann wrote:
>>> Fixes: 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
>>
> I can pick it up.
>
> However I think it is:
>
> Fixes: e7033bdfd43b ("drm/imx/dcss: use drm_bridge_connector API")

It's probably both commits. My randconfig builds showed it only
failing on x86, which means that it was still working by
accident on all builds that include ARCH_MXC && ARM64, between
the two commits. The commit you pointed out should have added
the #include, but that seems to come indirectly from
include/drm/drm_of on all arm64 builds.

> With that
>
> Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>

Thanks,

      Arnd
diff mbox series

Patch

diff --git a/drivers/gpu/drm/imx/dcss/dcss-kms.c b/drivers/gpu/drm/imx/dcss/dcss-kms.c
index 3ec721afc30c..63a335c62296 100644
--- a/drivers/gpu/drm/imx/dcss/dcss-kms.c
+++ b/drivers/gpu/drm/imx/dcss/dcss-kms.c
@@ -5,6 +5,7 @@ 
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_client_setup.h>
 #include <drm/drm_drv.h>