From patchwork Fri Nov 8 19:43:28 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Frank Li X-Patchwork-Id: 13868876 Received: from EUR03-DBA-obe.outbound.protection.outlook.com (mail-dbaeur03on2073.outbound.protection.outlook.com [40.107.104.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6348D1C1F11 for ; Fri, 8 Nov 2024 19:43:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.104.73 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731095034; cv=fail; b=XrK+QjDAnk5Hc+IIFu2N5/oD3y9GczCh97Lnj9chP+qIN2Rwqj0i3EWLXVoxZRWP0t2SpBhC83FWBh7Mwfvh0SnJHUCmeB5LQUF3JknKnz/6sY9IX/4NFm9GioXCuhku1PjkCL1UJJMf3xhqvQ61GqTfyWocMd2LIC3Niz2iDGI= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731095034; c=relaxed/simple; bh=WztdJXCK+bOn8jeGvfQAh0AF4COBEh+c0a1xNE6MdUc=; h=From:Date:Subject:Content-Type:Message-Id:References:In-Reply-To: To:Cc:MIME-Version; b=V2R+Zz/P/nV9Njww7RN2EDaO/XF7zz8STFAloFmDhRiF+CCYy4qFRMpawb9/0oiPMXhmFczdl7a3tppBp0+YV2N+Qx9Ug6EiOAHpbpdJR8F6RWEhluPCizacBhkF5ZfAxRWXGlgkKitWL/vMZw1h/ZX5a/bQsCU8z1iIaQFM+rU= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=j5J5RoFi; arc=fail smtp.client-ip=40.107.104.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="j5J5RoFi" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=N1lQs/34QqmHGoYvbZK/tIVd63FRX4AP5vZAaUNgaWu4jRcVdzWmYQCJPgQnULvJzve5dNdxGiFF2zqMeFw8tPigftbmrIDYEZ2VyoJsd4A14M0XbgDzzwxoqNrMsYkND7mwPiNqw5CDC0PGlBXAS9Ss8fEMf1Nz4ad01kQQPcMXEr4xV/4Y2o7aDjemWu6lmz8jz4BTG6SYRHwbSQm4qN71YActgMpAAbzZPz1mvKOzpsuceD+u3U7zgRs4b0MyL0R+qSJqV5puXH3Xeam5XhLBrpkbm55yFuj5UvKhrVSPPaaKro2sQDdOjSTtxrhDoRuLCzq6ZP/bjTEHl18cZg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Oan0nT460bnBSfdOKCXlsarwBLEOZ6HSByQIFZo5Sn4=; b=gVNoHuklKIZ8upS71l/vXyZR69j4OCFQrDnlTE3Do8BvkF3sLFj7gnpdI/UPwJKRDWiXzdHGr3JC3dlcX9bbkJfvVW8w/eQC8lopZCJe3SNMGdfzHUFRTy0kFT4ZzECkXqgiMXwiVebjrdB64inncbkpY6UezbTyrYVkcT8Qt9xbFw3vIkNUkAYpOuMqxlpZhxJjP/1YWzLkpyQPppa+miPe39dFzZzMXKAqaI1//cnsf+shtLh+Hd+8eBTxpI4AmK8v/YTGa/lZi0FGTtKCwauaOmor0hRzGF01NX7cr23SGCBfwGkVSzk1UG1m/ZO3eF+LdYhR1ggD41zMGqwOog== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Oan0nT460bnBSfdOKCXlsarwBLEOZ6HSByQIFZo5Sn4=; b=j5J5RoFi/khEthsDtWlfpefI210zhUETGEerKIh55cavdS9OkZL8zIxr6rLsWm0ySpItPStK4u9MOWhypmhwLLTBVsHMqDTkpJl9dd1AZlp/LA+oQvlnNyI5F9iPSgAk77VJqDz6Rj9YlqKwaERpZx7WAxxfdsGtmpFnAr0pdg4kRta27U+RYEj7yjA0t30ix/cl/PucVR4VlGYrnkK1gDbK51WY0wBn4Ury9h3IPoyzVl2meSHLA4B59LSG4gpSBG0FCI7YQnbPos9azNKARKJMq3nhA5aCVmBTpDE2LtItNQPXEz9Vba8U32pGrUj62EwRWNUVqch6HKwdmEUhoA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) by PAXPR04MB8669.eurprd04.prod.outlook.com (2603:10a6:102:21c::8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8137.21; Fri, 8 Nov 2024 19:43:49 +0000 Received: from PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06]) by PAXPR04MB9642.eurprd04.prod.outlook.com ([fe80::9126:a61e:341d:4b06%4]) with mapi id 15.20.8137.021; Fri, 8 Nov 2024 19:43:49 +0000 From: Frank Li Date: Fri, 08 Nov 2024 14:43:28 -0500 Subject: [PATCH v5 1/5] PCI: endpoint: Add pci_epc_get_fn() API for customizable filtering Message-Id: <20241108-ep-msi-v5-1-a14951c0d007@nxp.com> References: <20241108-ep-msi-v5-0-a14951c0d007@nxp.com> In-Reply-To: <20241108-ep-msi-v5-0-a14951c0d007@nxp.com> To: Manivannan Sadhasivam , =?utf-8?q?Krzy?= =?utf-8?q?sztof_Wilczy=C5=84ski?= , Kishon Vijay Abraham I , Bjorn Helgaas , Arnd Bergmann , Greg Kroah-Hartman Cc: linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, imx@lists.linux.dev, Niklas Cassel , dlemoal@kernel.org, maz@kernel.org, tglx@linutronix.de, jdmason@kudzu.us, Frank Li X-Mailer: b4 0.13-dev-e586c X-Developer-Signature: v=1; a=ed25519-sha256; t=1731095022; l=3101; i=Frank.Li@nxp.com; s=20240130; h=from:subject:message-id; bh=WztdJXCK+bOn8jeGvfQAh0AF4COBEh+c0a1xNE6MdUc=; b=WzIrwA/pzq6FFZORMOHmhUyIAxZ/vFNUiz53+QK8oEmX6EA51zP1387OhPP6QBwimkhPeoaJT zFiTsNr8URlDDwYKP1gZMlrVSwKWIcfVnPlwpU1HMmAtL0rHmmF3Uzm X-Developer-Key: i=Frank.Li@nxp.com; a=ed25519; pk=I0L1sDUfPxpAkRvPKy7MdauTuSENRq+DnA+G4qcS94Q= X-ClientProxiedBy: BY1P220CA0026.NAMP220.PROD.OUTLOOK.COM (2603:10b6:a03:5c3::17) To PAXPR04MB9642.eurprd04.prod.outlook.com (2603:10a6:102:240::14) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB9642:EE_|PAXPR04MB8669:EE_ X-MS-Office365-Filtering-Correlation-Id: 1e3dea47-3e97-4c6c-65a0-08dd002daaba X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|376014|52116014|7416014|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?KasQ00Q1bp5ztHrP9zEGVnRFsOLpZyi?= =?utf-8?q?PfIk9f3/XjdGMCNdAzZjRVH0x33LMNorUTFxzMhWxIQuKXAB+EAApjrvRmbJXG3nV?= =?utf-8?q?1pW6W69muPZsMmXEmsiTqrMjJIwwgGOI/Frq+1OWH5wmxw8NbsJBq2l50ASOldidP?= =?utf-8?q?WsWMu0/ZAgVuKAz0/YFe2pB205WHXSCeR1SDzp5B9waXjauAQKGf+wjMjNYCBjb4J?= =?utf-8?q?kW+kbqPMLSIOS7gTUkChqNYehlwF2wddQ0je8qCsydMTDOkW0fiWyGGM+zn/MqmPb?= =?utf-8?q?zMyFQODqjM/U63cKEX7ZwsTmS2qEeI/9rls8BNeSR/q96RlGN0cWVHqLO9NqvDF0U?= =?utf-8?q?uhcQiKky5aa5dgosWW8dbCMqQ/saGJ9LnK8Nk/hwKtQucPR4wSwxrN1HKUWr0GQEY?= =?utf-8?q?v+UgPvfTnYiJMYucvD2i0082bLHfQeO1RULdxEqhpnBXmhRRp2xrIl6y5rp6Yg16w?= =?utf-8?q?CV9492MWnmDSFLxkpHo2wGujrJOLvBZ0Fg8+YaLIGT2Vbnc2qtY2+xmmBuETfY3kN?= =?utf-8?q?Tk4VpgLRcSZKfrktp2ScU5UvkD/LCgM9djsXwflgfTFaXxCChAvtLPNwJll5ctBuv?= =?utf-8?q?WBK0MlztoboXyjr5aV6KEme7hHEHFvDUwdI9PeobS69WEuTnGhgEnk2AU0I2GHfor?= =?utf-8?q?N5bnVrGsjOP7wRtsCtPsWLNJdfN2aIz8h//gbdjHTyTZ2IMnZMX5it+gRKXcP9DY5?= =?utf-8?q?ySIzZ559i/iBjPQ6O1JC+Hc/rnvHojYwf8ypZXu5vIGIWelTxFH0bMlZesD3Yo0WZ?= =?utf-8?q?AQdgQwEZnEljdFtE53MWRPpA7cR0HeweC/VSgpT0vzLeV4uATh0k1XGuyH5iaySym?= =?utf-8?q?v3nr+c93TAeEHXmWeMC78tiebhW2WeXXCETgLq1AJltocjYhvuNqORHgREvrKBhWn?= =?utf-8?q?XDB3ZzNJaUgss6Vtq6E/w80qI7YUf8acyVnVJvt/NPWiBSJpaF2fozlVxqVdOJ7iP?= =?utf-8?q?U/sDlqNmXjf/49Ub2V9PQSErRLuq3sCCvda51TYFk4VZHZZHJ1j+weqea2VWMrOZi?= =?utf-8?q?d4suL7Ma/pnTdbfA2JM3WdtgbnMZuXWm4gRhd8cK22CwGapLS5LS4ObxhaA0R6VOZ?= =?utf-8?q?V0JGhDzpGjw/XlPZ9wfAA8U2DFuJB+nVmDoBD7Ns4vZzjIGuI3JwHPBL0/EyAayW1?= =?utf-8?q?CjQ+OFXzDoSW9BSXSiCkzS988DzqBSR/XQMBihOocGtFkpUr/TdzxD4OFHSoetxWj?= =?utf-8?q?l9jPWAKM6p8ecbcnGHXFte7q6C3vWTLW/j5af0Tnu+wd8ALaHoxspskMkbLivA7lJ?= =?utf-8?q?O1btlvK7PepdMMjf3IQppvV0z+yIMorYpEeZ5uIj3Ip7r/NmX2RGC6VU=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB9642.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(376014)(52116014)(7416014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?vValyPjlEw5VCDveuShf1ozHPzYJ?= =?utf-8?q?Ip/LkSeibSQ0livpekZsrQW8f+WXcZgqaapYE8+b3YCVg4MQf1QyEm2xkB66RNPH0?= =?utf-8?q?CvwBJzMfJRjko32ZGTjkr+qnrCC7iB0kHPrD4gI90IMqcWLKCaTnDQIhnvlIQ7bQU?= =?utf-8?q?/nSsr2F33iM4Srdj7ikxuNvno08DMMZn8+qEdd8i0a3UeKZQFsiZCrxg1nqBt00+T?= =?utf-8?q?vfq7jxchbIIX+Dp6U1O8gdfKeU5pV288xsMCJKD2Pt5TSYr1ZPHGTLyhuJ6va5UsQ?= =?utf-8?q?lhlEzP9/F0t996P5T9UdDbVkXX85UykqKHSIxPTU+YP0Kgr1Ep6gHEAjm4L6Mf7wV?= =?utf-8?q?HpujD1NK8DkX6QnZl/+ccnAKZN278STMYwe8hitbCUvEWwmW/PgZSRd/SXIji8Avh?= =?utf-8?q?/GGKC4hSkFSSvcY1CrLSA1+pjRQxOk4jfMvsDk++NJKjcjRmJo/2K7seqSUUjiPkK?= =?utf-8?q?oNa20B9u3OjVMtxDqeaTJcyZmpsIgncOnzxxywsfFRIrEXNwjSPqMHJvRhPsq3irQ?= =?utf-8?q?FBco0NH4S7F9RhLPM1Qi6MYskI/JhvJmGiLlVCyrQMvp9RkuZNigd/ut0e3nmb9Wf?= =?utf-8?q?Zljwaf8u5M8ELmaFyzriNXr0TTBTs7gluQ/SjPBu0G15it1mTrKTI7v0LopLiFky4?= =?utf-8?q?gzu6neVOiMdHrKjUOvaQxSVY7iieIqwPebX5g/LWfqqlPSRGQuDntjdZp2M18bbJ0?= =?utf-8?q?B7PNK1BJ4j1+q7DFjL7snUDkmAY7eYtXjwRz6qdoPuHK0RTkk68mOD3uMgsk/uezL?= =?utf-8?q?2UGMMLM+760vBpUqD5fHsXJxULlO5az0AN18PlULeKAcJ1LzKhFr/gsUoZMYEWYaX?= =?utf-8?q?fiJgnZEAkE19CuXm8OBW4y3TMrjeqd/0kRiYV0PKCzRx6YWP4u1Y4MSWX/GGAQZgV?= =?utf-8?q?WLLWYKarQfIa+UodiFOf+Dtx3soLXE5Yanyd8irBt9J5iwrSsEsgWYbITJWF4YsOs?= =?utf-8?q?mRh6tEwK+noE8m2MQ1PUlT6yoKEyJB5VQEypVhetJjI7yth+/MY66nWERhlrr3rUK?= =?utf-8?q?c2tQQ33+iPw+FguWyO9RsqilDV2hjGoFvurnp1HdHVPjItRa/iZqVRJtE3I2RIuwb?= =?utf-8?q?tomDyhepJVnIAdZnIaH+UgT/pidBnku5MjsEe58h+6hCuu3tH7mgS0OkDSJeNLHwR?= =?utf-8?q?jO2YY+XcpqImEneWcyBHkIxUUlBtNsnOxium9KoFtv9mbSuqfSdcHObd4dr/df4GA?= =?utf-8?q?CzlSdk6FZw8+WPivj4HrYxbTGCqk0nnd6SxJcJIqEbh5RysFB7BxiELddNnnr1wYl?= =?utf-8?q?ybzMVjTQi71pEMXeyOWtWR0094uusixRsKtwkHYDQDh5E81avsNgB+5IoSuDWsXsj?= =?utf-8?q?ER6Gq3zMwvkhOk7ZQgO7Aqw/JpNegJCewjMnNeRTiFuOHaLFUCESoDw0NhK5F81Hd?= =?utf-8?q?GJALjhr8zJPKAwQbd8eOrwumKdyjML90zzmp2rMNXzzdZJJ0gPocrhQk+xiJXrJ/I?= =?utf-8?q?AI89asRAK9CDLtWYJFaGv7e9HqpJxZssJLDh0sscN51jBI7g5E+zlfY8pEW2GfvXv?= =?utf-8?q?fD/cCn9O6dsP?= X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1e3dea47-3e97-4c6c-65a0-08dd002daaba X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB9642.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Nov 2024 19:43:49.5333 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: 0BTpAVaYxm2sEosB8PeI2Lv7NtDyfSrRv//Ftm+Mioc/l5ovr/3akshbjmpk8OMiacRwf7/MGL+Kw2Xmv2TykQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8669 Introduce the pci_epc_get_fn() API, allowing a custom filter callback function to be passed. Reimplement pci_epc_get() using pci_epc_get_fn() with a match name callback. Prepare the codebase for adding RC-to-EP doorbell support. Add DEFINE_FREE(pci_epc_put) to implement scope based auto cleanup. Signed-off-by: Frank Li --- change from v3 to v4 - none --- drivers/pci/endpoint/pci-epc-core.c | 23 +++++++++++++++++++++-- include/linux/pci-epc.h | 2 ++ 2 files changed, 23 insertions(+), 2 deletions(-) diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c index 17f0071092550..14e6011df4b2c 100644 --- a/drivers/pci/endpoint/pci-epc-core.c +++ b/drivers/pci/endpoint/pci-epc-core.c @@ -48,6 +48,11 @@ void pci_epc_put(struct pci_epc *epc) } EXPORT_SYMBOL_GPL(pci_epc_put); +static bool pci_epc_match_name(struct device *dev, void *name) +{ + return strcmp(dev_name(dev), name) == 0; +} + /** * pci_epc_get() - get the PCI endpoint controller * @epc_name: device name of the endpoint controller @@ -56,6 +61,20 @@ EXPORT_SYMBOL_GPL(pci_epc_put); * endpoint controller */ struct pci_epc *pci_epc_get(const char *epc_name) +{ + return pci_epc_get_fn(pci_epc_match_name, (void *)epc_name); +} +EXPORT_SYMBOL_GPL(pci_epc_get); + +/** + * pci_epc_get_fn() - get the PCI endpoint controller + * @fn: callback match filter function, return true when matched + * @param: parameter for callback function fn + * + * Invoke to get struct pci_epc * corresponding to the device name of the + * endpoint controller + */ +struct pci_epc *pci_epc_get_fn(bool (*fn)(struct device *dev, void *param), void *param) { int ret = -EINVAL; struct pci_epc *epc; @@ -64,7 +83,7 @@ struct pci_epc *pci_epc_get(const char *epc_name) class_dev_iter_init(&iter, &pci_epc_class, NULL, NULL); while ((dev = class_dev_iter_next(&iter))) { - if (strcmp(epc_name, dev_name(dev))) + if (!fn(dev, param)) continue; epc = to_pci_epc(dev); @@ -82,7 +101,7 @@ struct pci_epc *pci_epc_get(const char *epc_name) class_dev_iter_exit(&iter); return ERR_PTR(ret); } -EXPORT_SYMBOL_GPL(pci_epc_get); +EXPORT_SYMBOL_GPL(pci_epc_get_fn); /** * pci_epc_get_first_free_bar() - helper to get first unreserved BAR diff --git a/include/linux/pci-epc.h b/include/linux/pci-epc.h index 42ef06136bd1a..682808f4510be 100644 --- a/include/linux/pci-epc.h +++ b/include/linux/pci-epc.h @@ -266,7 +266,9 @@ pci_epc_get_first_free_bar(const struct pci_epc_features *epc_features); enum pci_barno pci_epc_get_next_free_bar(const struct pci_epc_features *epc_features, enum pci_barno bar); struct pci_epc *pci_epc_get(const char *epc_name); +struct pci_epc *pci_epc_get_fn(bool (*fn)(struct device *dev, void *param), void *param); void pci_epc_put(struct pci_epc *epc); +DEFINE_FREE(pci_epc_put, void *, if (!(_T)) pci_epc_put(_T)) int pci_epc_mem_init(struct pci_epc *epc, phys_addr_t base, size_t size, size_t page_size);