| Message ID | 20241108100759.682260-4-shengjiu.wang@nxp.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | clk: imx93: Add IMX93_CLK_SPDIF_IPG clock | expand |
> Subject: [PATCH v2 3/3] arm64: dts: imx93: Use IMX93_CLK_SPDIF_IPG > as SPDIF IPG clock > This patch has a fix tag, but the other two not have. So the other two will not be backported and cause issue. So use fixes for all or drop fixes for all. Regards, Peng. > IMX93_CLK_BUS_WAKEUP is not accurate IPG clock, which missed the > clock gate part. > > IMX93_CLK_SPDIF_IPG is the correct clock. > > Fixes: 1c4a4f7362fd ("arm64: dts: imx93: Add audio device nodes") > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > b/arch/arm64/boot/dts/freescale/imx93.dtsi > index 688488de8cd2..56766fdb0b1e 100644 > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > @@ -925,7 +925,7 @@ xcvr: xcvr@42680000 { > reg-names = "ram", "regs", "rxfifo", > "txfifo"; > interrupts = <GIC_SPI 203 > IRQ_TYPE_LEVEL_HIGH>, > <GIC_SPI 204 > IRQ_TYPE_LEVEL_HIGH>; > - clocks = <&clk > IMX93_CLK_BUS_WAKEUP>, > + clocks = <&clk > IMX93_CLK_SPDIF_IPG>, > <&clk > IMX93_CLK_SPDIF_GATE>, > <&clk IMX93_CLK_DUMMY>, > <&clk > IMX93_CLK_AUD_XCVR_GATE>; > -- > 2.34.1
On Mon, Nov 11, 2024 at 11:11 AM Peng Fan <peng.fan@nxp.com> wrote: > > > Subject: [PATCH v2 3/3] arm64: dts: imx93: Use IMX93_CLK_SPDIF_IPG > > as SPDIF IPG clock > > > > This patch has a fix tag, but the other two not have. So the other two > will not be backported and cause issue. > > So use fixes for all or drop fixes for all. > Should I add the one same fixes tag to all 3 commits? Best regards Shengjiu Wang > Regards, > Peng. > > > IMX93_CLK_BUS_WAKEUP is not accurate IPG clock, which missed the > > clock gate part. > > > > IMX93_CLK_SPDIF_IPG is the correct clock. > > > > Fixes: 1c4a4f7362fd ("arm64: dts: imx93: Add audio device nodes") > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > Reviewed-by: Frank Li <Frank.Li@nxp.com> > > --- > > arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > > b/arch/arm64/boot/dts/freescale/imx93.dtsi > > index 688488de8cd2..56766fdb0b1e 100644 > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > @@ -925,7 +925,7 @@ xcvr: xcvr@42680000 { > > reg-names = "ram", "regs", "rxfifo", > > "txfifo"; > > interrupts = <GIC_SPI 203 > > IRQ_TYPE_LEVEL_HIGH>, > > <GIC_SPI 204 > > IRQ_TYPE_LEVEL_HIGH>; > > - clocks = <&clk > > IMX93_CLK_BUS_WAKEUP>, > > + clocks = <&clk > > IMX93_CLK_SPDIF_IPG>, > > <&clk > > IMX93_CLK_SPDIF_GATE>, > > <&clk IMX93_CLK_DUMMY>, > > <&clk > > IMX93_CLK_AUD_XCVR_GATE>; > > -- > > 2.34.1 >
> Subject: Re: [PATCH v2 3/3] arm64: dts: imx93: Use > IMX93_CLK_SPDIF_IPG as SPDIF IPG clock > > On Mon, Nov 11, 2024 at 11:11 AM Peng Fan <peng.fan@nxp.com> > wrote: > > > > > Subject: [PATCH v2 3/3] arm64: dts: imx93: Use > IMX93_CLK_SPDIF_IPG > > > as SPDIF IPG clock > > > > > > > This patch has a fix tag, but the other two not have. So the other two > > will not be backported and cause issue. > > > > So use fixes for all or drop fixes for all. > > > > Should I add the one same fixes tag to all 3 commits? It should be fine to use same fixes tag, I think. Regards, Peng. > > Best regards > Shengjiu Wang > > > Regards, > > Peng. > > > > > IMX93_CLK_BUS_WAKEUP is not accurate IPG clock, which missed > the > > > clock gate part. > > > > > > IMX93_CLK_SPDIF_IPG is the correct clock. > > > > > > Fixes: 1c4a4f7362fd ("arm64: dts: imx93: Add audio device nodes") > > > Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> > > > Reviewed-by: Frank Li <Frank.Li@nxp.com> > > > --- > > > arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi > > > b/arch/arm64/boot/dts/freescale/imx93.dtsi > > > index 688488de8cd2..56766fdb0b1e 100644 > > > --- a/arch/arm64/boot/dts/freescale/imx93.dtsi > > > +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi > > > @@ -925,7 +925,7 @@ xcvr: xcvr@42680000 { > > > reg-names = "ram", "regs", "rxfifo", > > > "txfifo"; > > > interrupts = <GIC_SPI 203 > > > IRQ_TYPE_LEVEL_HIGH>, > > > <GIC_SPI 204 > > > IRQ_TYPE_LEVEL_HIGH>; > > > - clocks = <&clk > > > IMX93_CLK_BUS_WAKEUP>, > > > + clocks = <&clk > > > IMX93_CLK_SPDIF_IPG>, > > > <&clk IMX93_CLK_SPDIF_GATE>, > > > <&clk IMX93_CLK_DUMMY>, > > > <&clk > > > IMX93_CLK_AUD_XCVR_GATE>; > > > -- > > > 2.34.1 > >
diff --git a/arch/arm64/boot/dts/freescale/imx93.dtsi b/arch/arm64/boot/dts/freescale/imx93.dtsi index 688488de8cd2..56766fdb0b1e 100644 --- a/arch/arm64/boot/dts/freescale/imx93.dtsi +++ b/arch/arm64/boot/dts/freescale/imx93.dtsi @@ -925,7 +925,7 @@ xcvr: xcvr@42680000 { reg-names = "ram", "regs", "rxfifo", "txfifo"; interrupts = <GIC_SPI 203 IRQ_TYPE_LEVEL_HIGH>, <GIC_SPI 204 IRQ_TYPE_LEVEL_HIGH>; - clocks = <&clk IMX93_CLK_BUS_WAKEUP>, + clocks = <&clk IMX93_CLK_SPDIF_IPG>, <&clk IMX93_CLK_SPDIF_GATE>, <&clk IMX93_CLK_DUMMY>, <&clk IMX93_CLK_AUD_XCVR_GATE>;
IMX93_CLK_BUS_WAKEUP is not accurate IPG clock, which missed the clock gate part. IMX93_CLK_SPDIF_IPG is the correct clock. Fixes: 1c4a4f7362fd ("arm64: dts: imx93: Add audio device nodes") Signed-off-by: Shengjiu Wang <shengjiu.wang@nxp.com> Reviewed-by: Frank Li <Frank.Li@nxp.com> --- arch/arm64/boot/dts/freescale/imx93.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)