| Message ID | 20241203110054.2506123-2-andrej.picej@norik.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | SN65DSI83/4 lvds_vod_swing properties | expand |
On Tue, Dec 03, 2024 at 12:00:52PM +0100, Andrej Picej wrote: > Add properties which can be used to specify LVDS differential output > voltage. Since this also depends on near-end signal termination also > include property which sets this. LVDS differential output voltage is > specified with an array (min, max), which should match the one from > connected device. > > Signed-off-by: Andrej Picej <andrej.picej@norik.com> > --- > Changes in v3: > - no change One version of patchset per 24h. > Changes in v2: > - move LVDS port schema to a $defs and reference it from there > - properties are now defined in microvolts/ohms > - use 1 property for data-lane and 1 for clock-lane LVDS voltage swing > - add 1 property which sets LVDS near-end termination > - since major change was done change the authorship to myself > --- > .../bindings/display/bridge/ti,sn65dsi83.yaml | 36 +++++++++++++++++-- > 1 file changed, 33 insertions(+), 3 deletions(-) ... > allOf: > - if: > properties: > @@ -120,7 +150,7 @@ allOf: > properties: > port@1: false > > -additionalProperties: false > +additionalProperties: true This cannot be true. Not explained in commit msg and this is not shared schema. > > examples: > - | > -- > 2.34.1 >
Hi Krzysztof, On 4. 12. 24 08:54, Krzysztof Kozlowski wrote: > On Tue, Dec 03, 2024 at 12:00:52PM +0100, Andrej Picej wrote: >> Add properties which can be used to specify LVDS differential output >> voltage. Since this also depends on near-end signal termination also >> include property which sets this. LVDS differential output voltage is >> specified with an array (min, max), which should match the one from >> connected device. >> >> Signed-off-by: Andrej Picej <andrej.picej@norik.com> >> --- >> Changes in v3: >> - no change > > > One version of patchset per 24h. understood. > >> Changes in v2: >> - move LVDS port schema to a $defs and reference it from there >> - properties are now defined in microvolts/ohms >> - use 1 property for data-lane and 1 for clock-lane LVDS voltage swing >> - add 1 property which sets LVDS near-end termination >> - since major change was done change the authorship to myself >> --- >> .../bindings/display/bridge/ti,sn65dsi83.yaml | 36 +++++++++++++++++-- >> 1 file changed, 33 insertions(+), 3 deletions(-) > > ... > >> allOf: >> - if: >> properties: >> @@ -120,7 +150,7 @@ allOf: >> properties: >> port@1: false >> >> -additionalProperties: false >> +additionalProperties: true > > This cannot be true. Not explained in commit msg and this is not shared > schema. You are right. Will remove it in next iteration. Best regards, Andrej > >> >> examples: >> - | >> -- >> 2.34.1 >>
diff --git a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml index 48a97bb3e2e0..6da9b6e3beb9 100644 --- a/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml +++ b/Documentation/devicetree/bindings/display/bridge/ti,sn65dsi83.yaml @@ -80,12 +80,12 @@ properties: - const: 4 port@2: - $ref: /schemas/graph.yaml#/properties/port description: Video port for LVDS Channel-A output (panel or bridge). + $ref: '#/$defs/lvds-port' port@3: - $ref: /schemas/graph.yaml#/properties/port description: Video port for LVDS Channel-B output (panel or bridge). + $ref: '#/$defs/lvds-port' required: - port@0 @@ -96,6 +96,36 @@ required: - reg - ports +$defs: + lvds-port: + $ref: /schemas/graph.yaml#/$defs/port-base + unevaluatedProperties: false + + properties: + endpoint: + $ref: /schemas/media/video-interfaces.yaml# + unevaluatedProperties: false + + properties: + ti,lvds-termination-ohms: + description: The value of near end differential termination in ohms. + enum: [100, 200] + default: 200 + + ti,lvds-vod-swing-clock-microvolt: + description: LVDS diferential output voltage <min max> for clock + lanes in microvolts. + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 2 + maxItems: 2 + + ti,lvds-vod-swing-data-microvolt: + description: LVDS diferential output voltage <min max> for data + lanes in microvolts. + $ref: /schemas/types.yaml#/definitions/uint32-array + minItems: 2 + maxItems: 2 + allOf: - if: properties: @@ -120,7 +150,7 @@ allOf: properties: port@1: false -additionalProperties: false +additionalProperties: true examples: - |
Add properties which can be used to specify LVDS differential output voltage. Since this also depends on near-end signal termination also include property which sets this. LVDS differential output voltage is specified with an array (min, max), which should match the one from connected device. Signed-off-by: Andrej Picej <andrej.picej@norik.com> --- Changes in v3: - no change Changes in v2: - move LVDS port schema to a $defs and reference it from there - properties are now defined in microvolts/ohms - use 1 property for data-lane and 1 for clock-lane LVDS voltage swing - add 1 property which sets LVDS near-end termination - since major change was done change the authorship to myself --- .../bindings/display/bridge/ti,sn65dsi83.yaml | 36 +++++++++++++++++-- 1 file changed, 33 insertions(+), 3 deletions(-)