From patchwork Tue Dec 10 11:27:12 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bough Chen X-Patchwork-Id: 13901341 Received: from EUR03-AM7-obe.outbound.protection.outlook.com (mail-am7eur03on2049.outbound.protection.outlook.com [40.107.105.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C5F292080DE for ; Tue, 10 Dec 2024 11:28:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.105.49 ARC-Seal: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733830109; cv=fail; b=T5z0x/jc3cAA3sEIvwujZJEhkJFzXViZf6jqqgCoC2qC4BYTJJdOK3Y/+GUHQ+lPqADGz8q851F0m73DBB9VhU3Fxazxnpszu5bHTDd4fjon7qgdp2LpmE/+v24rYN8mCAC4xGf094+4ac+woDMh49QE+huAG7t946Zk7qvzoGY= ARC-Message-Signature: i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733830109; c=relaxed/simple; bh=oEflPgDNFo6QWeqYEMMyOfF8TftqRAp/58UIe9VrR+I=; h=From:To:Cc:Subject:Date:Message-Id:Content-Type:MIME-Version; b=ckvQmacSykRilXtVfi6vQuaD+wnbB72qkUE+C7pSLA738QzmCqqPe1mkP8Nn88Z84jqgWRJo3HLOyYWn8cy9JzX4Qdei4jc6FxBwaHuPHvDaJltQmuu9bt2G2lp5o9bRQRdXxA1dDMwHMKl3iwjCBdDTmiF82PZxKYzZxa/JTEA= ARC-Authentication-Results: i=2; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com; spf=pass smtp.mailfrom=nxp.com; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b=R3YiOxzu; arc=fail smtp.client-ip=40.107.105.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=nxp.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=nxp.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=nxp.com header.i=@nxp.com header.b="R3YiOxzu" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Z/wnqVgcxatHyEYl3wn+e2Z0FYyqmZ3e8ehW7BxXxqxuQlcfsQGd3/E7nQ/jbNhpTWq8RRNpmyezRnTfL0ejdKsNwc6XOMzfdQzAZV9Xmcm0MP++B8CLSVUS8zhCfCpPbcoj4tJkeTsOhdS4nKtWASfHTUQm7Hi2uczxitt1cP4yMEhnG3ZLWg2e2wk5gXuCfCPDEuR/yX11M+OCB4dMK2lONBYnKuXhFZJpN1wjJR5K7IhBt2TQaT0ftp0DZVodYgP/iI6cSk8HFSybbuDY1OzSK1FnmbfYpbH/nWR+16gL1LKsHjNKLEV32p0+Bp4diqVAmp+i2kcqKUhnEjS8+A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=RPG8a5D19tiOViJ6A4p259Hlf2GhDvtSUoJzOLyTPn0=; b=prF4/+Pn5BBbxVB+Xw4pVgAky4A0fAU/5uJHJszrf5L2wuf9BwrnXkmK95S3+7GzFqggCkSKr4pSfeZ2vSyPVFPf+jW8ttgv24e0f/+LHgbEmld+0728zdfpTfqHkT9mjsengAmPU8OzSsymwKYgIyr14lLFLX2P67e6a1BYr88XaMZnrSfeS0oP0X3FPsjW+y+FQ4PILr6+AinQS5ELAd7AD+7fNrO4eklq4HyX4zVnlcEuizD/l6tbvymWPwPI0ig3MToN8rEQLmDGtAMEAvCeddkZmLOSWD+02gzkjkXF4on/GM+Fh1vWVbJfKOAvQfTfDJNDpKn9rbg1x0gvZw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nxp.com; dmarc=pass action=none header.from=nxp.com; dkim=pass header.d=nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=RPG8a5D19tiOViJ6A4p259Hlf2GhDvtSUoJzOLyTPn0=; b=R3YiOxzuBVcE/zZXumbXJZkw8JPtorezzUiMtqZH3Cm26Mdcj6JhvZ70qQ2GVtBlxiUOuSDgnl69w9+Et62HY8YEF70P0KGeku4rwySLaX7tiMVyYyvseW6xccO8dlUmMtuYpzHoErPicjkIpIlNql8NjqLBNeE/gBi9Cc8n/RkSsRjDAMLNLWmxaNsmuebdpgSaGd/O46darE30swm5Q5Cm3xQqH7unokVaXU5H0tPqdBhvBjTZUlVjACyccJFu/bJLjmj6rJHY4nrCHQJotvQAyHocV/EbkJHaNGmdttDw4urZVwFfXa8ETMMhPw1tROplOJKTjD26luwffF8OUw== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nxp.com; Received: from DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) by PA4PR04MB7935.eurprd04.prod.outlook.com (2603:10a6:102:b8::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8230.20; Tue, 10 Dec 2024 11:28:24 +0000 Received: from DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334]) by DU0PR04MB9496.eurprd04.prod.outlook.com ([fe80::4fa3:7420:14ed:5334%6]) with mapi id 15.20.8230.010; Tue, 10 Dec 2024 11:28:24 +0000 From: haibo.chen@nxp.com To: broonie@kernel.org, bbrezillon@kernel.org, frieder.schrempf@exceet.de Cc: linux-spi@vger.kernel.org, linux-kernel@vger.kernel.org, imx@lists.linux.dev, han.xu@nxp.com, chengminglin@mxic.com.tw, stable@vger.kernel.org, haibo.chen@nxp.com, jason.hui.liu@nxp.com Subject: [PATCH] spi: spi-mem: check the dummy buswidth only for rx mode Date: Tue, 10 Dec 2024 19:27:12 +0800 Message-Id: <20241210112712.483893-1-haibo.chen@nxp.com> X-Mailer: git-send-email 2.34.1 X-ClientProxiedBy: SI2PR01CA0032.apcprd01.prod.exchangelabs.com (2603:1096:4:192::18) To DU0PR04MB9496.eurprd04.prod.outlook.com (2603:10a6:10:32d::19) Precedence: bulk X-Mailing-List: imx@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DU0PR04MB9496:EE_|PA4PR04MB7935:EE_ X-MS-Office365-Filtering-Correlation-Id: 916ef4b5-1810-4e6b-e43b-08dd190dc205 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|1800799024|366016|52116014|376014|38350700014; X-Microsoft-Antispam-Message-Info: FMizqfeZSLof4j4PHMIHTAnHWye/CdpnLSj1vlFItEGUrVxDU2+OfX4lD2Xxj4Oslvvq1CvtXh+tEKT44KEyymojv7FVz2IYwWkRY4T3Qhpy3KBbetwvdG9Urzp41kE4JXT0qGNuw1R4Za2EIW1oOofp82Cuvm9S89zqteatMx2xMkgf0spAvqwsQeBcLyeWx1RFjiSmLpUIuXw1bLtuWbkGIGsem/UYk+ZIfDKcjiFVb7op1Z4N43jNbz8aOy79IPk+H8DtH0IjC9MtMm355rj9pWyP9IXSpj2h3dHU6TKJ7QnJTVwpD/xBxjf8W68myfbDIbhOuVzrJqYzgmfV3q6Dr0stwwaf3Hh/LiRyK/vOBfFiYOeWvMnXDj1BwtFumAVD52kjsuofDW8Iqc89wsjHNiGcuwBUB4n3/k71aOHkh4G0mi2aCypZSlPj8VP2vX9JoHtkkighCW+1PnYn/3nUQ6jgnAjNhRRqqaJMRCjHTsRmi10lLcHyJCfxh2n77RV7/BcmnP7OBwYoKnZ0oUSPe0Hc5d/daEYyLdsRpabdVAcsCLCRgbVEdXoOs6ErhtrhpLUUph4qbrujiG/52iITPC6RpyS1FnTN16xJD9MP/mOGwKy9vIXt/SSQMflja1+V04G1rSaUVQ4PlmK71KnDiu9fKLsbz32Zo4ZHvEuMgGlSQdFQ+rcWSNWBmW/dV5LhF/BsdkR8FTI5TubBwqgjQCZAA/E3mMx4PnC7eOnOQySH8I8zMKBf2U+uL5/PBztqEk70Zs3xCk59rWHKZmKS3hGi2Awt6ngWP91nQ4cGb1yK7VDIZfrko1XM+ouDMadawxm78W0e1tfVxLI9uuuTH5un9Hv4VCXMdEd+ZTqeXLOreMIZPOoFr9FEStOgyOqwkXfdcuw/iKHsZ0KSZfnnR95An7j+q8hIw5Rod1S+iwv2DvmnLt7CAkDsDDoa6a9mj220mkTupX9UCpATOAESQ8DADxW09UE0MKEhusap7BwkZlv5LImXDmMOh7X6ZUiCr++xw6kazh43cTYFkDvOjGI4SyWzEZ2otEyDw3JcmJhkLYDazFALa11efe8KuqieGAY5N+Pul4aBNROZUIUYlMgSkRTflaEkIwHOuzkphteYlkmxribpw0LEwvF59NkZec5X/td2tBb5nNyXxt8VALeAitHSBxtF8VzXZFsmc3H+gx3BG/q4AigzrvJaORP9SZqDRxyAPjZ28fYppbclq1hieoevDzTvcIiaJDqCBje2gIW38S65MEPmqacJcF6fWI5qXsA81SWF9Q4ZkJaXtYn8npwPWI11Txdl8j+f0Hl4qe/xK9azE54OpnKaMSni/fe0u7ldBI2ZFC183ESkXRHqTqA5Bs8KLVI3v/lZt3c90IiKbwGXWGeeh44BuLZynFFi0mbaYz3aDs9TqQ== X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DU0PR04MB9496.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(1800799024)(366016)(52116014)(376014)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: tClDLe8V9I8EQJtg1gQKaC46G5nogxMwsHvLocQqurQxJU3AAzT1kQ5vlu6FGer+rPS+7y3uD1dImfPdRvW/YV+P+uXHMiEP7b8AAJ8rLvPluQQxOQb4fhjq05ce08k+yQfh7rH48e23BfA3Xur88LPsZQK+rLKP1I8kLINgtksh88L+kJ823zTxCGWKjXGBrPWPIwwCL8YGGKKgYwpCB4xNudnJ7tTPzBIg07hk/QLJ0EMXQSVn6XmOmW8sculccY7V0LT1hPBSXg0U8PNHczY2+ADNpAhj0VxzN9mBJjGx9unfBk4ptD9hjzqM9RXlWHuG4n1HQ0XcdgSFf6gjdJjxCGTffxXEBsQVPZ4lDNP1MIlwO4NDRpDGn33dfMRBeLfM3Ppjx6DVSps2/SENfS7K3fB9Rx5d9u7Dw2uJAp17SPGXZP6Z7JY/addNBXd0MJvigSmeyhohVjR2jJalW9lsRNFRQm9mmM5QwhcC+g/2hvf2TavL+WYL9dTuvgIRIXK4JjBV8Ci+DETgenGGGCesz/Ktnvik9ed5c955/VG6Wyeg5USVkB722SVAP7JmRDFz6Co/wb3KaZEoRIeaDvjl51ZcnCKvqsfOEhXyRBCyOQ2XGtljBQDJY6sdbpgIDQO2Latqoq74QGLFbZzt04SoazieX67l7snbSTT5tWFoZ1lZPpOGfryQ6WOZFXiUug+VYir2hSwiscdjSjhNFBlwLoALVuCx0KGSocFFueNloTfqMaLxeE9P1s4dR1k3LpbDbm1aHinR40EzaiREttu6OpdC7UgesuhYtaPf1y82JybIdoJLKRV7ezaPrMGcFWIYsiFeciobb3WlgbBIBzkWmO0KAIlk7s6vj9YNqH+zHWgfW3/7GsNtxo0Kz7rQvznjYB0nm4pczSm4iKBzysq7h+HM74IB3ZuhO16m+TaOKWSr8mXdwORZ8b91AZMQY2OcaUQVfGAJwcAvTRmWj9cUE9qoGS31pdylAbxN8FW3ycRIqVD4+mQhYKwiSICc6vTLyH1dD9e5jwCPQ9tChsdQAzzlKK78OPb8EJh9JOidD23ArmKYbAOKG/nn4ngRC/WmXmLuRY1Rwc40IFtpdsOvB5pP+vhyFlIqZzsB7gItVTOlUX6amGt41T0P5ePCPmoIzsWnE8N6y8+luY1dyzjdQ/L0fBWwMoBp6CsIAmhL1rGLrl2a3TNE2pH3CfhzbS+40Bwm2eBz1kTy+aEB+W41cLFP2z6tg9EdvIrzAitvBmF/vPl9FKI8yN9mj+vpyhvwN3YY1FCx1XYfXxzaHngcC2z2Zmzp2mqjP0lXBPbyMd+xLOYPAOEtySPu8UUrNfYAnUn8EJbZdZoZrFvF+1AufT3LQErPc+XeeImjBf13fTpPXAIvoRAI/ckTghMCJ5XnJBny9gjmzCFywTSiSp2WP0sMtY4LQz3Ga5WA9rbD7+jDtdKYIsAD7vLM7elq/uMtckl0mlLLSlmRoeIblnPLiQ1lfqpVz1A0dN5VNzuQyY9ASb9kaGHlY3aCy3oaWM4j3Tpwht+rNk75sRYxvEGMqoqulUh+/rKMLV3xIhiaYhbd/oEkQ0swL5mM46cX X-OriginatorOrg: nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 916ef4b5-1810-4e6b-e43b-08dd190dc205 X-MS-Exchange-CrossTenant-AuthSource: DU0PR04MB9496.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Dec 2024 11:28:23.9377 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: wQmHEjaf9JOj6nXO6EgUVuVwe5O7hOjlDM5dQnnibyLT37lkNU/cAYdwzWVHeLcPXOD0HjKSpDRyrvAAcFoKBg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PA4PR04MB7935 From: Haibo Chen Dummy usually used for rx, so combine the dummy buswidth check only for rx mode. Find issue after commit 98d1fb94ce75 ("mtd: spi-nor: core: replace dummy buswidth from addr to data") on imx8mn-ddr4-evk board. On this board, rx=4, tx=1, without the upper commit, chose SNOR_CMD_READ_1_1_4, after this commit, chose SNOR_CMD_READ(1_1_1). This is because when dummy buswidth = 4, spi_check_buswidth_req(mem, op->dummy.buswidth, true) do not return the expected result. Combine the cmd.buswidth and addr.buswidth check to tx is reasonable, but for dummy buswidth, need to check the rx mode. Fixes: c36ff266dc82 ("spi: Extend the core to ease integration of SPI memory controllers") Cc: stable@vger.kernel.org Signed-off-by: Haibo Chen --- drivers/spi/spi-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c index abc6792e738c..bc9f09a9e5a0 100644 --- a/drivers/spi/spi-mem.c +++ b/drivers/spi/spi-mem.c @@ -150,7 +150,7 @@ static bool spi_mem_check_buswidth(struct spi_mem *mem, return false; if (op->dummy.nbytes && - spi_check_buswidth_req(mem, op->dummy.buswidth, true)) + spi_check_buswidth_req(mem, op->dummy.buswidth, false)) return false; if (op->data.dir != SPI_MEM_NO_DATA &&