diff mbox series

[v12,2/5] dt-bindings: arm: fsl: add imx-se-fw binding doc

Message ID 20250120-imx-se-if-v12-2-c5ec9754570c@nxp.com (mailing list archive)
State New
Headers show
Series Changes in v12: | expand

Commit Message

Pankaj Gupta Jan. 20, 2025, 4:52 p.m. UTC 
The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc.,
creates an embedded secure enclave within the SoC boundary to enable
features like:
- HSM
- SHE
- V2X

Secure-Enclave(s) communication interface are typically via message
unit, i.e., based on mailbox linux kernel driver. This driver enables
communication ensuring well defined message sequence protocol between
Application Core and enclave's firmware.

Driver configures multiple misc-device on the MU, for multiple
user-space applications, to be able to communicate over single MU.

It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.

Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
Reviewed-by: Conor Dooley <conor@kernel.org>
---
 .../devicetree/bindings/firmware/fsl,imx-se.yaml   | 91 ++++++++++++++++++++++
 1 file changed, 91 insertions(+)

Comments

Krzysztof Kozlowski Jan. 20, 2025, 12:16 p.m. UTC | #1 
On 20/01/2025 17:52, Pankaj Gupta wrote:
> The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc.,
> creates an embedded secure enclave within the SoC boundary to enable
> features like:
> - HSM
> - SHE
> - V2X
> 
> Secure-Enclave(s) communication interface are typically via message
> unit, i.e., based on mailbox linux kernel driver. This driver enables
> communication ensuring well defined message sequence protocol between
> Application Core and enclave's firmware.
> 
> Driver configures multiple misc-device on the MU, for multiple
> user-space applications, to be able to communicate over single MU.
> 
> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> 
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: Conor Dooley <conor@kernel.org>

Where Conor's review tag was actually given?

I don't see any hints in the changelog.

Best regards,
Krzysztof
Pankaj Gupta Jan. 20, 2025, 1:07 p.m. UTC | #2 
-----Original Message-----
From: Krzysztof Kozlowski <krzk@kernel.org>
Sent: Monday, January 20, 2025 5:47 PM
To: Pankaj Gupta <pankaj.gupta@nxp.com>; Jonathan Corbet <corbet@lwn.net>; Rob 
Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor 
Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer 
<s.hauer@pengutronix.de>; Pengutronix Kernel Team <kernel@pengutronix.de>; 
Fabio Estevam <festevam@gmail.com>
Cc: linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; 
devicetree@vger.kernel.org; imx@lists.linux.dev; 
linux-arm-kernel@lists.infradead.org; Conor Dooley <conor@kernel.org>
Subject: [EXT] Re: [PATCH v12 2/5] dt-bindings: arm: fsl: add imx-se-fw 
binding doc

Caution: This is an external email. Please take care when clicking links or 
opening attachments. When in doubt, report the message using the 'Report this 
email' button


On 20/01/2025 17:52, Pankaj Gupta wrote:
> The NXP security hardware IP(s) like: i.MX EdgeLock Enclave, V2X etc.,
> creates an embedded secure enclave within the SoC boundary to enable
> features like:
> - HSM
> - SHE
> - V2X
>
> Secure-Enclave(s) communication interface are typically via message
> unit, i.e., based on mailbox linux kernel driver. This driver enables
> communication ensuring well defined message sequence protocol between
> Application Core and enclave's firmware.
>
> Driver configures multiple misc-device on the MU, for multiple
> user-space applications, to be able to communicate over single MU.
>
> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
>
> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> Reviewed-by: Conor Dooley <conor@kernel.org>

> Where Conor's review tag was actually given?
On v6.

> I don't see any hints in the changelog.
Accepted. Will update it in the change log, under v6.


> Best regards,
> Krzysztof
Krzysztof Kozlowski Jan. 20, 2025, 3:01 p.m. UTC | #3 
On 20/01/2025 14:07, Pankaj Gupta wrote:
>> Driver configures multiple misc-device on the MU, for multiple
>> user-space applications, to be able to communicate over single MU.
>>
>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
>>
>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>> Reviewed-by: Conor Dooley <conor@kernel.org>
> 
>> Where Conor's review tag was actually given?
> On v6.

I already looked there. No trace for tag. Please point to the message.

Best regards,
Krzysztof
Krzysztof Kozlowski Jan. 22, 2025, 10:35 a.m. UTC | #4 
On 20/01/2025 16:01, Krzysztof Kozlowski wrote:
> On 20/01/2025 14:07, Pankaj Gupta wrote:
>>> Driver configures multiple misc-device on the MU, for multiple
>>> user-space applications, to be able to communicate over single MU.
>>>
>>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
>>>
>>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
>>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
>>> Reviewed-by: Conor Dooley <conor@kernel.org>
>>
>>> Where Conor's review tag was actually given?
>> On v6.
> 
> I already looked there. No trace for tag. Please point to the message.


Still no answer from you, except that evading answer, so let's be clear:
don't create fake tags.

Clean your patchset from all fake tags and keep only the ones which were
real.

Best regards,
Krzysztof
Krzysztof Kozlowski Jan. 22, 2025, 10:37 a.m. UTC | #5 
On 20/01/2025 14:07, Pankaj Gupta wrote:
> 
> 
> -----Original Message-----
> From: Krzysztof Kozlowski <krzk@kernel.org>
> Sent: Monday, January 20, 2025 5:47 PM
> To: Pankaj Gupta <pankaj.gupta@nxp.com>; Jonathan Corbet <corbet@lwn.net>; Rob 
> Herring <robh@kernel.org>; Krzysztof Kozlowski <krzk+dt@kernel.org>; Conor 
> Dooley <conor+dt@kernel.org>; Shawn Guo <shawnguo@kernel.org>; Sascha Hauer 
> <s.hauer@pengutronix.de>; Pengutronix Kernel Team <kernel@pengutronix.de>; 
> Fabio Estevam <festevam@gmail.com>
> Cc: linux-doc@vger.kernel.org; linux-kernel@vger.kernel.org; 
> devicetree@vger.kernel.org; imx@lists.linux.dev; 
> linux-arm-kernel@lists.infradead.org; Conor Dooley <conor@kernel.org>
> Subject: [EXT] Re: [PATCH v12 2/5] dt-bindings: arm: fsl: add imx-se-fw 
> binding doc
> 
> Caution: This is an external email. Please take care when clicking links or 
> opening attachments. When in doubt, report the message using the 'Report this 
> email' button


How did you resolve below comment:

"And please actually read the comments I have left
on every mail about your mail client being broken. I don't want to see
20 lines of to and cc lists on every response :(
"

That's was v6 or v5, half a year ago, and still you keep doing exactly
the same.

Notice how reviewers get annoyed over time...

Best regards,
Krzysztof
Conor Dooley Jan. 22, 2025, 6:26 p.m. UTC | #6 
On Wed, Jan 22, 2025 at 11:35:50AM +0100, Krzysztof Kozlowski wrote:
> On 20/01/2025 16:01, Krzysztof Kozlowski wrote:
> > On 20/01/2025 14:07, Pankaj Gupta wrote:
> >>> Driver configures multiple misc-device on the MU, for multiple
> >>> user-space applications, to be able to communicate over single MU.
> >>>
> >>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> >>>
> >>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> >>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> >>> Reviewed-by: Conor Dooley <conor@kernel.org>
> >>
> >>> Where Conor's review tag was actually given?
> >> On v6.
> > 
> > I already looked there. No trace for tag. Please point to the message.
> 
> 
> Still no answer from you, except that evading answer, so let's be clear:
> don't create fake tags.
> 
> Clean your patchset from all fake tags and keep only the ones which were
> real.

Ye, I don't see that R-b given either. My guess is that somehow "go for
it :+1: was interpreted as one, but it certainly was not meant to be
one. Converting that to a tag is definitely not okay. Seems it appeared
in v9 after Rob prompted about /his/ missing review from v8. I never use
my k.org email in tags, so that is an immediate red flag. I think I never
re-opened this thread after seeing that Rob had approved it back in v8,
so I never noticed. Only by chance that I opened in now.

Thanks for spotting it :)
Frank Li Jan. 22, 2025, 7:46 p.m. UTC | #7 
On Wed, Jan 22, 2025 at 06:26:55PM +0000, Conor Dooley wrote:
> On Wed, Jan 22, 2025 at 11:35:50AM +0100, Krzysztof Kozlowski wrote:
> > On 20/01/2025 16:01, Krzysztof Kozlowski wrote:
> > > On 20/01/2025 14:07, Pankaj Gupta wrote:
> > >>> Driver configures multiple misc-device on the MU, for multiple
> > >>> user-space applications, to be able to communicate over single MU.
> > >>>
> > >>> It exists on some i.MX processors. e.g. i.MX8ULP, i.MX93 etc.
> > >>>
> > >>> Signed-off-by: Pankaj Gupta <pankaj.gupta@nxp.com>
> > >>> Reviewed-by: Rob Herring (Arm) <robh@kernel.org>
> > >>> Reviewed-by: Conor Dooley <conor@kernel.org>
> > >>
> > >>> Where Conor's review tag was actually given?
> > >> On v6.
> > >
> > > I already looked there. No trace for tag. Please point to the message.
> >
> >
> > Still no answer from you, except that evading answer, so let's be clear:
> > don't create fake tags.
> >
> > Clean your patchset from all fake tags and keep only the ones which were
> > real.
>
> Ye, I don't see that R-b given either. My guess is that somehow "go for
> it :+1: was interpreted as one, but it certainly was not meant to be
> one. Converting that to a tag is definitely not okay. Seems it appeared
> in v9 after Rob prompted about /his/ missing review from v8. I never use
> my k.org email in tags, so that is an immediate red flag. I think I never
> re-opened this thread after seeing that Rob had approved it back in v8,
> so I never noticed. Only by chance that I opened in now.
>
> Thanks for spotting it :)

Pankaj Gupta:

	Please use 'b4.sh trailers --update' to avoid this problem in
future.

Frank
diff mbox series

Patch

diff --git a/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
new file mode 100644
index 000000000000..0b617f61640f
--- /dev/null
+++ b/Documentation/devicetree/bindings/firmware/fsl,imx-se.yaml
@@ -0,0 +1,91 @@ 
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/firmware/fsl,imx-se.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: NXP i.MX HW Secure Enclave(s) EdgeLock Enclave
+
+maintainers:
+  - Pankaj Gupta <pankaj.gupta@nxp.com>
+
+description: |
+  NXP's SoC may contain one or multiple embedded secure-enclave HW
+  IP(s) like i.MX EdgeLock Enclave, V2X etc. These NXP's HW IP(s)
+  enables features like
+    - Hardware Security Module (HSM),
+    - Security Hardware Extension (SHE), and
+    - Vehicular to Anything (V2X)
+
+  Communication interface to the secure-enclaves(se) is based on the
+  messaging unit(s).
+
+properties:
+  compatible:
+    enum:
+      - fsl,imx8ulp-se
+      - fsl,imx93-se
+      - fsl,imx95-se
+
+  mboxes:
+    items:
+      - description: mailbox phandle to send message to se firmware
+      - description: mailbox phandle to receive message from se firmware
+
+  mbox-names:
+    items:
+      - const: tx
+      - const: rx
+
+  memory-region:
+    maxItems: 1
+
+  sram:
+    maxItems: 1
+
+required:
+  - compatible
+  - mboxes
+  - mbox-names
+
+allOf:
+  # memory-region
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx8ulp-se
+              - fsl,imx93-se
+    then:
+      required:
+        - memory-region
+    else:
+      properties:
+        memory-region: false
+
+  # sram
+  - if:
+      properties:
+        compatible:
+          contains:
+            enum:
+              - fsl,imx8ulp-se
+    then:
+      required:
+        - sram
+
+    else:
+      properties:
+        sram: false
+
+additionalProperties: false
+
+examples:
+  - |
+    secure-enclave {
+      compatible = "fsl,imx95-se";
+      mboxes = <&ele_mu0 0 0>, <&ele_mu0 1 0>;
+      mbox-names = "tx", "rx";
+    };
+...