| Message ID | 20250217165718.74619-2-laurentiumihalcea111@gmail.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | clk: imx8mp: fix parents of AUDIOMIX DSP/OCRAM_A | expand |
On Mon, Feb 17, 2025 at 11:57:15AM -0500, Laurentiu Mihalcea wrote: > From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > > The AUDIOMIX clock provider takes an additional clock: AUDIO_AXI_CLK_ROOT. > > Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > --- > .../devicetree/bindings/clock/imx8mp-audiomix.yaml | 10 ++++++---- > 1 file changed, 6 insertions(+), 4 deletions(-) > > diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > index 6588a17a7d9a..0272c9527037 100644 > --- a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > +++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > @@ -24,8 +24,8 @@ properties: > maxItems: 1 > > clocks: > - minItems: 7 > - maxItems: 7 > + minItems: 8 > + maxItems: 8 Are you sure clock axi is mandatory or optional clock? If it is mandatory, you need update dts also, otherwise, there will many DTB_CHECK warning. If it is optional, minItems should be 7. Please run CEHCK_DTB for arm64/dts/boot/freescale, make sure no new warning added. Frank > > clock-names: > items: > @@ -36,6 +36,7 @@ properties: > - const: sai5 > - const: sai6 > - const: sai7 > + - const: axi > > '#clock-cells': > const: 1 > @@ -72,10 +73,11 @@ examples: > <&clk IMX8MP_CLK_SAI3>, > <&clk IMX8MP_CLK_SAI5>, > <&clk IMX8MP_CLK_SAI6>, > - <&clk IMX8MP_CLK_SAI7>; > + <&clk IMX8MP_CLK_SAI7>, > + <&clk IMX8MP_CLK_AUDIO_AXI_ROOT>; > clock-names = "ahb", > "sai1", "sai2", "sai3", > - "sai5", "sai6", "sai7"; > + "sai5", "sai6", "sai7", "axi"; > power-domains = <&pgc_audio>; > }; > > -- > 2.34.1 >
On Tue, Feb 18, 2025 at 11:05:51AM -0500, Frank Li wrote: > On Mon, Feb 17, 2025 at 11:57:15AM -0500, Laurentiu Mihalcea wrote: > > From: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > > > > The AUDIOMIX clock provider takes an additional clock: AUDIO_AXI_CLK_ROOT. > > > > Signed-off-by: Laurentiu Mihalcea <laurentiu.mihalcea@nxp.com> > > --- > > .../devicetree/bindings/clock/imx8mp-audiomix.yaml | 10 ++++++---- > > 1 file changed, 6 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > > index 6588a17a7d9a..0272c9527037 100644 > > --- a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > > +++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml > > @@ -24,8 +24,8 @@ properties: > > maxItems: 1 > > > > clocks: > > - minItems: 7 > > - maxItems: 7 > > + minItems: 8 > > + maxItems: 8 > > Are you sure clock axi is mandatory or optional clock? > > If it is mandatory, you need update dts also, otherwise, there will many > DTB_CHECK warning. > > If it is optional, minItems should be 7. > > Please run CEHCK_DTB for arm64/dts/boot/freescale, make sure no new warning > added. Sorry, I saw your dts update patch. Please forget my comments. Frank > > Frank > > > > clock-names: > > items: > > @@ -36,6 +36,7 @@ properties: > > - const: sai5 > > - const: sai6 > > - const: sai7 > > + - const: axi > > > > '#clock-cells': > > const: 1 > > @@ -72,10 +73,11 @@ examples: > > <&clk IMX8MP_CLK_SAI3>, > > <&clk IMX8MP_CLK_SAI5>, > > <&clk IMX8MP_CLK_SAI6>, > > - <&clk IMX8MP_CLK_SAI7>; > > + <&clk IMX8MP_CLK_SAI7>, > > + <&clk IMX8MP_CLK_AUDIO_AXI_ROOT>; > > clock-names = "ahb", > > "sai1", "sai2", "sai3", > > - "sai5", "sai6", "sai7"; > > + "sai5", "sai6", "sai7", "axi"; > > power-domains = <&pgc_audio>; > > }; > > > > -- > > 2.34.1 > >
diff --git a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml index 6588a17a7d9a..0272c9527037 100644 --- a/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml +++ b/Documentation/devicetree/bindings/clock/imx8mp-audiomix.yaml @@ -24,8 +24,8 @@ properties: maxItems: 1 clocks: - minItems: 7 - maxItems: 7 + minItems: 8 + maxItems: 8 clock-names: items: @@ -36,6 +36,7 @@ properties: - const: sai5 - const: sai6 - const: sai7 + - const: axi '#clock-cells': const: 1 @@ -72,10 +73,11 @@ examples: <&clk IMX8MP_CLK_SAI3>, <&clk IMX8MP_CLK_SAI5>, <&clk IMX8MP_CLK_SAI6>, - <&clk IMX8MP_CLK_SAI7>; + <&clk IMX8MP_CLK_SAI7>, + <&clk IMX8MP_CLK_AUDIO_AXI_ROOT>; clock-names = "ahb", "sai1", "sai2", "sai3", - "sai5", "sai6", "sai7"; + "sai5", "sai6", "sai7", "axi"; power-domains = <&pgc_audio>; };