| Message ID | 20250218-gpcv2-of-property-present-v1-1-3bb1a9789654@pengutronix.de (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | pmdomain: imx: gpcv2: use proper helper for property detection | expand |
On Tue, 18 Feb 2025 at 20:18, Ahmad Fatoum <a.fatoum@pengutronix.de> wrote: > > Starting with commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() > is used on non-boolean properties"), probing the gpcv2 device on i.MX8M > SoCs leads to warnings when LOCKDEP is enabled. > > Fix this by checking property presence with of_property_present as > intended. > > Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> Applied for next, thanks! Kind regards Uffe > --- > drivers/pmdomain/imx/gpcv2.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/pmdomain/imx/gpcv2.c b/drivers/pmdomain/imx/gpcv2.c > index 958d34d4821b1be68d730ad345037b8f0a56c45a..105fcaf13a34c787b2d568bc64e7fee9bfc23393 100644 > --- a/drivers/pmdomain/imx/gpcv2.c > +++ b/drivers/pmdomain/imx/gpcv2.c > @@ -1361,7 +1361,7 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) > } > > if (IS_ENABLED(CONFIG_LOCKDEP) && > - of_property_read_bool(domain->dev->of_node, "power-domains")) > + of_property_present(domain->dev->of_node, "power-domains")) > lockdep_set_subclass(&domain->genpd.mlock, 1); > > ret = of_genpd_add_provider_simple(domain->dev->of_node, > > --- > base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319 > change-id: 20250218-gpcv2-of-property-present-158f8dbfe2dc > > Best regards, > -- > Ahmad Fatoum <a.fatoum@pengutronix.de> >
diff --git a/drivers/pmdomain/imx/gpcv2.c b/drivers/pmdomain/imx/gpcv2.c index 958d34d4821b1be68d730ad345037b8f0a56c45a..105fcaf13a34c787b2d568bc64e7fee9bfc23393 100644 --- a/drivers/pmdomain/imx/gpcv2.c +++ b/drivers/pmdomain/imx/gpcv2.c @@ -1361,7 +1361,7 @@ static int imx_pgc_domain_probe(struct platform_device *pdev) } if (IS_ENABLED(CONFIG_LOCKDEP) && - of_property_read_bool(domain->dev->of_node, "power-domains")) + of_property_present(domain->dev->of_node, "power-domains")) lockdep_set_subclass(&domain->genpd.mlock, 1); ret = of_genpd_add_provider_simple(domain->dev->of_node,
Starting with commit c141ecc3cecd7 ("of: Warn when of_property_read_bool() is used on non-boolean properties"), probing the gpcv2 device on i.MX8M SoCs leads to warnings when LOCKDEP is enabled. Fix this by checking property presence with of_property_present as intended. Signed-off-by: Ahmad Fatoum <a.fatoum@pengutronix.de> --- drivers/pmdomain/imx/gpcv2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- base-commit: 0ad2507d5d93f39619fc42372c347d6006b64319 change-id: 20250218-gpcv2-of-property-present-158f8dbfe2dc Best regards,