| Message ID | 20250219093104.2589449-3-xu.yang_2@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | add USB2.0 support for i.MX95-19x19 EVK board | expand |
On Wed, Feb 19, 2025 at 05:31:00PM +0800, Xu Yang wrote: > The i.MX95 USB2.0 controller is basically compatible with i.MX7D, > except it needs use hsio block control for wakeup setting. This will > add compatible for i.MX95 platform and restriciton on reg property. Nit: Simple said Add compatible ... Better mention "fsl,imx95-usbmisc" at subject. add compatible string "fsl,imx95-usbmisc" for ... Reviewed-by: Frank Li <Frank.Li@nxp.com> > > Signed-off-by: Xu Yang <xu.yang_2@nxp.com> > --- > .../devicetree/bindings/usb/fsl,usbmisc.yaml | 23 ++++++++++++++++++- > 1 file changed, 22 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > index 0a6e7ac1b37e..019435540df0 100644 > --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml > @@ -34,6 +34,7 @@ properties: > - fsl,imx8mm-usbmisc > - fsl,imx8mn-usbmisc > - fsl,imx8ulp-usbmisc > + - fsl,imx95-usbmisc > - const: fsl,imx7d-usbmisc > - const: fsl,imx6q-usbmisc > - items: > @@ -45,7 +46,10 @@ properties: > maxItems: 1 > > reg: > - maxItems: 1 > + minItems: 1 > + items: > + - description: Base and length of the Wrapper module register > + - description: Base and length of the HSIO Block Control register > > '#index-cells': > const: 1 > @@ -56,6 +60,23 @@ required: > - compatible > - reg > > +allOf: > + # imx95 soc needs use HSIO Block Control > + - if: > + properties: > + compatible: > + contains: > + enum: > + - fsl,imx95-usbmisc > + then: > + properties: > + reg: > + minItems: 2 > + else: > + properties: > + reg: > + maxItems: 1 > + > additionalProperties: false > > examples: > -- > 2.34.1 >
On Wed, Feb 19, 2025 at 01:01:30PM -0500, Frank Li wrote: > On Wed, Feb 19, 2025 at 05:31:00PM +0800, Xu Yang wrote: > > The i.MX95 USB2.0 controller is basically compatible with i.MX7D, > > except it needs use hsio block control for wakeup setting. This will > > add compatible for i.MX95 platform and restriciton on reg property. > > Nit: Simple said > Add compatible ... > > Better mention "fsl,imx95-usbmisc" at subject. > add compatible string "fsl,imx95-usbmisc" for ... Okay. Thanks, Xu Yang > > Reviewed-by: Frank Li <Frank.Li@nxp.com> >
diff --git a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml index 0a6e7ac1b37e..019435540df0 100644 --- a/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml +++ b/Documentation/devicetree/bindings/usb/fsl,usbmisc.yaml @@ -34,6 +34,7 @@ properties: - fsl,imx8mm-usbmisc - fsl,imx8mn-usbmisc - fsl,imx8ulp-usbmisc + - fsl,imx95-usbmisc - const: fsl,imx7d-usbmisc - const: fsl,imx6q-usbmisc - items: @@ -45,7 +46,10 @@ properties: maxItems: 1 reg: - maxItems: 1 + minItems: 1 + items: + - description: Base and length of the Wrapper module register + - description: Base and length of the HSIO Block Control register '#index-cells': const: 1 @@ -56,6 +60,23 @@ required: - compatible - reg +allOf: + # imx95 soc needs use HSIO Block Control + - if: + properties: + compatible: + contains: + enum: + - fsl,imx95-usbmisc + then: + properties: + reg: + minItems: 2 + else: + properties: + reg: + maxItems: 1 + additionalProperties: false examples:
The i.MX95 USB2.0 controller is basically compatible with i.MX7D, except it needs use hsio block control for wakeup setting. This will add compatible for i.MX95 platform and restriciton on reg property. Signed-off-by: Xu Yang <xu.yang_2@nxp.com> --- .../devicetree/bindings/usb/fsl,usbmisc.yaml | 23 ++++++++++++++++++- 1 file changed, 22 insertions(+), 1 deletion(-)