| Message ID | 20250225102005.408773-2-daniel.baluta@nxp.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | imx8mp: Add support to Run/Stall DSP via reset API | expand |
On Di, 2025-02-25 at 12:19 +0200, Daniel Baluta wrote: > Add reset ids used for EARC and DSP on i.MX8MP platform. > > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > Acked-by: Rob Herring (Arm) <robh@kernel.org> > Reviewed-by: Frank Li <Frank.Li@nxp.com> > --- > include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > create mode 100644 include/dt-bindings/reset/imx8mp-reset-audiomix.h > > diff --git a/include/dt-bindings/reset/imx8mp-reset-audiomix.h b/include/dt-bindings/reset/imx8mp-reset-audiomix.h > new file mode 100644 > index 000000000000..3349bf311764 > --- /dev/null > +++ b/include/dt-bindings/reset/imx8mp-reset-audiomix.h > @@ -0,0 +1,13 @@ > +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ > +/* > + * Copyright 2025 NXP > + */ > + > +#ifndef DT_BINDING_RESET_IMX8MP_AUDIOMIX_H > +#define DT_BINDING_RESET_IMX8MP_AUDIOMIX_H > + > +#define IMX8MP_AUDIOMIX_EARC 0 > +#define IMX8MP_AUDIOMIX_EARC_PHY 1 > +#define IMX8MP_AUDIOMIX_DSP 2 How about calling these IMX8MP_AUDIOMIX_EARC_RESET, IMX8MP_AUDIOMIX_EARC_PHY_RESET, and IMX8MP_AUDIOMIX_DSP_STALL instead? regards Philipp
On Tue, Feb 25, 2025 at 3:18 PM Philipp Zabel <p.zabel@pengutronix.de> wrote: > > On Di, 2025-02-25 at 12:19 +0200, Daniel Baluta wrote: > > Add reset ids used for EARC and DSP on i.MX8MP platform. > > > > Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com> > > Acked-by: Rob Herring (Arm) <robh@kernel.org> > > Reviewed-by: Frank Li <Frank.Li@nxp.com> > > --- > > include/dt-bindings/reset/imx8mp-reset-audiomix.h | 13 +++++++++++++ > > 1 file changed, 13 insertions(+) > > create mode 100644 include/dt-bindings/reset/imx8mp-reset-audiomix.h > > > > diff --git a/include/dt-bindings/reset/imx8mp-reset-audiomix.h b/include/dt-bindings/reset/imx8mp-reset-audiomix.h > > new file mode 100644 > > index 000000000000..3349bf311764 > > --- /dev/null > > +++ b/include/dt-bindings/reset/imx8mp-reset-audiomix.h > > @@ -0,0 +1,13 @@ > > +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ > > +/* > > + * Copyright 2025 NXP > > + */ > > + > > +#ifndef DT_BINDING_RESET_IMX8MP_AUDIOMIX_H > > +#define DT_BINDING_RESET_IMX8MP_AUDIOMIX_H > > + > > +#define IMX8MP_AUDIOMIX_EARC 0 > > +#define IMX8MP_AUDIOMIX_EARC_PHY 1 > > +#define IMX8MP_AUDIOMIX_DSP 2 > > How about calling these IMX8MP_AUDIOMIX_EARC_RESET, > IMX8MP_AUDIOMIX_EARC_PHY_RESET, and IMX8MP_AUDIOMIX_DSP_STALL instead? That's fine with me, makes more sense. Will make the change in v4. Will wait for a while for more comments. Thanks Philipp!
diff --git a/include/dt-bindings/reset/imx8mp-reset-audiomix.h b/include/dt-bindings/reset/imx8mp-reset-audiomix.h new file mode 100644 index 000000000000..3349bf311764 --- /dev/null +++ b/include/dt-bindings/reset/imx8mp-reset-audiomix.h @@ -0,0 +1,13 @@ +/* SPDX-License-Identifier: GPL-2.0-only OR MIT */ +/* + * Copyright 2025 NXP + */ + +#ifndef DT_BINDING_RESET_IMX8MP_AUDIOMIX_H +#define DT_BINDING_RESET_IMX8MP_AUDIOMIX_H + +#define IMX8MP_AUDIOMIX_EARC 0 +#define IMX8MP_AUDIOMIX_EARC_PHY 1 +#define IMX8MP_AUDIOMIX_DSP 2 + +#endif /* DT_BINDING_RESET_IMX8MP_AUDIOMIX_H */