diff mbox series

[3/3] arm64: dts: mba8xx: Remove invalid propert

Message ID 20250225102726.654070-4-alexander.stein@ew.tq-group.com (mailing list archive)
State New
Headers show
Series imx8qxp: PCIe fixes | expand

Commit Message

Alexander Stein Feb. 25, 2025, 10:27 a.m. UTC 
disable-gpio is an (old) downstream kernel property, which slipped into
DT. Remove it.

Fixes: c01a26b8897a ("arm64: dts: mba8xx: Add PCIe support")
Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
---
 arch/arm64/boot/dts/freescale/mba8xx.dtsi | 1 -
 1 file changed, 1 deletion(-)

Comments

Frank Li Feb. 25, 2025, 4:13 p.m. UTC | #1 
On Tue, Feb 25, 2025 at 11:27:23AM +0100, Alexander Stein wrote:
> disable-gpio is an (old) downstream kernel property, which slipped into
> DT. Remove it.
>
> Fixes: c01a26b8897a ("arm64: dts: mba8xx: Add PCIe support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---

Reviewed-by: Frank Li <Frank.Li@nxp.com>

>  arch/arm64/boot/dts/freescale/mba8xx.dtsi | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> index 117f657283191..c4b5663949ade 100644
> --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> @@ -328,7 +328,6 @@ &pcieb {
>  	pinctrl-0 = <&pinctrl_pcieb>;
>  	pinctrl-names = "default";
>  	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> -	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
>  	vpcie-supply = <&reg_pcie_1v5>;
>  	status = "okay";
>  };
> --
> 2.43.0
>
Bjorn Helgaas Feb. 25, 2025, 5:47 p.m. UTC | #2 
Subject line could include 'disable-gpio'

And s/propert/property/

On Tue, Feb 25, 2025 at 11:27:23AM +0100, Alexander Stein wrote:
> disable-gpio is an (old) downstream kernel property, which slipped into
> DT. Remove it.

I guess the implication is that the driver has never used this.

> Fixes: c01a26b8897a ("arm64: dts: mba8xx: Add PCIe support")
> Signed-off-by: Alexander Stein <alexander.stein@ew.tq-group.com>
> ---
>  arch/arm64/boot/dts/freescale/mba8xx.dtsi | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> index 117f657283191..c4b5663949ade 100644
> --- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> +++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
> @@ -328,7 +328,6 @@ &pcieb {
>  	pinctrl-0 = <&pinctrl_pcieb>;
>  	pinctrl-names = "default";
>  	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
> -	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
>  	vpcie-supply = <&reg_pcie_1v5>;
>  	status = "okay";
>  };
> -- 
> 2.43.0
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/mba8xx.dtsi b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
index 117f657283191..c4b5663949ade 100644
--- a/arch/arm64/boot/dts/freescale/mba8xx.dtsi
+++ b/arch/arm64/boot/dts/freescale/mba8xx.dtsi
@@ -328,7 +328,6 @@  &pcieb {
 	pinctrl-0 = <&pinctrl_pcieb>;
 	pinctrl-names = "default";
 	reset-gpios = <&lsio_gpio4 0 GPIO_ACTIVE_LOW>;
-	disable-gpio = <&expander 7 GPIO_ACTIVE_LOW>;
 	vpcie-supply = <&reg_pcie_1v5>;
 	status = "okay";
 };