diff mbox series

[2/2] mtd: mchp48l640: Use str_enable_disable() in mchp48l640_write_prepare()

Message ID 20250313095756.945890-2-zhangheng@kylinos.cn (mailing list archive)
State New
Headers show
Series [1/2] mtd: rawnand: gpmi: Use str_enabled_disabled() in gpmi_nand_attach_chip() | expand

Commit Message

Zhang Heng March 13, 2025, 9:57 a.m. UTC 
Remove hard-coded strings by using the str_enable_disable() helper
function.

Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
---
 drivers/mtd/devices/mchp48l640.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

Comments

Heiko Schocher March 13, 2025, 1:50 p.m. UTC | #1 
Hello Zhang,

On 13.03.25 10:57, Zhang Heng wrote:
> Remove hard-coded strings by using the str_enable_disable() helper
> function.
> 
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
> ---
>   drivers/mtd/devices/mchp48l640.c | 9 +++++----
>   1 file changed, 5 insertions(+), 4 deletions(-)

Thanks!

Reviewed-by: Heiko Schocher <hs@denx.de>

bye,
Heiko
diff mbox series

Patch

diff --git a/drivers/mtd/devices/mchp48l640.c b/drivers/mtd/devices/mchp48l640.c
index 7584d0ba9396..4af9208f9690 100644
--- a/drivers/mtd/devices/mchp48l640.c
+++ b/drivers/mtd/devices/mchp48l640.c
@@ -23,6 +23,7 @@ 
 #include <linux/spi/flash.h>
 #include <linux/spi/spi.h>
 #include <linux/of.h>
+#include <linux/string_choices.h>
 
 struct mchp48_caps {
 	unsigned int size;
@@ -128,11 +129,11 @@  static int mchp48l640_write_prepare(struct mchp48l640_flash *flash, bool enable)
 	mutex_unlock(&flash->lock);
 
 	if (ret)
-		dev_err(&flash->spi->dev, "write %sable failed ret: %d",
-			(enable ? "en" : "dis"), ret);
+		dev_err(&flash->spi->dev, "write %s failed ret: %d",
+			str_enable_disable(enable), ret);
 
-	dev_dbg(&flash->spi->dev, "write %sable success ret: %d",
-		(enable ? "en" : "dis"), ret);
+	dev_dbg(&flash->spi->dev, "write %s success ret: %d",
+		str_enable_disable(enable), ret);
 	if (enable)
 		return mchp48l640_waitforbit(flash, MCHP48L640_STATUS_WEL, true);