| Message ID | 9bcf916828934b497ea13d27405105159aef1bff.1724408198.git.bo.wu@vivo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [1/2] bus: imx-weim: support compile test | expand |
On Fri, 23 Aug 2024 04:22:11 -0600 Wu Bo <bo.wu@vivo.com> wrote: > Make the code cleaner and avoid call clk_disable_unprepare() > > Signed-off-by: Wu Bo <bo.wu@vivo.com> > --- > drivers/bus/imx-weim.c | 10 ++-------- > 1 file changed, 2 insertions(+), 8 deletions(-) > > diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c > index 837bf9d51c6e..81483461b514 100644 > --- a/drivers/bus/imx-weim.c > +++ b/drivers/bus/imx-weim.c > @@ -282,19 +282,13 @@ static int weim_probe(struct platform_device *pdev) > dev_set_drvdata(&pdev->dev, priv); > > /* get the clock */ > - clk = devm_clk_get(&pdev->dev, NULL); > + clk = devm_clk_get_enabled(&pdev->dev, NULL); > if (IS_ERR(clk)) > return PTR_ERR(clk); > > - ret = clk_prepare_enable(clk); > - if (ret) > - return ret; > - > /* parse the device node */ > ret = weim_parse_dt(pdev); > - if (ret) if (ret) return ret; dev_info() return 0; > - clk_disable_unprepare(clk); > - else > + if (!ret) > dev_info(&pdev->dev, "Driver registered.\n"); > > return ret;
diff --git a/drivers/bus/imx-weim.c b/drivers/bus/imx-weim.c index 837bf9d51c6e..81483461b514 100644 --- a/drivers/bus/imx-weim.c +++ b/drivers/bus/imx-weim.c @@ -282,19 +282,13 @@ static int weim_probe(struct platform_device *pdev) dev_set_drvdata(&pdev->dev, priv); /* get the clock */ - clk = devm_clk_get(&pdev->dev, NULL); + clk = devm_clk_get_enabled(&pdev->dev, NULL); if (IS_ERR(clk)) return PTR_ERR(clk); - ret = clk_prepare_enable(clk); - if (ret) - return ret; - /* parse the device node */ ret = weim_parse_dt(pdev); - if (ret) - clk_disable_unprepare(clk); - else + if (!ret) dev_info(&pdev->dev, "Driver registered.\n"); return ret;
Make the code cleaner and avoid call clk_disable_unprepare() Signed-off-by: Wu Bo <bo.wu@vivo.com> --- drivers/bus/imx-weim.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-)