diff mbox series

dts: imx8mq-librem5: Don't wake up on volume key press

Message ID fa416916049e85ca159805e8602fa8361d5e6d83.1716202515.git.agx@sigxcpu.org (mailing list archive)
State In Next
Headers show
Series dts: imx8mq-librem5: Don't wake up on volume key press | expand

Commit Message

Guido Günther May 20, 2024, 10:57 a.m. UTC
The only key that should wake up the phone is power button press. This
prevents accidental wakeup due to e.g. pressing the buttons in the
pocket or backpack and is in line what userspace uses to unblank the
device.

Signed-off-by: Guido Günther <agx@sigxcpu.org>
---
 arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
 1 file changed, 2 deletions(-)

Comments

Martin Kepplinger-Novakovic June 10, 2024, 10:17 a.m. UTC | #1
Am Montag, dem 20.05.2024 um 12:57 +0200 schrieb Guido Günther:
> The only key that should wake up the phone is power button press.
> This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

Reviewed-by: Martin Kepplinger <martink@posteo.de>

thank you,

                              martin

> ---
>  arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> index ffb5fe61630d..1b39514d5c12 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
> @@ -45,7 +45,6 @@ key-vol-down {
>                         gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEDOWN>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>  
>                 key-vol-up {
> @@ -53,7 +52,6 @@ key-vol-up {
>                         gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
>                         linux,code = <KEY_VOLUMEUP>;
>                         debounce-interval = <50>;
> -                       wakeup-source;
>                 };
>         };
>
Shawn Guo June 15, 2024, 8:29 a.m. UTC | #2
On Mon, May 20, 2024 at 12:57:05PM +0200, Guido Günther wrote:
> The only key that should wake up the phone is power button press. This
> prevents accidental wakeup due to e.g. pressing the buttons in the
> pocket or backpack and is in line what userspace uses to unblank the
> device.
> 
> Signed-off-by: Guido Günther <agx@sigxcpu.org>

'arm64: dts: ...' for subject prefix.

Fixed it up and applied, thanks!

Shawn
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
index ffb5fe61630d..1b39514d5c12 100644
--- a/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
+++ b/arch/arm64/boot/dts/freescale/imx8mq-librem5.dtsi
@@ -45,7 +45,6 @@  key-vol-down {
 			gpios = <&gpio1 17 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_VOLUMEDOWN>;
 			debounce-interval = <50>;
-			wakeup-source;
 		};
 
 		key-vol-up {
@@ -53,7 +52,6 @@  key-vol-up {
 			gpios = <&gpio1 16 GPIO_ACTIVE_LOW>;
 			linux,code = <KEY_VOLUMEUP>;
 			debounce-interval = <50>;
-			wakeup-source;
 		};
 	};