From patchwork Thu Sep 20 14:33:40 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mika Kuoppala X-Patchwork-Id: 10607833 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 48FC7157B for ; Thu, 20 Sep 2018 14:34:13 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 39DCF2D9C4 for ; Thu, 20 Sep 2018 14:34:13 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2E6CC2D9E1; Thu, 20 Sep 2018 14:34:13 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 3464B2D9C4 for ; Thu, 20 Sep 2018 14:34:12 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5FF756E607; Thu, 20 Sep 2018 14:34:11 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3BEA46E607 for ; Thu, 20 Sep 2018 14:34:10 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Sep 2018 07:34:09 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.53,398,1531810800"; d="scan'208";a="81986773" Received: from rosetta.fi.intel.com ([10.237.72.186]) by FMSMGA003.fm.intel.com with ESMTP; 20 Sep 2018 07:34:09 -0700 Received: by rosetta.fi.intel.com (Postfix, from userid 1000) id F2B5E84084A; Thu, 20 Sep 2018 17:33:51 +0300 (EEST) From: Mika Kuoppala To: intel-gfx@lists.freedesktop.org Date: Thu, 20 Sep 2018 17:33:40 +0300 Message-Id: <20180920143350.29249-1-mika.kuoppala@linux.intel.com> X-Mailer: git-send-email 2.17.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 00/10] ICL interrupt handling improvements X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP Hi, This series brings gen11 interrupt handling closer to what we have with previous gens. Namely the early releasing of master intr to reduce interrupt latency. Also cleanups in guc interrupts and identity selector handling are included. Code size shrinks a little: add/remove: 0/0 grow/shrink: 0/4 up/down: 0/-156 (-156) Function old new delta gen11_irq_postinstall 651 623 -28 gen11_irq_reset 1711 1681 -30 gen11_irq_handler 880 836 -44 gen11_gt_engine_identity 224 170 -54 Total: Before=1281048, After=1280892, chg -0.01% Interrupt handling latency is improved generally as measured with gem_exec_nop, the odd one in the bunch being basic-sequential which suffers almost 11%. The oddity is that the sequential, which is same test with longer timeout, showing 2% improvement. Testname diff-% ------------------------ basic-series -26.051 basic-parallel -24.589 basic-sequent-a 10.729 default -24.738 signal-default -11.749 render -22.221 signal-render -13.250 bsd -16.422 signal-bsd -9.931 blt -22.721 signal-blt -5.241 vebox -22.526 signal-all -4.839 series -2.249 parallel -2.747 sequential -2.137 forked-sequent-i -24.196 forked-sequent-a 2.789 chained-sequen-i -2.351 chained-sequen-a 3.262 context-sequen-i -5.904 context-sequen-a 2.128 preempt-default -3.972 preempt-render 0.503 preempt-bsd -2.355 preempt-blt -1.822 preempt-vebox -2.757 poll-default 0.384 poll-render -0.753 poll-bsd 0.552 poll-blt -0.532 poll-vebox -0.867 poll-sequential 2.865 -Mika Mika Kuoppala (10): drm/i915/icl: No need to ack intr through master control drm/i915/icl: Disable master intr early drm/i915/icl: No need to early bailout on interrupt drm/i915/icl: Add helper to enable/disable master irq drm/i915/icl: Trim down posting reads on master intr control drm/i915/icl: Streamline guc irq handling drm/i915/icl: Make own function for display irq handler drm/i915/icl: Handle GT interrupts after enabling master drm/i915/icl: Handle display interrupts after enabling master drm/i915/icl: Only ack irq identities we did handle drivers/gpu/drm/i915/i915_irq.c | 134 ++++++++++++++++---------------- 1 file changed, 69 insertions(+), 65 deletions(-)