mbox series

[RESEND,v2,0/2] Check MST topology change on resume

Message ID 20181024021925.27026-1-juston.li@intel.com (mailing list archive)
Headers show
Series Check MST topology change on resume | expand

Message

Juston Li Oct. 24, 2018, 2:19 a.m. UTC
Updated and resending these patches from Lyude:
https://lkml.org/lkml/2016/5/19/361
https://lkml.org/lkml/2016/5/19/360

As Lyude explains in patch 1/2, we can't rely on MST hubs to handle
hotplugs during suspend. This patchset will check if any EDID's changed
upon resume and reset the MST connections if they did.

This resolves issues with monitors not being detected when hotplugging them
during suspend.

Signed-off-by: Juston Li <juston.li@intel.com>

Changes since v1:
 - update functions that have been renamed since the original patch
 - add a null check for the cached EDID in case a new device was added
 - checkpatch fixes

Lyude (2):
  drm/dp/mst: Reprobe EDID for MST ports on resume
  drm/i915/mst: Reset MST after resume when necessary

 drivers/gpu/drm/drm_dp_mst_topology.c | 94 ++++++++++++++++++++++++++-
 drivers/gpu/drm/i915/intel_dp.c       |  7 +-
 2 files changed, 99 insertions(+), 2 deletions(-)

Comments

Daniel Vetter Oct. 24, 2018, 8:57 a.m. UTC | #1
On Tue, Oct 23, 2018 at 07:19:23PM -0700, Juston Li wrote:
> Updated and resending these patches from Lyude:
> https://lkml.org/lkml/2016/5/19/361
> https://lkml.org/lkml/2016/5/19/360
> 
> As Lyude explains in patch 1/2, we can't rely on MST hubs to handle
> hotplugs during suspend. This patchset will check if any EDID's changed
> upon resume and reset the MST connections if they did.
> 
> This resolves issues with monitors not being detected when hotplugging them
> during suspend.
> 
> Signed-off-by: Juston Li <juston.li@intel.com>

For formality, does this also imply a reviewed-by tag?

For merging propably best we wait for the backmerge and the push these in
through drm-misc-next-fixes.

Well for drm-misc-next-fixes drm-misc maintainers need to roll the tree
forward. Either way needs synchronization. Plus an ack from drm-intel
maintainers.
-Daniel

> 
> Changes since v1:
>  - update functions that have been renamed since the original patch
>  - add a null check for the cached EDID in case a new device was added
>  - checkpatch fixes
> 
> Lyude (2):
>   drm/dp/mst: Reprobe EDID for MST ports on resume
>   drm/i915/mst: Reset MST after resume when necessary
> 
>  drivers/gpu/drm/drm_dp_mst_topology.c | 94 ++++++++++++++++++++++++++-
>  drivers/gpu/drm/i915/intel_dp.c       |  7 +-
>  2 files changed, 99 insertions(+), 2 deletions(-)
> 
> -- 
> 2.17.2
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Juston Li Oct. 24, 2018, 4:37 p.m. UTC | #2
On Wed, 2018-10-24 at 10:57 +0200, Daniel Vetter wrote:
> On Tue, Oct 23, 2018 at 07:19:23PM -0700, Juston Li wrote:
> > 
> > Signed-off-by: Juston Li <juston.li@intel.com>
> 
> For formality, does this also imply a reviewed-by tag?

I'm quite new to drm so I'll withhold a reviewed-by tag and ask that
someone else take a look at it too.

Lyude, the original author, mentioned he should probably take a look
again also since the patchset is a bit old.

> For merging propably best we wait for the backmerge and the push
> these in
> through drm-misc-next-fixes.
> 
> Well for drm-misc-next-fixes drm-misc maintainers need to roll the
> tree
> forward. Either way needs synchronization. Plus an ack from drm-intel
> maintainers.
> -Daniel
> 

Will do

Thanks
Juston