From patchwork Thu Apr 18 20:53:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Rodrigo Vivi X-Patchwork-Id: 10907981 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 2F71913B5 for ; Thu, 18 Apr 2019 20:53:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1969128D42 for ; Thu, 18 Apr 2019 20:53:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0DD5F28D47; Thu, 18 Apr 2019 20:53:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id B041A28D42 for ; Thu, 18 Apr 2019 20:53:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 4EAF76E1BE; Thu, 18 Apr 2019 20:53:37 +0000 (UTC) X-Original-To: intel-gfx@lists.freedesktop.org Delivered-To: intel-gfx@lists.freedesktop.org Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTPS id 5F61F6E1BC for ; Thu, 18 Apr 2019 20:53:36 +0000 (UTC) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 18 Apr 2019 13:53:35 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.60,367,1549958400"; d="scan'208";a="224736933" Received: from rdvivi-losangeles.jf.intel.com ([10.7.196.65]) by orsmga001.jf.intel.com with ESMTP; 18 Apr 2019 13:53:35 -0700 From: Rodrigo Vivi To: intel-gfx@lists.freedesktop.org Date: Thu, 18 Apr 2019 13:53:39 -0700 Message-Id: <20190418205347.6402-1-rodrigo.vivi@intel.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Subject: [Intel-gfx] [RFC 0/8] Start some re-org around IRQ. X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" X-Virus-Scanned: ClamAV using ClamSMTP When playing with IRQ code here I noticed many IRQ stuff are spreaded all around our code. So I'm starting the organization by consolidating as much as possible on a new intel_irq. So we could use this intel_irq to pass around as argument instead of dev_priv, i915 or uncore. So, besides starting that change we need to continue working towards the conversion of intel_uncore_*(). Another possibilities to exploer after that is to fully split rps and hotplug code out of irq. Latest but not least it may be possible to split gt_irq from de_irq later. But well, for now please give feed back on intel_irq struct idea. Thanks, Rodrigo. Rodrigo Vivi (8): drm/i915: Introduce intel_irq drm/i915: Move IRQ related stuff from intel_rps to the new intel_irq. drm/i915: Move display_irqs_enabled to intel_irq drm/i915: Consolidated iir, imr and ier. drm/i915: Move all irq related masks to intel_irq drm/i915: Prefer passing intel_irq instead of intel_core drm/i915: Start the conversion from passing intel_irq instead of dev_priv/i915 drm/i915: Migrate more gen11 irq functions towards intel_irq and uncore funcs. drivers/gpu/drm/i915/i915_debugfs.c | 8 +- drivers/gpu/drm/i915/i915_drv.c | 6 +- drivers/gpu/drm/i915/i915_drv.h | 39 +- drivers/gpu/drm/i915/i915_irq.c | 642 +++++++++++---------- drivers/gpu/drm/i915/intel_breadcrumbs.c | 8 +- drivers/gpu/drm/i915/intel_display.c | 4 +- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_engine_types.h | 2 +- drivers/gpu/drm/i915/intel_fifo_underrun.c | 30 +- drivers/gpu/drm/i915/intel_hotplug.c | 48 +- drivers/gpu/drm/i915/intel_ringbuffer.c | 16 +- drivers/gpu/drm/i915/intel_runtime_pm.c | 8 +- drivers/gpu/drm/i915/intel_tv.c | 8 +- 13 files changed, 417 insertions(+), 404 deletions(-)