mbox series

[v6,0/3] drm/i915: CTS fixes

Message ID 20190627090116.10847-1-lionel.g.landwerlin@intel.com (mailing list archive)
Headers show
Series drm/i915: CTS fixes | expand

Message

Lionel Landwerlin June 27, 2019, 9:01 a.m. UTC 
Hi,

I realized the register are next to one another, so we can use only
one entry to whitelist the 4 of them.

Cheers,

Lionel Landwerlin (3):
  drm/i915: fix whitelist selftests with readonly registers
  drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT
  drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT

 drivers/gpu/drm/i915/gt/intel_workarounds.c   | 30 ++++++++++++++++++-
 .../gpu/drm/i915/gt/selftest_workarounds.c    |  3 ++
 2 files changed, 32 insertions(+), 1 deletion(-)

--
2.21.0.392.gf8f6787159e

Comments

Lionel Landwerlin June 27, 2019, 11:20 a.m. UTC | #1 
So this time it passes...
Do we have flaky reads of the whitelist?

-Lionel

On 27/06/2019 13:38, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915: CTS fixes (rev6)
> URL   : https://patchwork.freedesktop.org/series/62437/
> State : success
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_6373 -> Patchwork_13451
> ====================================================
>
> Summary
> -------
>
>    **SUCCESS**
>
>    No regressions found.
>
>    External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/
>
> Known issues
> ------------
>
>    Here are the changes found in Patchwork_13451 that come from known issues:
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>    * igt@debugfs_test@read_all_entries:
>      - fi-icl-u3:          [PASS][1] -> [DMESG-WARN][2] ([fdo#107724])
>     [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@debugfs_test@read_all_entries.html
>     [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-icl-u3/igt@debugfs_test@read_all_entries.html
>
>    * igt@gem_ctx_create@basic-files:
>      - fi-cml-u2:          [PASS][3] -> [INCOMPLETE][4] ([fdo#110566])
>     [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-cml-u2/igt@gem_ctx_create@basic-files.html
>     [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-cml-u2/igt@gem_ctx_create@basic-files.html
>
>    * igt@gem_exec_suspend@basic-s3:
>      - fi-cml-u:           [PASS][5] -> [INCOMPLETE][6] ([fdo#110566])
>     [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-cml-u/igt@gem_exec_suspend@basic-s3.html
>     [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-cml-u/igt@gem_exec_suspend@basic-s3.html
>
>    * igt@i915_pm_rpm@basic-pci-d3-state:
>      - fi-kbl-r:           [PASS][7] -> [DMESG-WARN][8] ([fdo#111012])
>     [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html
>     [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-kbl-r/igt@i915_pm_rpm@basic-pci-d3-state.html
>
>    * igt@kms_force_connector_basic@force-connector-state:
>      - fi-ilk-650:         [PASS][9] -> [DMESG-WARN][10] ([fdo#106387])
>     [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-ilk-650/igt@kms_force_connector_basic@force-connector-state.html
>     [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-ilk-650/igt@kms_force_connector_basic@force-connector-state.html
>
>    * igt@kms_frontbuffer_tracking@basic:
>      - fi-hsw-peppy:       [PASS][11] -> [DMESG-WARN][12] ([fdo#102614])
>     [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
>     [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-hsw-peppy/igt@kms_frontbuffer_tracking@basic.html
>
>    * igt@prime_vgem@basic-gtt:
>      - fi-icl-dsi:         [PASS][13] -> [INCOMPLETE][14] ([fdo#107713])
>     [13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@prime_vgem@basic-gtt.html
>     [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-icl-dsi/igt@prime_vgem@basic-gtt.html
>
>    
> #### Possible fixes ####
>
>    * igt@gem_ctx_switch@basic-default:
>      - fi-icl-u2:          [INCOMPLETE][15] ([fdo#107713] / [fdo#108569]) -> [PASS][16]
>     [15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u2/igt@gem_ctx_switch@basic-default.html
>     [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-icl-u2/igt@gem_ctx_switch@basic-default.html
>
>    * igt@gem_flink_basic@flink-lifetime:
>      - fi-icl-u3:          [DMESG-WARN][17] ([fdo#107724]) -> [PASS][18] +1 similar issue
>     [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html
>     [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-icl-u3/igt@gem_flink_basic@flink-lifetime.html
>
>    * igt@gem_mmap@basic-small-bo:
>      - fi-icl-dsi:         [DMESG-WARN][19] ([fdo#106107]) -> [PASS][20]
>     [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-icl-dsi/igt@gem_mmap@basic-small-bo.html
>     [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-icl-dsi/igt@gem_mmap@basic-small-bo.html
>
>    * igt@i915_pm_rpm@module-reload:
>      - fi-skl-6770hq:      [FAIL][21] ([fdo#108511]) -> [PASS][22]
>     [21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6373/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
>     [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/fi-skl-6770hq/igt@i915_pm_rpm@module-reload.html
>
>    
>    [fdo#102614]: https://bugs.freedesktop.org/show_bug.cgi?id=102614
>    [fdo#106107]: https://bugs.freedesktop.org/show_bug.cgi?id=106107
>    [fdo#106387]: https://bugs.freedesktop.org/show_bug.cgi?id=106387
>    [fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
>    [fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
>    [fdo#108511]: https://bugs.freedesktop.org/show_bug.cgi?id=108511
>    [fdo#108569]: https://bugs.freedesktop.org/show_bug.cgi?id=108569
>    [fdo#110566]: https://bugs.freedesktop.org/show_bug.cgi?id=110566
>    [fdo#111012]: https://bugs.freedesktop.org/show_bug.cgi?id=111012
>
>
> Participating hosts (52 -> 44)
> ------------------------------
>
>    Additional (1): fi-skl-gvtdvm
>    Missing    (9): fi-hsw-4770r fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-apl-guc fi-icl-y fi-byt-clapper fi-bdw-samus
>
>
> Build changes
> -------------
>
>    * Linux: CI_DRM_6373 -> Patchwork_13451
>
>    CI_DRM_6373: cc7ffe2a301509ba233652ec17d0f74c18b5c8a9 @ git://anongit.freedesktop.org/gfx-ci/linux
>    IGT_5069: 439a9f5d615f31f03cc3a3a5cbab19367a1af763 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
>    Patchwork_13451: 8230d46384b3f9d9325e5397a833bae675012e60 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> == Kernel 32bit build ==
>
> Warning: Kernel 32bit buildtest failed:
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/build_32bit.log
>
>    CALL    scripts/checksyscalls.sh
>    CALL    scripts/atomic/check-atomics.sh
>    CHK     include/generated/compile.h
> Kernel: arch/x86/boot/bzImage is ready  (#1)
>    Building modules, stage 2.
>    MODPOST 112 modules
> ERROR: "__udivdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: "__divdi3" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> scripts/Makefile.modpost:91: recipe for target '__modpost' failed
> make[1]: *** [__modpost] Error 1
> Makefile:1287: recipe for target 'modules' failed
> make: *** [modules] Error 2
>
>
> == Linux commits ==
>
> 8230d46384b3 drm/i915/icl: whitelist PS_(DEPTH|INVOCATION)_COUNT
> 5ce4bb57b4e1 drm/i915: whitelist PS_(DEPTH|INVOCATION)_COUNT
> 810e2eae3f1b drm/i915: fix whitelist selftests with readonly registers
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13451/
>
Chris Wilson June 27, 2019, 11:54 a.m. UTC | #2 
Quoting Lionel Landwerlin (2019-06-27 12:20:00)
> So this time it passes...
> Do we have flaky reads of the whitelist?

Last time it was pure mmio fails (I thought)... That shouldn't be flaky!
Could just be the magic bonus bit.
-Chris