mbox series

[0/1] Turn on GuC/HuC auto mode again

Message ID 20190818155109.31360-1-michal.wajdeczko@intel.com (mailing list archive)
Headers show
Series Turn on GuC/HuC auto mode again | expand

Message

Michal Wajdeczko Aug. 18, 2019, 3:51 p.m. UTC
In commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
we already enabled GuC/HuC auto-mode, however due to holes in our
test coverage we missed to check scenario when GuC firmware is not
present on the target filesystem.

Unfortunatelly such case was fatal to our driver and we decided to
keep GuC disabled in commit 92508da7e3da ("Revert "drm/i915/guc:
Turn on GuC/HuC auto mode"").

Since then we improved both our driver and test coverage and we now
believe that driver works fine without GuC/HuC firmwares available.
See [1] Without HuC firmware and [2] Without GuC/HuC firmwares.

[1] https://patchwork.freedesktop.org/series/65378/#rev1
[2] https://patchwork.freedesktop.org/series/65379/#rev1

References: commit f774f0964919 ("drm/i915/guc: Turn on GuC/HuC auto mode")
References: commit 92508da7e3da ("Revert "drm/i915/guc: Turn on GuC/HuC auto mode"")

Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>
Cc: Jani Nikula <jani.nikula@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Cc: Chris Wilson <chris@chris-wilson.co.uk>
Cc: Tvrtko Ursulin <tvrtko.ursulin@intel.com>
Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio@intel.com> 

Michal Wajdeczko (1):
  drm/i915/uc: Turn on GuC/HuC auto mode again

 drivers/gpu/drm/i915/i915_params.c | 2 +-
 drivers/gpu/drm/i915/i915_params.h | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)