| Message ID | 20191212190230.188505-1-sean@poorly.run (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Add support for HDCP 1.4 over MST connectors | expand |
On Thu, Dec 12, 2019 at 4:34 PM Patchwork <patchwork@emeril.freedesktop.org> wrote: > > == Series Details == > > Series: drm/i915: Add support for HDCP 1.4 over MST connectors (rev2) > URL : https://patchwork.freedesktop.org/series/70393/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7553 -> Patchwork_15728 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_15728 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_15728, please notify your bug team to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/index.html > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_15728: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@gem_close_race@basic-threads: > - fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-byt-j1900/igt@gem_close_race@basic-threads.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-byt-j1900/igt@gem_close_race@basic-threads.html > - fi-byt-n2820: [PASS][3] -> [TIMEOUT][4] > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-byt-n2820/igt@gem_close_race@basic-threads.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-byt-n2820/igt@gem_close_race@basic-threads.html > Not sure what's happening here. > * igt@i915_module_load@reload-with-fault-injection: > - fi-icl-guc: [PASS][5] -> [DMESG-WARN][6] > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-icl-guc/igt@i915_module_load@reload-with-fault-injection.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-icl-guc/igt@i915_module_load@reload-with-fault-injection.html These are legit, the hdcp cleanup function is called in error paths where the connector is still registered. \snip > > * igt@runner@aborted: > - fi-whl-u: NOTRUN -> [FAIL][43] > [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-whl-u/igt@runner@aborted.html > - fi-byt-j1900: NOTRUN -> [FAIL][44] > [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-byt-j1900/igt@runner@aborted.html > - fi-cfl-guc: NOTRUN -> [FAIL][45] > [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-cfl-guc/igt@runner@aborted.html > - fi-cfl-8700k: NOTRUN -> [FAIL][46] > [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-cfl-8700k/igt@runner@aborted.html > - fi-byt-n2820: NOTRUN -> [FAIL][47] > [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-byt-n2820/igt@runner@aborted.html Same WARNs as above from the failure paths. Will revise, Sean > > > Known issues > ------------ > > Here are the changes found in Patchwork_15728 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@kms_chamelium@hdmi-hpd-fast: > - fi-kbl-7500u: [PASS][48] -> [FAIL][49] ([fdo#111407]) > [48]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html > [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html > > > #### Possible fixes #### > > * igt@i915_selftest@live_blt: > - fi-bsw-n3050: [DMESG-FAIL][50] ([i915#723]) -> [PASS][51] > [50]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-bsw-n3050/igt@i915_selftest@live_blt.html > [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-bsw-n3050/igt@i915_selftest@live_blt.html > - fi-ivb-3770: [DMESG-FAIL][52] ([i915#725]) -> [PASS][53] > [52]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-ivb-3770/igt@i915_selftest@live_blt.html > [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-ivb-3770/igt@i915_selftest@live_blt.html > - fi-hsw-4770r: [DMESG-FAIL][54] ([i915#725]) -> [PASS][55] > [54]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-hsw-4770r/igt@i915_selftest@live_blt.html > [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-hsw-4770r/igt@i915_selftest@live_blt.html > > > #### Warnings #### > > * igt@gem_exec_suspend@basic-s0: > - fi-kbl-x1275: [DMESG-WARN][56] ([i915#62] / [i915#92]) -> [DMESG-WARN][57] ([i915#62] / [i915#92] / [i915#95]) +6 similar issues > [56]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html > [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-kbl-x1275/igt@gem_exec_suspend@basic-s0.html > > * igt@i915_module_load@reload: > - fi-icl-u2: [DMESG-WARN][58] ([i915#289]) -> [DMESG-WARN][59] ([i915#109] / [i915#289]) > [58]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-icl-u2/igt@i915_module_load@reload.html > [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-icl-u2/igt@i915_module_load@reload.html > > * igt@i915_selftest@live_gem_contexts: > - fi-hsw-peppy: [INCOMPLETE][60] ([i915#694]) -> [DMESG-FAIL][61] ([i915#722]) > [60]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html > [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-hsw-peppy/igt@i915_selftest@live_gem_contexts.html > > * igt@kms_flip@basic-flip-vs-modeset: > - fi-kbl-x1275: [DMESG-WARN][62] ([i915#62] / [i915#92] / [i915#95]) -> [DMESG-WARN][63] ([i915#62] / [i915#92]) +4 similar issues > [62]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html > [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-kbl-x1275/igt@kms_flip@basic-flip-vs-modeset.html > > * igt@runner@aborted: > - fi-icl-guc: [FAIL][64] ([fdo#110943] / [fdo#111093]) -> [FAIL][65] ([fdo#111093]) > [64]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-icl-guc/igt@runner@aborted.html > [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-icl-guc/igt@runner@aborted.html > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [fdo#110943]: https://bugs.freedesktop.org/show_bug.cgi?id=110943 > [fdo#111093]: https://bugs.freedesktop.org/show_bug.cgi?id=111093 > [fdo#111407]: https://bugs.freedesktop.org/show_bug.cgi?id=111407 > [fdo#111593]: https://bugs.freedesktop.org/show_bug.cgi?id=111593 > [i915#109]: https://gitlab.freedesktop.org/drm/intel/issues/109 > [i915#289]: https://gitlab.freedesktop.org/drm/intel/issues/289 > [i915#476]: https://gitlab.freedesktop.org/drm/intel/issues/476 > [i915#62]: https://gitlab.freedesktop.org/drm/intel/issues/62 > [i915#694]: https://gitlab.freedesktop.org/drm/intel/issues/694 > [i915#722]: https://gitlab.freedesktop.org/drm/intel/issues/722 > [i915#723]: https://gitlab.freedesktop.org/drm/intel/issues/723 > [i915#725]: https://gitlab.freedesktop.org/drm/intel/issues/725 > [i915#92]: https://gitlab.freedesktop.org/drm/intel/issues/92 > [i915#95]: https://gitlab.freedesktop.org/drm/intel/issues/95 > > > Participating hosts (52 -> 46) > ------------------------------ > > Additional (1): fi-bsw-nick > Missing (7): fi-icl-1065g7 fi-ilk-m540 fi-byt-squawks fi-bsw-cyan fi-ctg-p8600 fi-byt-clapper fi-bdw-samus > > > Build changes > ------------- > > * CI: CI-20190529 -> None > * Linux: CI_DRM_7553 -> Patchwork_15728 > > CI-20190529: 20190529 > CI_DRM_7553: 85e34ee26876ad3d0438ed9cc0d1b727761dcded @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_5346: 466b0e6cbcbaccff012b484d1fd7676364b37b93 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools > Patchwork_15728: 33b2dcba156f572b3107663a3fe393ff1f8ff917 @ git://anongit.freedesktop.org/gfx-ci/linux > > > == Linux commits == > > 33b2dcba156f drm/i915: Add HDCP 1.4 support for MST connectors > 42978bd3f621 drm/i915: Expose HDCP shim functions from dp for use by dp_mst > f03715af66e3 drm/i915: Use ddi_update_pipe in intel_dp_mst > d1165847a339 drm/i915: Support DP MST in enc_to_dig_port() function > 5cf2459e1ab8 drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it > 46a30f077469 drm/i915: Protect workers against disappearing connectors > 03cad2db95dc drm/i915: Factor out hdcp->value assignments > 135b02f35aa2 drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling > 2ef309e174b5 drm/i915: Intercept Aksv writes in the aux hooks > b16968ebee0e drm/i915: WARN if HDCP signalling is enabled upon disable > ab50e164f964 drm/i915: Clear the repeater bit on HDCP disable > 4f25d7348ece drm/i915: Fix sha_text population code > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/index.html
Quoting Sean Paul (2019-12-12 22:50:12) > On Thu, Dec 12, 2019 at 4:34 PM Patchwork > > #### Possible regressions #### > > > > * igt@gem_close_race@basic-threads: > > - fi-byt-j1900: [PASS][1] -> [TIMEOUT][2] > > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-byt-j1900/igt@gem_close_race@basic-threads.html > > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-byt-j1900/igt@gem_close_race@basic-threads.html > > - fi-byt-n2820: [PASS][3] -> [TIMEOUT][4] > > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_7553/fi-byt-n2820/igt@gem_close_race@basic-threads.html > > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_15728/fi-byt-n2820/igt@gem_close_race@basic-threads.html > > > > Not sure what's happening here. Nothing to see here, perfectly normal behaviour. Please move along. If that fails, please look into this red dot. -Chris
From: Sean Paul <seanpaul@chromium.org> Hello again, Here's the second version of my set to enable MST over HDCP. The big changes stemmed from Ville's review. It was super helpful to get that pushback, and led me to more critically debug the disable paths. As a result, I think I chased a few more gremlins out of the system. Individual commit messages have the v2 changes, so I won't enumerate them here. Thanks in advance, Sean v1 cover: https://lists.freedesktop.org/archives/dri-devel/2019-December/247501.html Sean Paul (12): drm/i915: Fix sha_text population code drm/i915: Clear the repeater bit on HDCP disable drm/i915: WARN if HDCP signalling is enabled upon disable drm/i915: Intercept Aksv writes in the aux hooks drm/i915: Use the cpu_transcoder in intel_hdcp to toggle HDCP signalling drm/i915: Factor out hdcp->value assignments drm/i915: Protect workers against disappearing connectors drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it drm/i915: Support DP MST in enc_to_dig_port() function drm/i915: Use ddi_update_pipe in intel_dp_mst drm/i915: Expose HDCP shim functions from dp for use by dp_mst drm/i915: Add HDCP 1.4 support for MST connectors drivers/gpu/drm/i915/display/intel_ddi.c | 27 +-- drivers/gpu/drm/i915/display/intel_ddi.h | 2 + .../drm/i915/display/intel_display_types.h | 47 ++++- drivers/gpu/drm/i915/display/intel_dp.c | 79 ++++---- drivers/gpu/drm/i915/display/intel_dp.h | 6 + drivers/gpu/drm/i915/display/intel_dp_mst.c | 90 +++++++++ drivers/gpu/drm/i915/display/intel_hdcp.c | 190 ++++++++++++++---- drivers/gpu/drm/i915/display/intel_hdmi.c | 18 +- include/drm/drm_hdcp.h | 3 + 9 files changed, 352 insertions(+), 110 deletions(-)