| Message ID | 20210526064237.77853-1-matthew.brost@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | Non-interface changing GuC CTBs updates | expand |
On Thu, May 27, 2021 at 10:13:11AM -0700, John Harrison wrote: > AFAICT, none of these warnings are related to this patch set. > Yep, other series submitted around the same time as this had the same warnings. > John. > > > On 5/25/2021 23:43, Patchwork wrote: > > == Series Details == > > > > Series: Non-interface changing GuC CTBs updates (rev2) > > URL : https://patchwork.freedesktop.org/series/90552/ > > State : warning > > > > == Summary == > > > > $ dim sparse --fast origin/drm-tip > > Sparse version: v0.6.2 > > Fast mode used, each commit won't be checked separately. > > - > > +drivers/gpu/drm/i915/display/intel_display.c:1887:21: expected struct i915_vma *[assigned] vma > > +drivers/gpu/drm/i915/display/intel_display.c:1887:21: got void [noderef] __iomem *[assigned] iomem > > +drivers/gpu/drm/i915/display/intel_display.c:1887:21: warning: incorrect type in assignment (different address spaces) > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 > > +drivers/gpu/drm/i915/gt/intel_reset.c:1328:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block > > +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer > > +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 > > +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 > > +drivers/gpu/drm/i915/intel_wakeref.c:137:19: warning: context imbalance in 'wakeref_auto_timeout' - unexpected unlock > > +drivers/gpu/drm/i915/selftests/i915_syncmap.c:80:54: warning: dubious: x | !y > > +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) > > +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block > > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block > > > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
On Thu, May 27, 2021 at 10:13:21AM -0700, John Harrison wrote: > On 5/25/2021 23:42, Patchwork wrote: > > == Series Details == > > > > Series: Non-interface changing GuC CTBs updates (rev2) > > URL : https://patchwork.freedesktop.org/series/90552/ > > State : warning > > > > == Summary == > > > > $ dim checkpatch origin/drm-tip > > 6b6bffd59ced drm/i915/guc: skip disabling CTBs before sanitizing the GuC > > 3f9bbaddbf9d drm/i915/guc: use probe_error log for CT enablement failure > > 866285dad8d0 drm/i915/guc: enable only the user interrupt when using GuC submission > > eafc57f85f6f drm/i915/guc: Remove sample_forcewake h2g action > > cb62a7f50e3b drm/i915/guc: Keep strict GuC ABI definitions > > -:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? > > #18: > > new file mode 100644 > > > > total: 0 errors, 1 warnings, 0 checks, 476 lines checked > > 28e9b20a7873 drm/i915/guc: Drop guc->interrupts.enabled > > 190975af8c9f drm/i915/guc: Stop using fence/status from CTB descriptor > > 15a068ac5b1e drm/i915: Promote ptrdiff() to i915_utils.h > > e3a6d58106c2 drm/i915/guc: Only rely on own CTB size > > aaa8781a008e drm/i915/guc: Don't repeat CTB layout calculations > > b065023c038e drm/i915/guc: Replace CTB array with explicit members > > 9f1ec21626ae drm/i915/guc: Update sizes of CTB buffers > > 7a0e05be601b drm/i915/guc: Relax CTB response timeout > > 11573d2c3987 drm/i915/guc: Start protecting access to CTB descriptors > > -:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment > > #87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36: > > + spinlock_t lock; > > > > total: 0 errors, 0 warnings, 1 checks, 61 lines checked > > f32e4faa422e drm/i915/guc: Ensure H2G buffer updates visible before tail update > > -:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line > > #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331: > > +static void write_barrier(struct intel_guc_ct *ct) { > > > > -:31: WARNING:MEMORY_BARRIER: memory barrier without comment > > #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339: > > + wmb(); > These three warnings should be fixed. > Will do. But it seems odd to require comments for these. > John. > > > total: 1 errors, 1 warnings, 0 checks, 30 lines checked > > 6feab437948e drm/i915/guc: Stop using mutex while sending CTB messages > > a44bbeef3e75 drm/i915/guc: Don't receive all G2H messages in irq handler > > 41650b9fd9e5 drm/i915/guc: Always copy CT message to new allocation > > > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > https://lists.freedesktop.org/mailman/listinfo/intel-gfx >
AFAICT, none of these warnings are related to this patch set. John. On 5/25/2021 23:43, Patchwork wrote: > == Series Details == > > Series: Non-interface changing GuC CTBs updates (rev2) > URL : https://patchwork.freedesktop.org/series/90552/ > State : warning > > == Summary == > > $ dim sparse --fast origin/drm-tip > Sparse version: v0.6.2 > Fast mode used, each commit won't be checked separately. > - > +drivers/gpu/drm/i915/display/intel_display.c:1887:21: expected struct i915_vma *[assigned] vma > +drivers/gpu/drm/i915/display/intel_display.c:1887:21: got void [noderef] __iomem *[assigned] iomem > +drivers/gpu/drm/i915/display/intel_display.c:1887:21: warning: incorrect type in assignment (different address spaces) > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:27:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:32:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:49:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_engine_stats.h:56:9: warning: trying to copy expression type 31 > +drivers/gpu/drm/i915/gt/intel_reset.c:1328:5: warning: context imbalance in 'intel_gt_reset_trylock' - different lock contexts for basic block > +drivers/gpu/drm/i915/gt/intel_ring_submission.c:1207:24: warning: Using plain integer as NULL pointer > +drivers/gpu/drm/i915/i915_perf.c:1434:15: warning: memset with byte count of 16777216 > +drivers/gpu/drm/i915/i915_perf.c:1488:15: warning: memset with byte count of 16777216 > +drivers/gpu/drm/i915/intel_wakeref.c:137:19: warning: context imbalance in 'wakeref_auto_timeout' - unexpected unlock > +drivers/gpu/drm/i915/selftests/i915_syncmap.c:80:54: warning: dubious: x | !y > +./include/asm-generic/bitops/find.h:112:45: warning: shift count is negative (-262080) > +./include/asm-generic/bitops/find.h:32:31: warning: shift count is negative (-262080) > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read64' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_read8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'fwtable_write8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read64' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_read8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen11_fwtable_write8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read64' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_read8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen12_fwtable_write8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read64' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_read8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen6_write8' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write16' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write32' - different lock contexts for basic block > +./include/linux/spinlock.h:409:9: warning: context imbalance in 'gen8_write8' - different lock contexts for basic block > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On 5/25/2021 23:42, Patchwork wrote: > == Series Details == > > Series: Non-interface changing GuC CTBs updates (rev2) > URL : https://patchwork.freedesktop.org/series/90552/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > 6b6bffd59ced drm/i915/guc: skip disabling CTBs before sanitizing the GuC > 3f9bbaddbf9d drm/i915/guc: use probe_error log for CT enablement failure > 866285dad8d0 drm/i915/guc: enable only the user interrupt when using GuC submission > eafc57f85f6f drm/i915/guc: Remove sample_forcewake h2g action > cb62a7f50e3b drm/i915/guc: Keep strict GuC ABI definitions > -:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating? > #18: > new file mode 100644 > > total: 0 errors, 1 warnings, 0 checks, 476 lines checked > 28e9b20a7873 drm/i915/guc: Drop guc->interrupts.enabled > 190975af8c9f drm/i915/guc: Stop using fence/status from CTB descriptor > 15a068ac5b1e drm/i915: Promote ptrdiff() to i915_utils.h > e3a6d58106c2 drm/i915/guc: Only rely on own CTB size > aaa8781a008e drm/i915/guc: Don't repeat CTB layout calculations > b065023c038e drm/i915/guc: Replace CTB array with explicit members > 9f1ec21626ae drm/i915/guc: Update sizes of CTB buffers > 7a0e05be601b drm/i915/guc: Relax CTB response timeout > 11573d2c3987 drm/i915/guc: Start protecting access to CTB descriptors > -:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment > #87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36: > + spinlock_t lock; > > total: 0 errors, 0 warnings, 1 checks, 61 lines checked > f32e4faa422e drm/i915/guc: Ensure H2G buffer updates visible before tail update > -:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line > #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331: > +static void write_barrier(struct intel_guc_ct *ct) { > > -:31: WARNING:MEMORY_BARRIER: memory barrier without comment > #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339: > + wmb(); These three warnings should be fixed. John. > total: 1 errors, 1 warnings, 0 checks, 30 lines checked > 6feab437948e drm/i915/guc: Stop using mutex while sending CTB messages > a44bbeef3e75 drm/i915/guc: Don't receive all G2H messages in irq handler > 41650b9fd9e5 drm/i915/guc: Always copy CT message to new allocation > > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
As discussed in [1] we are breaking that large series into a several smaller ones. This series is the non-interface changing part of step #2 - it makes all the changes needed before updating the GuC firwmare to a new version without breaking any old interfaces. A follow on series will be squashed into a single patch that updates the GuC firmware + the required interface changes. Patch number #13 needs an Ack from Michal Wajdeczko. Patch number #6, #15 need reviews. v2: Fix some checkpatch warnings, add patch number #6 to address CI failure [2] in first rev [1] https://patchwork.freedesktop.org/series/89844/ [2] https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_20192/shard-tglb3/igt@gem_eio@in-flight-suspend.html Signed-off-by: Matthew Brost <matthew.brost@intel.com> Daniele Ceraolo Spurio (3): drm/i915/guc: skip disabling CTBs before sanitizing the GuC drm/i915/guc: use probe_error log for CT enablement failure drm/i915/guc: enable only the user interrupt when using GuC submission Matthew Brost (2): drm/i915/guc: Drop guc->interrupts.enabled drm/i915/guc: Ensure H2G buffer updates visible before tail update Michal Wajdeczko (12): drm/i915/guc: Keep strict GuC ABI definitions drm/i915/guc: Stop using fence/status from CTB descriptor drm/i915: Promote ptrdiff() to i915_utils.h drm/i915/guc: Only rely on own CTB size drm/i915/guc: Don't repeat CTB layout calculations drm/i915/guc: Replace CTB array with explicit members drm/i915/guc: Update sizes of CTB buffers drm/i915/guc: Relax CTB response timeout drm/i915/guc: Start protecting access to CTB descriptors drm/i915/guc: Stop using mutex while sending CTB messages drm/i915/guc: Don't receive all G2H messages in irq handler drm/i915/guc: Always copy CT message to new allocation Rodrigo Vivi (1): drm/i915/guc: Remove sample_forcewake h2g action drivers/gpu/drm/i915/Kconfig.profile | 9 + drivers/gpu/drm/i915/gt/intel_gt_irq.c | 18 +- .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h | 51 ++ .../gt/uc/abi/guc_communication_ctb_abi.h | 106 ++++ .../gt/uc/abi/guc_communication_mmio_abi.h | 52 ++ .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h | 14 + .../gpu/drm/i915/gt/uc/abi/guc_messages_abi.h | 21 + drivers/gpu/drm/i915/gt/uc/intel_guc.c | 43 +- drivers/gpu/drm/i915/gt/uc/intel_guc.h | 2 - drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 527 ++++++++++-------- drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h | 14 +- drivers/gpu/drm/i915/gt/uc/intel_guc_fwif.h | 207 +------ .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 31 -- drivers/gpu/drm/i915/gt/uc/intel_uc.c | 10 - drivers/gpu/drm/i915/i915_utils.h | 5 + drivers/gpu/drm/i915/i915_vma.h | 5 - 16 files changed, 605 insertions(+), 510 deletions(-) create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_actions_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_ctb_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_communication_mmio_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_errors_abi.h create mode 100644 drivers/gpu/drm/i915/gt/uc/abi/guc_messages_abi.h