[0/2] Sanity Check for device memory region

Message

Ramalingam C Dec. 7, 2021, 2:33 p.m. UTC

Changes for introducing the quick test on the device memory range and
also a test of detailed validation for each addr of the range with read
and write.

Detailed testing is optionally enabled with a modparam i915.memtest=1

Chris Wilson (2):
  drm/i915: Sanitycheck device iomem on probe
  drm/i915: Test all device memory on probing

 drivers/gpu/drm/i915/i915_params.c         |   3 +
 drivers/gpu/drm/i915/i915_params.h         |   1 +
 drivers/gpu/drm/i915/intel_memory_region.c | 116 +++++++++++++++++++++
 3 files changed, 120 insertions(+)

Comments

Matthew Auld Dec. 7, 2021, 4:04 p.m. UTC | #1

On Tue, 7 Dec 2021 at 14:34, Ramalingam C <[e-mail]> wrote:
>
> Changes for introducing the quick test on the device memory range and
> also a test of detailed validation for each addr of the range with read
> and write.
>
> Detailed testing is optionally enabled with a modparam i915.memtest=1

Series is missing Cc: dri-devel

Also on DG1, CI is apparently spitting out:

<7> [128.605872] i915 0000:03:00.0: [drm:i915_gem_init_stolen [i915]]
GEN6_STOLEN_RESERVED = 0x00000000ffc00107
<7> [128.605978] i915 0000:03:00.0: [drm:i915_gem_init_stolen [i915]]
Memory reserved for graphics device: 65536K, usable: 61440K
<3> [128.606145] i915 0000:03:00.0: Failed to read back from memory
region:[mem 0xfc000000-0xffffffff] at [0x00000040fc000000 +
0x0000000003fff000] for i915_gem_stolen_lmem_setup [i915]; wrote 0,
read (ff, ff, ff)
<3> [128.606297] i915 0000:03:00.0: [drm] *ERROR* Failed to setup
region(-22) type=3
<3> [128.623091] i915 0000:03:00.0: Device initialization failed (-22)

So something is busted with stolen-lmem it seems...wonder if that's
related to the DG2 issue.

>
> Chris Wilson (2):
>   drm/i915: Sanitycheck device iomem on probe
>   drm/i915: Test all device memory on probing
>
>  drivers/gpu/drm/i915/i915_params.c         |   3 +
>  drivers/gpu/drm/i915/i915_params.h         |   1 +
>  drivers/gpu/drm/i915/intel_memory_region.c | 116 +++++++++++++++++++++
>  3 files changed, 120 insertions(+)
>
> --
> 2.20.1
>

Matthew Auld Dec. 7, 2021, 6:28 p.m. UTC | #2

On Tue, 7 Dec 2021 at 16:04, Matthew Auld
<[e-mail]> wrote:
>
> On Tue, 7 Dec 2021 at 14:34, Ramalingam C <[e-mail]> wrote:
> >
> > Changes for introducing the quick test on the device memory range and
> > also a test of detailed validation for each addr of the range with read
> > and write.
> >
> > Detailed testing is optionally enabled with a modparam i915.memtest=1
>
> Series is missing Cc: dri-devel
>
> Also on DG1, CI is apparently spitting out:
>
> <7> [128.605872] i915 0000:03:00.0: [drm:i915_gem_init_stolen [i915]]
> GEN6_STOLEN_RESERVED = 0x00000000ffc00107
> <7> [128.605978] i915 0000:03:00.0: [drm:i915_gem_init_stolen [i915]]
> Memory reserved for graphics device: 65536K, usable: 61440K
> <3> [128.606145] i915 0000:03:00.0: Failed to read back from memory
> region:[mem 0xfc000000-0xffffffff] at [0x00000040fc000000 +
> 0x0000000003fff000] for i915_gem_stolen_lmem_setup [i915]; wrote 0,
> read (ff, ff, ff)
> <3> [128.606297] i915 0000:03:00.0: [drm] *ERROR* Failed to setup
> region(-22) type=3
> <3> [128.623091] i915 0000:03:00.0: Device initialization failed (-22)
>
> So something is busted with stolen-lmem it seems...wonder if that's
> related to the DG2 issue.

Ram, as part of this series can you also grab:
drm/i915: Exclude reserved stolen from driver use

That might fix the DG2 stolen issue also...

>
> >
> > Chris Wilson (2):
> >   drm/i915: Sanitycheck device iomem on probe
> >   drm/i915: Test all device memory on probing
> >
> >  drivers/gpu/drm/i915/i915_params.c         |   3 +
> >  drivers/gpu/drm/i915/i915_params.h         |   1 +
> >  drivers/gpu/drm/i915/intel_memory_region.c | 116 +++++++++++++++++++++
> >  3 files changed, 120 insertions(+)
> >
> > --
> > 2.20.1
> >