[v3,0/4] GuC HWCONFIG with documentation

Message

Jordan Justen Feb. 8, 2022, 9:04 p.m. UTC

This is John/Rodrigo's 2 patches with some minor changes, and I added
2 patches.

"drm/i915/uapi: Add query for hwconfig blob" was changed:

 * Rename DRM_I915_QUERY_HWCONFIG_TABLE to DRM_I915_QUERY_HWCONFIG_BLOB
   as requested by Joonas.

 * Reword commit message

 * I added Acked-by to this patch, but this only applies in the
   context of this version of the patchset. If my changes are
   rejected, then please *do not* add my Acked-by to the other series.

   In particular, I do not want my Acked-by on the patch if the patch
   mentions the HWCONFIG format, but is not willing to add that to the
   actual uAPI.

   I also do not want my Acked-by on it if it mentions "consolidation"
   of this data. Since we are dealing with open source projects (aside
   from GuC), this doesn't seem appropriate.

"drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item" adds a
struct to the uAPI and documents the return value for
DRM_I915_QUERY_HWCONFIG_BLOB. (Except, keys / values are still
deferred to the PRM.)

"drm/i915/guc: Verify hwconfig blob matches supported format" does the
simple verification of the blob to make sure it matches what the uAPI
documents.

v2:
 * Fix -Werror errors.
 * Rebase to drm-intel/for-linux-next instead of
   drm-intel/for-linux-next-gt, as this seems to be what CI wants.
 * Fix u32 -> __u32. (Sorry, I was first testing in Mesa tree.)
 * Add commit message for "Verify hwconfig blob" patch as requested by
   Tvrtko.
 * Reword text added to i915_drm.h as requested by Tvrtko. (Attempting
   to indicate the overall blob ends right at the last blob item.)

v3:
 * Add several changes suggested by Tvrtko in the "Verify hwconfig
   blob", along with some tweaks to i915_drm.h from the feedback for
   the same patch.

John Harrison (1):
  drm/i915/guc: Add fetch of hwconfig table

Jordan Justen (2):
  drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item
  drm/i915/guc: Verify hwconfig blob matches supported format

Rodrigo Vivi (1):
  drm/i915/uapi: Add query for hwconfig blob

 drivers/gpu/drm/i915/Makefile                 |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
 .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
 drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   3 +
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 201 ++++++++++++++++++
 .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 ++
 drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
 drivers/gpu/drm/i915/i915_query.c             |  23 ++
 include/uapi/drm/i915_drm.h                   |  33 +++
 9 files changed, 291 insertions(+)
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
 create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h

Comments

Bloomfield, Jon Feb. 9, 2022, 7:08 p.m. UTC | #1

Acked-by: Jon Bloomfield <[e-mail]>

> -----Original Message-----
> From: Intel-gfx <[e-mail]> On Behalf Of
> Jordan Justen
> Sent: Tuesday, February 8, 2022 1:05 PM
> To: intel-gfx <[e-mail]>
> Cc: dri-devel <[e-mail]>
> Subject: [Intel-gfx] [PATCH v3 0/4] GuC HWCONFIG with documentation
> 
> This is John/Rodrigo's 2 patches with some minor changes, and I added
> 2 patches.
> 
> "drm/i915/uapi: Add query for hwconfig blob" was changed:
> 
>  * Rename DRM_I915_QUERY_HWCONFIG_TABLE to
> DRM_I915_QUERY_HWCONFIG_BLOB
>    as requested by Joonas.
> 
>  * Reword commit message
> 
>  * I added Acked-by to this patch, but this only applies in the
>    context of this version of the patchset. If my changes are
>    rejected, then please *do not* add my Acked-by to the other series.
> 
>    In particular, I do not want my Acked-by on the patch if the patch
>    mentions the HWCONFIG format, but is not willing to add that to the
>    actual uAPI.
> 
>    I also do not want my Acked-by on it if it mentions "consolidation"
>    of this data. Since we are dealing with open source projects (aside
>    from GuC), this doesn't seem appropriate.
> 
> "drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item" adds a
> struct to the uAPI and documents the return value for
> DRM_I915_QUERY_HWCONFIG_BLOB. (Except, keys / values are still
> deferred to the PRM.)
> 
> "drm/i915/guc: Verify hwconfig blob matches supported format" does the
> simple verification of the blob to make sure it matches what the uAPI
> documents.
> 
> v2:
>  * Fix -Werror errors.
>  * Rebase to drm-intel/for-linux-next instead of
>    drm-intel/for-linux-next-gt, as this seems to be what CI wants.
>  * Fix u32 -> __u32. (Sorry, I was first testing in Mesa tree.)
>  * Add commit message for "Verify hwconfig blob" patch as requested by
>    Tvrtko.
>  * Reword text added to i915_drm.h as requested by Tvrtko. (Attempting
>    to indicate the overall blob ends right at the last blob item.)
> 
> v3:
>  * Add several changes suggested by Tvrtko in the "Verify hwconfig
>    blob", along with some tweaks to i915_drm.h from the feedback for
>    the same patch.
> 
> John Harrison (1):
>   drm/i915/guc: Add fetch of hwconfig table
> 
> Jordan Justen (2):
>   drm/i915/uapi: Add struct drm_i915_query_hwconfig_blob_item
>   drm/i915/guc: Verify hwconfig blob matches supported format
> 
> Rodrigo Vivi (1):
>   drm/i915/uapi: Add query for hwconfig blob
> 
>  drivers/gpu/drm/i915/Makefile                 |   1 +
>  .../gpu/drm/i915/gt/uc/abi/guc_actions_abi.h  |   1 +
>  .../gpu/drm/i915/gt/uc/abi/guc_errors_abi.h   |   4 +
>  drivers/gpu/drm/i915/gt/uc/intel_guc.h        |   3 +
>  .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.c   | 201 ++++++++++++++++++
>  .../gpu/drm/i915/gt/uc/intel_guc_hwconfig.h   |  19 ++
>  drivers/gpu/drm/i915/gt/uc/intel_uc.c         |   6 +
>  drivers/gpu/drm/i915/i915_query.c             |  23 ++
>  include/uapi/drm/i915_drm.h                   |  33 +++
>  9 files changed, 291 insertions(+)
>  create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.c
>  create mode 100644 drivers/gpu/drm/i915/gt/uc/intel_guc_hwconfig.h
> 
> --
> 2.34.1