From patchwork Tue Aug 2 10:52:26 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Kandpal, Suraj" X-Patchwork-Id: 12934506 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09454C00140 for ; Tue, 2 Aug 2022 10:53:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0368910FDA6; Tue, 2 Aug 2022 10:53:36 +0000 (UTC) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 48AF411B730 for ; Tue, 2 Aug 2022 10:53:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1659437601; x=1690973601; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=atQLkOCvurJPOfJvUDEBrfbHtjhff8X0zmiYjqg3za4=; b=nSRLvHjQBLz4bdkV+EYWU8Mj/AXqLbXgCxkjzshAHOrdzdOpIltoCOCY TI13BEmzTLk7ZqRCGGL6tz+VF3GJmDQdOtHg//04WH9bbwLtA6D+7Xe+G m9jqWZodiTE6jbQYFXYMMlHxtfJDl6M8d7SBvHIvxKd64IJKVPwedL80q nU0rMQ+EAehAc/0l2p0OTT3TEgQYaUUICfFJdbHDbeLMSDM+N1S3oOpRe eNY4PUEx1AqUonXl0KUqmwWVkTaw9iwj6amfxCHUwWjW7yKIwNxqcWdMR i13XJXnMCB09VZUl8pRfZsvz/2G/m3qJ4or+kCLapELvEpHcsocbdooTY g==; X-IronPort-AV: E=McAfee;i="6400,9594,10426"; a="353384021" X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="353384021" Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Aug 2022 03:53:20 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.93,210,1654585200"; d="scan'208";a="705332918" Received: from kandpal.iind.intel.com ([10.190.239.32]) by fmsmga002.fm.intel.com with ESMTP; 02 Aug 2022 03:53:17 -0700 From: Suraj Kandpal To: intel-gfx@lists.freedesktop.org Date: Tue, 2 Aug 2022 16:22:26 +0530 Message-Id: <20220802105228.3356260-1-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.37.0 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH 0/2] Enabling Pipewriteback X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ville.syrjala@intel.com, jani.nikula@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" A patch series was floated in the drm mailing list which aimed to change the drm_connector and drm_encoder fields to pointer in the drm_connector_writeback structure, this received a huge pushback from the community but since i915 expects each connector present in the drm_device list to be a intel_connector but drm_writeback framework makes us have a connector which cannot be embedded in an intel_connector structure. [1] https://patchwork.kernel.org/project/dri-devel/patch/20220202081702.22119-1-suraj.kandpal@intel.com/ [2] https://patchwork.kernel.org/project/dri-devel/patch/20220202085429.22261-6-suraj.kandpal@intel.com/ Since no one had an issue with encoder field being changed into a pointer it was decided to break the connector and encoder pointer changes into two different series.The encoder field changes is currently being worked upon by Abhinav Kumar and the changes have been merged. [3]https://patchwork.kernel.org/project/dri-devel/list/?series=633565 Going forward we use a drm_connector which is not embedded in intel_connector. We also create a intel_encoder to avoid changes to many iterators but no intel_connector. We also changed all iterators that go through connectors and add a check to only cast connectors which are not writeback connectors. Suraj Kandpal (2): drm/i915: Define WD trancoder for i915 drm/i915: Enabling WD Transcoder drivers/gpu/drm/i915/Makefile | 1 + drivers/gpu/drm/i915/display/intel_acpi.c | 1 + drivers/gpu/drm/i915/display/intel_crtc.c | 3 + .../drm/i915/display/intel_crtc_state_dump.c | 1 + drivers/gpu/drm/i915/display/intel_display.c | 63 +- drivers/gpu/drm/i915/display/intel_display.h | 25 +- .../drm/i915/display/intel_display_debugfs.c | 14 +- .../drm/i915/display/intel_display_types.h | 37 + drivers/gpu/drm/i915/display/intel_dpll.c | 6 + .../drm/i915/display/intel_modeset_setup.c | 67 +- .../drm/i915/display/intel_modeset_verify.c | 18 +- drivers/gpu/drm/i915/display/intel_opregion.c | 3 + .../gpu/drm/i915/display/intel_wb_connector.h | 20 + drivers/gpu/drm/i915/display/intel_wd.c | 726 ++++++++++++++++++ drivers/gpu/drm/i915/display/intel_wd.h | 76 ++ drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_irq.c | 8 +- drivers/gpu/drm/i915/i915_pci.c | 7 +- drivers/gpu/drm/i915/i915_reg.h | 139 ++++ 19 files changed, 1190 insertions(+), 27 deletions(-) create mode 100644 drivers/gpu/drm/i915/display/intel_wb_connector.h create mode 100644 drivers/gpu/drm/i915/display/intel_wd.c create mode 100644 drivers/gpu/drm/i915/display/intel_wd.h