| Message ID | 20220909025646.3397620-1-badal.nilawar@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | i915: CAGF and RC6 changes for MTL | expand |
Hi Badal, you haven't Cc'ed anyone here... Please do CC the people interested in the patches and dri-devel mailing list. If you don't mind, could you please resend the series either as a V2, if you are going to change something, or as a RESEND, if you will not change anything? Thanks, Andi On Fri, Sep 09, 2022 at 08:26:40AM +0530, Badal Nilawar wrote: > This series includes the code changes to get CAGF, RC State and > C6 Residency of MTL. The series depends on: > > https://patchwork.freedesktop.org/series/107908/ > > We have included 3 patches from from the above series as part of this > series in order for this series to compile. These are the first 3 patches > authored by Matt Roper. Please do not review these first 3 patches. Only > patch 4 and 6 needs review. > > v2: Included "Use GEN12 RPSTAT register" patch > > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> > > Badal Nilawar (2): > drm/i915/mtl: Modify CAGF functions for MTL > drm/i915/mtl: Add C6 residency support for MTL SAMedia > > Don Hiatt (1): > drm/i915: Use GEN12 RPSTAT register > > Matt Roper (3): > drm/i915: Prepare more multi-GT initialization > drm/i915: Rename and expose common GT early init routine > drm/i915/xelpmp: Expose media as another GT > > drivers/gpu/drm/i915/Makefile | 1 + > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > drivers/gpu/drm/i915/gt/intel_gt.c | 70 +++++++++++++++---- > drivers/gpu/drm/i915/gt/intel_gt.h | 2 +- > drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 58 ++++++++++++++- > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 31 ++++++++ > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 9 ++- > drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 + > drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +- > drivers/gpu/drm/i915/gt/intel_rps.c | 22 +++++- > drivers/gpu/drm/i915/gt/intel_rps.h | 1 + > drivers/gpu/drm/i915/gt/intel_sa_media.c | 39 +++++++++++ > drivers/gpu/drm/i915/gt/intel_sa_media.h | 15 ++++ > drivers/gpu/drm/i915/gt/selftest_rc6.c | 9 ++- > drivers/gpu/drm/i915/i915_drv.h | 2 + > drivers/gpu/drm/i915/i915_pci.c | 15 ++++ > drivers/gpu/drm/i915/i915_pmu.c | 11 ++- > drivers/gpu/drm/i915/intel_device_info.h | 19 +++++ > drivers/gpu/drm/i915/intel_uncore.c | 16 ++++- > drivers/gpu/drm/i915/intel_uncore.h | 20 +++++- > .../gpu/drm/i915/selftests/mock_gem_device.c | 1 + > 21 files changed, 325 insertions(+), 26 deletions(-) > create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.c > create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.h > > -- > 2.25.1
On Mon, 12 Sep 2022, Andi Shyti <andi.shyti@linux.intel.com> wrote: > Hi Badal, > > you haven't Cc'ed anyone here... Please do CC the people > interested in the patches and dri-devel mailing list. > > If you don't mind, could you please resend the series either as a > V2, if you are going to change something, or as a RESEND, if you > will not change anything? Anyway some of the patches have been merged already so a rebase is in order. BR, Jani. > > Thanks, > Andi > > On Fri, Sep 09, 2022 at 08:26:40AM +0530, Badal Nilawar wrote: >> This series includes the code changes to get CAGF, RC State and >> C6 Residency of MTL. The series depends on: >> >> https://patchwork.freedesktop.org/series/107908/ >> >> We have included 3 patches from from the above series as part of this >> series in order for this series to compile. These are the first 3 patches >> authored by Matt Roper. Please do not review these first 3 patches. Only >> patch 4 and 6 needs review. >> >> v2: Included "Use GEN12 RPSTAT register" patch >> >> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> >> >> Badal Nilawar (2): >> drm/i915/mtl: Modify CAGF functions for MTL >> drm/i915/mtl: Add C6 residency support for MTL SAMedia >> >> Don Hiatt (1): >> drm/i915: Use GEN12 RPSTAT register >> >> Matt Roper (3): >> drm/i915: Prepare more multi-GT initialization >> drm/i915: Rename and expose common GT early init routine >> drm/i915/xelpmp: Expose media as another GT >> >> drivers/gpu/drm/i915/Makefile | 1 + >> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- >> drivers/gpu/drm/i915/gt/intel_gt.c | 70 +++++++++++++++---- >> drivers/gpu/drm/i915/gt/intel_gt.h | 2 +- >> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 58 ++++++++++++++- >> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 31 ++++++++ >> drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 9 ++- >> drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 + >> drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +- >> drivers/gpu/drm/i915/gt/intel_rps.c | 22 +++++- >> drivers/gpu/drm/i915/gt/intel_rps.h | 1 + >> drivers/gpu/drm/i915/gt/intel_sa_media.c | 39 +++++++++++ >> drivers/gpu/drm/i915/gt/intel_sa_media.h | 15 ++++ >> drivers/gpu/drm/i915/gt/selftest_rc6.c | 9 ++- >> drivers/gpu/drm/i915/i915_drv.h | 2 + >> drivers/gpu/drm/i915/i915_pci.c | 15 ++++ >> drivers/gpu/drm/i915/i915_pmu.c | 11 ++- >> drivers/gpu/drm/i915/intel_device_info.h | 19 +++++ >> drivers/gpu/drm/i915/intel_uncore.c | 16 ++++- >> drivers/gpu/drm/i915/intel_uncore.h | 20 +++++- >> .../gpu/drm/i915/selftests/mock_gem_device.c | 1 + >> 21 files changed, 325 insertions(+), 26 deletions(-) >> create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.c >> create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.h >> >> -- >> 2.25.1
I added Cc: in individual patches. So I thought it will pick automatically. But anyway I have to fix some of the comments. So I will fix those and resend the series. I will Cc relevant people. Regards, Badal On 12-09-2022 17:37, Jani Nikula wrote: > On Mon, 12 Sep 2022, Andi Shyti <andi.shyti@linux.intel.com> wrote: >> Hi Badal, >> >> you haven't Cc'ed anyone here... Please do CC the people >> interested in the patches and dri-devel mailing list. >> >> If you don't mind, could you please resend the series either as a >> V2, if you are going to change something, or as a RESEND, if you >> will not change anything? > > Anyway some of the patches have been merged already so a rebase is in > order. > > BR, > Jani. > >> >> Thanks, >> Andi >> >> On Fri, Sep 09, 2022 at 08:26:40AM +0530, Badal Nilawar wrote: >>> This series includes the code changes to get CAGF, RC State and >>> C6 Residency of MTL. The series depends on: >>> >>> https://patchwork.freedesktop.org/series/107908/ >>> >>> We have included 3 patches from from the above series as part of this >>> series in order for this series to compile. These are the first 3 patches >>> authored by Matt Roper. Please do not review these first 3 patches. Only >>> patch 4 and 6 needs review. >>> >>> v2: Included "Use GEN12 RPSTAT register" patch >>> >>> Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> >>> >>> Badal Nilawar (2): >>> drm/i915/mtl: Modify CAGF functions for MTL >>> drm/i915/mtl: Add C6 residency support for MTL SAMedia >>> >>> Don Hiatt (1): >>> drm/i915: Use GEN12 RPSTAT register >>> >>> Matt Roper (3): >>> drm/i915: Prepare more multi-GT initialization >>> drm/i915: Rename and expose common GT early init routine >>> drm/i915/xelpmp: Expose media as another GT >>> >>> drivers/gpu/drm/i915/Makefile | 1 + >>> drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- >>> drivers/gpu/drm/i915/gt/intel_gt.c | 70 +++++++++++++++---- >>> drivers/gpu/drm/i915/gt/intel_gt.h | 2 +- >>> drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 58 ++++++++++++++- >>> drivers/gpu/drm/i915/gt/intel_gt_regs.h | 31 ++++++++ >>> drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 9 ++- >>> drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 + >>> drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +- >>> drivers/gpu/drm/i915/gt/intel_rps.c | 22 +++++- >>> drivers/gpu/drm/i915/gt/intel_rps.h | 1 + >>> drivers/gpu/drm/i915/gt/intel_sa_media.c | 39 +++++++++++ >>> drivers/gpu/drm/i915/gt/intel_sa_media.h | 15 ++++ >>> drivers/gpu/drm/i915/gt/selftest_rc6.c | 9 ++- >>> drivers/gpu/drm/i915/i915_drv.h | 2 + >>> drivers/gpu/drm/i915/i915_pci.c | 15 ++++ >>> drivers/gpu/drm/i915/i915_pmu.c | 11 ++- >>> drivers/gpu/drm/i915/intel_device_info.h | 19 +++++ >>> drivers/gpu/drm/i915/intel_uncore.c | 16 ++++- >>> drivers/gpu/drm/i915/intel_uncore.h | 20 +++++- >>> .../gpu/drm/i915/selftests/mock_gem_device.c | 1 + >>> 21 files changed, 325 insertions(+), 26 deletions(-) >>> create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.c >>> create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.h >>> >>> -- >>> 2.25.1 >
Hi Jani, On Mon, Sep 12, 2022 at 03:07:01PM +0300, Jani Nikula wrote: > On Mon, 12 Sep 2022, Andi Shyti <andi.shyti@linux.intel.com> wrote: > > Hi Badal, > > > > you haven't Cc'ed anyone here... Please do CC the people > > interested in the patches and dri-devel mailing list. > > > > If you don't mind, could you please resend the series either as a > > V2, if you are going to change something, or as a RESEND, if you > > will not change anything? > > Anyway some of the patches have been merged already so a rebase is in > order. thanks... I see that some of the patches have been reviewed previously, I missed that. Thank you, Andi
Hi Badal, On Mon, Sep 12, 2022 at 05:42:57PM +0530, Nilawar, Badal wrote: > I added Cc: in individual patches. So I thought it will pick automatically. > But anyway I have to fix some of the comments. So I will fix those and > resend the series. I will Cc relevant people. yes... it depends on your git-send-email command. I think no one has received the e-mail other than the mailing list. If you have the '--suppress-cc=all' flag then you need to explicitly add the --to/--cc recipients (this is how I do it in order avoid sending patches to unwanted people). If you don't have the '--suppress-cc=all' then git-send-email figures out by itself whom to send the patch by checking the commit tags. In both the cases, though, before sending the patches individually, git-send-email displays the people that have been added to the 'cc' list. Please make sure not to forget the dri-devel mailing list (<dri-devel@lists.freedesktop.org>) and to check if the patches are actually sent to everyone. Thanks, Andi > Regards, > Badal > > On 12-09-2022 17:37, Jani Nikula wrote: > > On Mon, 12 Sep 2022, Andi Shyti <andi.shyti@linux.intel.com> wrote: > > > Hi Badal, > > > > > > you haven't Cc'ed anyone here... Please do CC the people > > > interested in the patches and dri-devel mailing list. > > > > > > If you don't mind, could you please resend the series either as a > > > V2, if you are going to change something, or as a RESEND, if you > > > will not change anything? > > > > Anyway some of the patches have been merged already so a rebase is in > > order. > > > > BR, > > Jani. > > > > > > > > Thanks, > > > Andi > > > > > > On Fri, Sep 09, 2022 at 08:26:40AM +0530, Badal Nilawar wrote: > > > > This series includes the code changes to get CAGF, RC State and > > > > C6 Residency of MTL. The series depends on: > > > > > > > > https://patchwork.freedesktop.org/series/107908/ > > > > > > > > We have included 3 patches from from the above series as part of this > > > > series in order for this series to compile. These are the first 3 patches > > > > authored by Matt Roper. Please do not review these first 3 patches. Only > > > > patch 4 and 6 needs review. > > > > > > > > v2: Included "Use GEN12 RPSTAT register" patch > > > > > > > > Cc: Ashutosh Dixit <ashutosh.dixit@intel.com> > > > > > > > > Badal Nilawar (2): > > > > drm/i915/mtl: Modify CAGF functions for MTL > > > > drm/i915/mtl: Add C6 residency support for MTL SAMedia > > > > > > > > Don Hiatt (1): > > > > drm/i915: Use GEN12 RPSTAT register > > > > > > > > Matt Roper (3): > > > > drm/i915: Prepare more multi-GT initialization > > > > drm/i915: Rename and expose common GT early init routine > > > > drm/i915/xelpmp: Expose media as another GT > > > > > > > > drivers/gpu/drm/i915/Makefile | 1 + > > > > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > > > > drivers/gpu/drm/i915/gt/intel_gt.c | 70 +++++++++++++++---- > > > > drivers/gpu/drm/i915/gt/intel_gt.h | 2 +- > > > > drivers/gpu/drm/i915/gt/intel_gt_pm_debugfs.c | 58 ++++++++++++++- > > > > drivers/gpu/drm/i915/gt/intel_gt_regs.h | 31 ++++++++ > > > > drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm.c | 9 ++- > > > > drivers/gpu/drm/i915/gt/intel_gt_types.h | 3 + > > > > drivers/gpu/drm/i915/gt/intel_rc6.c | 5 +- > > > > drivers/gpu/drm/i915/gt/intel_rps.c | 22 +++++- > > > > drivers/gpu/drm/i915/gt/intel_rps.h | 1 + > > > > drivers/gpu/drm/i915/gt/intel_sa_media.c | 39 +++++++++++ > > > > drivers/gpu/drm/i915/gt/intel_sa_media.h | 15 ++++ > > > > drivers/gpu/drm/i915/gt/selftest_rc6.c | 9 ++- > > > > drivers/gpu/drm/i915/i915_drv.h | 2 + > > > > drivers/gpu/drm/i915/i915_pci.c | 15 ++++ > > > > drivers/gpu/drm/i915/i915_pmu.c | 11 ++- > > > > drivers/gpu/drm/i915/intel_device_info.h | 19 +++++ > > > > drivers/gpu/drm/i915/intel_uncore.c | 16 ++++- > > > > drivers/gpu/drm/i915/intel_uncore.h | 20 +++++- > > > > .../gpu/drm/i915/selftests/mock_gem_device.c | 1 + > > > > 21 files changed, 325 insertions(+), 26 deletions(-) > > > > create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.c > > > > create mode 100644 drivers/gpu/drm/i915/gt/intel_sa_media.h > > > > > > > > -- > > > > 2.25.1 > >