mbox series

[0/4] Prep series - CDCLK code churn

Message ID 20221021002024.390052-1-anusha.srivatsa@intel.com (mailing list archive)
Headers show
Series Prep series - CDCLK code churn | expand

Message

Srivatsa, Anusha Oct. 21, 2022, 12:20 a.m. UTC
No functional changes. The series is more of a prep series
for the mid_cdclk_config series:
https://patchwork.freedesktop.org/series/109694/

Main change:
 - Change usage of "crawler" and "squasher". Use crawling and
squashing instead.
 - Handle bot hsquash and cralw similar in terms of checking
if the platform supports them or not. With the changes introduced,
both are a display feature flag.
 - Move code from bxt_set_cdclk() to make it more modularized
and easy to read and understand.

Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>

Anusha Srivatsa (4):
  drm/i915/display: Change terminology for cdclk actions
  drm/i915/display: Introduce HAS_CDCLK_SQUASH macro
  drm/i915/display: Move chunks of code out of bxt_set_cdclk()
  drm/i915/display: Move squash_ctl register programming to its own
    function

 drivers/gpu/drm/i915/display/intel_cdclk.c | 80 ++++++++++++----------
 drivers/gpu/drm/i915/i915_drv.h            |  1 +
 drivers/gpu/drm/i915/i915_pci.c            |  1 +
 drivers/gpu/drm/i915/intel_device_info.h   |  1 +
 4 files changed, 48 insertions(+), 35 deletions(-)

Comments

Vivekanandan, Balasubramani Oct. 21, 2022, 7:06 a.m. UTC | #1
On 20.10.2022 17:20, Anusha Srivatsa wrote:
> No functional changes. The series is more of a prep series
> for the mid_cdclk_config series:
> https://patchwork.freedesktop.org/series/109694/
> 
> Main change:
>  - Change usage of "crawler" and "squasher". Use crawling and
> squashing instead.
>  - Handle bot hsquash and cralw similar in terms of checking
Please check the typos here

Regards,
Bala

> if the platform supports them or not. With the changes introduced,
> both are a display feature flag.
>  - Move code from bxt_set_cdclk() to make it more modularized
> and easy to read and understand.
> 
> Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
> 
> Anusha Srivatsa (4):
>   drm/i915/display: Change terminology for cdclk actions
>   drm/i915/display: Introduce HAS_CDCLK_SQUASH macro
>   drm/i915/display: Move chunks of code out of bxt_set_cdclk()
>   drm/i915/display: Move squash_ctl register programming to its own
>     function
> 
>  drivers/gpu/drm/i915/display/intel_cdclk.c | 80 ++++++++++++----------
>  drivers/gpu/drm/i915/i915_drv.h            |  1 +
>  drivers/gpu/drm/i915/i915_pci.c            |  1 +
>  drivers/gpu/drm/i915/intel_device_info.h   |  1 +
>  4 files changed, 48 insertions(+), 35 deletions(-)
> 
> -- 
> 2.25.1
>
Jani Nikula Oct. 21, 2022, 8:42 a.m. UTC | #2
On Fri, 21 Oct 2022, Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com> wrote:
> On 20.10.2022 17:20, Anusha Srivatsa wrote:
>> No functional changes. The series is more of a prep series
>> for the mid_cdclk_config series:
>> https://patchwork.freedesktop.org/series/109694/
>> 
>> Main change:
>>  - Change usage of "crawler" and "squasher". Use crawling and
>> squashing instead.
>>  - Handle bot hsquash and cralw similar in terms of checking
> Please check the typos here

This is a cover letter. It's not merged anywhere. It's not necessary to
point out typos here.

BR,
Jani.

>
> Regards,
> Bala
>
>> if the platform supports them or not. With the changes introduced,
>> both are a display feature flag.
>>  - Move code from bxt_set_cdclk() to make it more modularized
>> and easy to read and understand.
>> 
>> Cc: Balasubramani Vivekanandan <balasubramani.vivekanandan@intel.com>
>> Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>> 
>> Anusha Srivatsa (4):
>>   drm/i915/display: Change terminology for cdclk actions
>>   drm/i915/display: Introduce HAS_CDCLK_SQUASH macro
>>   drm/i915/display: Move chunks of code out of bxt_set_cdclk()
>>   drm/i915/display: Move squash_ctl register programming to its own
>>     function
>> 
>>  drivers/gpu/drm/i915/display/intel_cdclk.c | 80 ++++++++++++----------
>>  drivers/gpu/drm/i915/i915_drv.h            |  1 +
>>  drivers/gpu/drm/i915/i915_pci.c            |  1 +
>>  drivers/gpu/drm/i915/intel_device_info.h   |  1 +
>>  4 files changed, 48 insertions(+), 35 deletions(-)
>> 
>> -- 
>> 2.25.1
>>