mbox series

[v2,0/4] Improvements to GuC error capture

Message ID 20230428185636.457407-1-John.C.Harrison@Intel.com (mailing list archive)
Headers show
Series Improvements to GuC error capture | expand

Message

John Harrison April 28, 2023, 6:56 p.m. UTC 
From: John Harrison <John.C.Harrison@Intel.com>

The GuC error capture list creation was including Gen8 registers on Xe
platforms. While fixing that, it was noticed that there were other
issues. The platform naming was wrong, the naming of lists was
misleading, the steered register code was duplicated and steered
registers were not included on all supported platforms.

Separately, it was noticed that the capture list search was broken for
virtual engines. So fix that up too.

v2: Swuash the split patches into a single patch ready for merge.
Also include an extra patch about capture lists and virtual engines.

Signed-off-by: John Harrison <John.C.Harrison@Intel.com>


John Harrison (4):
  drm/i915/guc: Don't capture Gen8 regs on Xe devices
  drm/i915/guc: Consolidate duplicated capture list code
  drm/i915/guc: Capture list naming clean up
  drm/i915/guc: Fix error capture for virtual engines

 .../gpu/drm/i915/gt/uc/intel_guc_capture.c    | 242 ++++++++----------
 .../gpu/drm/i915/gt/uc/intel_guc_capture.h    |   3 +
 .../gpu/drm/i915/gt/uc/intel_guc_submission.c |  32 ++-
 drivers/gpu/drm/i915/i915_gpu_error.c         |  11 +-
 4 files changed, 149 insertions(+), 139 deletions(-)

Comments

John Harrison May 3, 2023, 6:25 p.m. UTC | #1 
On 4/28/2023 23:49, Patchwork wrote:
> Project List - Patchwork *Patch Details*
> *Series:* 	Improvements to GuC error capture
> *URL:* 	https://patchwork.freedesktop.org/series/117120/
> *State:* 	failure
> *Details:* 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/index.html
>
>
>   CI Bug Log - changes from CI_DRM_13074_full -> Patchwork_117120v1_full
>
>
>     Summary
>
> *FAILURE*
>
> Serious unknown changes coming with Patchwork_117120v1_full absolutely 
> need to be
> verified manually.
>
> If you think the reported changes have nothing to do with the changes
> introduced in Patchwork_117120v1_full, please notify your bug team to 
> allow them
> to document this new failure mode, which will reduce false positives 
> in CI.
>
>
>     Participating hosts (7 -> 8)
>
> Additional (1): shard-rkl0
>
>
>     Possible new issues
>
> Here are the unknown changes that may have been introduced in 
> Patchwork_117120v1_full:
>
>
>       IGT changes
>
>
>         Possible regressions
>
>   * igt@kms_flip@flip-vs-suspend-interruptible@a-dp1:
>       o shard-apl: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html>
>         -> ABORT
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible@a-dp1.html>
>
Display code went boom. Not related to error capture with GuC submission.

John.

>  *
>
>
>         Suppressed
>
> The following results come from untrusted machines, tests, or statuses.
> They do not affect the overall result.
>
>  *
>
>     igt@gem_ctx_freq@sysfs:
>
>       o {shard-dg1}: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-dg1-13/igt@gem_ctx_freq@sysfs.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-dg1-15/igt@gem_ctx_freq@sysfs.html>
>  *
>
>     igt@gem_exec_schedule@wide@vcs1:
>
>       o {shard-tglu}: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-tglu-10/igt@gem_exec_schedule@wide@vcs1.html>
>         -> INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-tglu-2/igt@gem_exec_schedule@wide@vcs1.html>
>
>
>     Known issues
>
> Here are the changes found in Patchwork_117120v1_full that come from 
> known issues:
>
>
>       IGT changes
>
>
>         Issues hit
>
>  *
>
>     igt@i915_selftest@live@dmabuf:
>
>       o shard-apl: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-apl4/igt@i915_selftest@live@dmabuf.html>
>         -> DMESG-FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-apl4/igt@i915_selftest@live@dmabuf.html>
>         (i915#7562 <https://gitlab.freedesktop.org/drm/intel/issues/7562>)
>  *
>
>     igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions:
>
>       o shard-glk: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-glk6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-glk3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions.html>
>         (i915#2346 <https://gitlab.freedesktop.org/drm/intel/issues/2346>)
>  *
>
>     igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size:
>
>       o shard-apl: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-apl3/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-apl6/igt@kms_cursor_legacy@flip-vs-cursor-atomic-transitions-varying-size.html>
>         (i915#2346 <https://gitlab.freedesktop.org/drm/intel/issues/2346>)
>  *
>
>     igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2:
>
>       o shard-glk: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-glk8/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-glk4/igt@kms_flip@2x-flip-vs-expired-vblank@bc-hdmi-a1-hdmi-a2.html>
>         (i915#79 <https://gitlab.freedesktop.org/drm/intel/issues/79>)
>  *
>
>     igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1:
>
>       o shard-apl: PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-apl7/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html>
>         -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-apl4/igt@kms_flip@flip-vs-expired-vblank-interruptible@b-dp1.html>
>         (i915#79 <https://gitlab.freedesktop.org/drm/intel/issues/79>)
>         +2 similar issues
>  *
>
>     igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1:
>
>       o shard-snb: NOTRUN -> SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-snb1/igt@kms_plane_scaling@planes-downscale-factor-0-25-upscale-0-25@pipe-a-hdmi-a-1.html>
>         (fdo#109271
>         <https://bugs.freedesktop.org/show_bug.cgi?id=109271>) +33
>         similar issues
>  *
>
>     igt@kms_setmode@basic@pipe-a-vga-1:
>
>       o shard-snb: NOTRUN -> FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-snb4/igt@kms_setmode@basic@pipe-a-vga-1.html>
>         (i915#5465
>         <https://gitlab.freedesktop.org/drm/intel/issues/5465>) +1
>         similar issue
>
>
>         Possible fixes
>
>  *
>
>     igt@gem_exec_balancer@hang:
>
>       o {shard-dg1}: DMESG-WARN
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-dg1-17/igt@gem_exec_balancer@hang.html>
>         (i915#8150
>         <https://gitlab.freedesktop.org/drm/intel/issues/8150>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-dg1-12/igt@gem_exec_balancer@hang.html>
>  *
>
>     igt@gem_exec_fair@basic-pace-solo@rcs0:
>
>       o shard-apl: FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-apl1/igt@gem_exec_fair@basic-pace-solo@rcs0.html>
>         (i915#2842
>         <https://gitlab.freedesktop.org/drm/intel/issues/2842>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-apl3/igt@gem_exec_fair@basic-pace-solo@rcs0.html>
>  *
>
>     igt@gem_exec_suspend@basic-s4-devices@lmem0:
>
>       o {shard-dg1}: ABORT
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-dg1-14/igt@gem_exec_suspend@basic-s4-devices@lmem0.html>
>         (i915#7975
>         <https://gitlab.freedesktop.org/drm/intel/issues/7975> /
>         i915#8213
>         <https://gitlab.freedesktop.org/drm/intel/issues/8213>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-dg1-17/igt@gem_exec_suspend@basic-s4-devices@lmem0.html>
>  *
>
>     igt@gem_ppgtt@blt-vs-render-ctx0:
>
>       o shard-snb: DMESG-FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-snb6/igt@gem_ppgtt@blt-vs-render-ctx0.html>
>         (i915#8295
>         <https://gitlab.freedesktop.org/drm/intel/issues/8295>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-snb1/igt@gem_ppgtt@blt-vs-render-ctx0.html>
>  *
>
>     igt@i915_pm_rpm@modeset-non-lpsp-stress:
>
>       o {shard-rkl}: SKIP
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-rkl-7/igt@i915_pm_rpm@modeset-non-lpsp-stress.html>
>         (i915#1397
>         <https://gitlab.freedesktop.org/drm/intel/issues/1397>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-rkl-1/igt@i915_pm_rpm@modeset-non-lpsp-stress.html>
>  *
>
>     igt@kms_cursor_legacy@forked-bo@pipe-b:
>
>       o {shard-rkl}: INCOMPLETE
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-rkl-7/igt@kms_cursor_legacy@forked-bo@pipe-b.html>
>         (i915#8011
>         <https://gitlab.freedesktop.org/drm/intel/issues/8011>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-rkl-1/igt@kms_cursor_legacy@forked-bo@pipe-b.html>
>  *
>
>     igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-2:
>
>       o {shard-rkl}: ABORT
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-rkl-6/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-2.html>
>         (i915#8311
>         <https://gitlab.freedesktop.org/drm/intel/issues/8311>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-rkl-2/igt@kms_plane_scaling@plane-upscale-with-modifiers-factor-0-25@pipe-b-hdmi-a-2.html>
>  *
>
>     igt@perf_pmu@idle@rcs0:
>
>       o {shard-rkl}: FAIL
>         <https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13074/shard-rkl-7/igt@perf_pmu@idle@rcs0.html>
>         (i915#4349
>         <https://gitlab.freedesktop.org/drm/intel/issues/4349>) ->
>         PASS
>         <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_117120v1/shard-rkl-1/igt@perf_pmu@idle@rcs0.html>
>
> {name}: This element is suppressed. This means it is ignored when 
> computing
> the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>
>     Build changes
>
>   * Linux: CI_DRM_13074 -> Patchwork_117120v1
>
> CI-20190529: 20190529
> CI_DRM_13074: 29e53d3ca48aa5fcb6bcf8d1624c829b7838e242 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> IGT_7277: 1cb3507f3ff28d11bd5cfabcde576fe78ddab571 @ 
> https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> Patchwork_117120v1: 29e53d3ca48aa5fcb6bcf8d1624c829b7838e242 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
> piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ 
> git://anongit.freedesktop.org/piglit
>