From patchwork Wed Aug 23 10:47:29 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suraj Kandpal X-Patchwork-Id: 13362120 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4C93EEE49B2 for ; Wed, 23 Aug 2023 10:49:44 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 284E710E080; Wed, 23 Aug 2023 10:49:43 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 314CF10E07E for ; Wed, 23 Aug 2023 10:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1692787780; x=1724323780; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=G4/rhDR+eQwQHeP8HiodGARsKcD9nxkm9Ia0F+W/kLg=; b=eFBXhYqBbRAZU+Z4+fuwFoaaRPRXJY3mOHQh2puem4eoAuUPA0iDHXiv 43pNL69on8y22pNyxbPgUBqbhpooatdynWgb51QQM230WSeKr5aIpjBb1 H3H8t6KNn8OSCZHRpl26KXtEXyhQe6v/Esclv25L37lUeRGSGRwe+S8iz o0LrJuYYfpa6+lODs/BfA8Y/8R/EZxMYyCXipnu9lmIGKuWQb7m1Xs8W4 vv4YwTgxSMNmMWAY7ipdyAkQfcljwhhEtO9iR7fjm2ixOdIoe8/1G9F2H kuK+wwCKo5UrQqO4AQUiVikrnbDhvHAvlz6oOBtu9Vm3HDAp7j6MpqeCy A==; X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="376856947" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="376856947" Received: from fmsmga007.fm.intel.com ([10.253.24.52]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 23 Aug 2023 03:49:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10810"; a="739730169" X-IronPort-AV: E=Sophos;i="6.01,195,1684825200"; d="scan'208";a="739730169" Received: from kandpal-x299-ud4-pro.iind.intel.com ([10.190.239.32]) by fmsmga007.fm.intel.com with ESMTP; 23 Aug 2023 03:49:27 -0700 From: Suraj Kandpal To: intel-gfx@lists.freedesktop.org Date: Wed, 23 Aug 2023 16:17:29 +0530 Message-Id: <20230823104736.495930-1-suraj.kandpal@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v11 0/8] Add DSC PPS readout X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Jani Nikula Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Up until now we only verified one or two of the dsc pps params like bits_per_component and bits_per_pixel this patch series aim to readout almost all PPS param and get them compared. Along with that some work on making a common function to read and write PPS param regiters is also done. --v2 -Remove duplicated code and create function that fetches register and reuse that. [Jani] -move WARN_ON one abstraction layer up. [Jani] -Split patch so that refactor and a new functionality is not added in the same patch. [Jani] -Add a new refactor patch so that bit shifting can be done in a clean way. [Jani] --v3 -Fix the typo in patch 2 [Jani] -Get both dsc_reg regardless of dsc_eng_no. [Jani] -Remove usage of num_vdsc_instances. [Ankit] -Add macro to further optimize intel_dsc_get_pps_reg --v4 -Manipulate register addresses rather than creating a macro to manipulate variable name based on pps [Ankit] --v5 -Use an array to fill the dsc registers instead of individual register [Ankit] -Get only dsc register that are required. --v6 -make intel_get_no_vdsc_inst_per_pipe func static --v7 -shorten func name for getting vdsc instances per pipe [Ankit] -send no vdsc instances to dsc read and write reg funcs [Ankit] --v8 -remove array dynamic allocation for dsc_reg [Jani] -no need for an array to just verify dsc engine values [Jani] -remove no_ from no_vdsc_per_pipe and wherever else it is applicable [Ankit] --v9 -change variable name to dsc_reg_size in intel_get_pps_reg [Ankit] -send ARRAY_SIZE(dsc_reg) in intel_dsc_write_pps_reg [Ankit] --v11 -add _ prefix to vdsc reg not be directly used [Jani] -remove _REG suffix from register macros [Jani] -do not register read in intel_dsc_read_pps_reg [Jani] Signed-off-by: Suraj Kandpal Acked-by: Jani Nikula Suraj Kandpal (8): drm/i915/vdsc: Refactor dsc register field macro drm/i915/vdsc: Add a check for dsc split cases drm/i915/vdsc: Add func to get no. of vdsc instances per pipe drm/i915/vdsc: Add function to read any PPS register drm/i915/vdsc: Add function to write in PPS register drm/i915/vdsc: Remove unused dsc registers drm/i915/vdsc: Fill the intel_dsc_get_pps_config function drm/i915/display: Compare the readout dsc pps params drivers/gpu/drm/i915/display/intel_display.c | 31 ++ drivers/gpu/drm/i915/display/intel_vdsc.c | 474 ++++++++---------- .../gpu/drm/i915/display/intel_vdsc_regs.h | 365 ++++---------- 3 files changed, 345 insertions(+), 525 deletions(-)