[v4,0/4] drm/i915/tc: some clean-ups in max lane count handling code

Message

Luca Coelho Aug. 25, 2023, 8:16 a.m. UTC

Hi,

Here are four patches with some clean-ups in the code that handles the
max lane count of Type-C connections.

This is done mostly in preparation for a new way to read the pin
assignments and lane count in future devices.

In v2:
   * Fix some rebasing damage.

In v3:
   * Fixed "assigment" typo, as reported by checkpatch.

In v4:
   * Rebased;
   * Renamed port_max to lane_max (Lucas' comment).

Please review.

Cheers,
Luca.


Luca Coelho (4):
  drm/i915/tc: rename mtl_tc_port_get_pin_assignment_mask()
  drm/i915/tc: make intel_tc_port_get_lane_mask() static
  drm/i915/tc: move legacy code out of the main _max_lane_count() func
  drm/i915/tc: remove "fia" from intel_tc_port_fia_max_lane_count()

 drivers/gpu/drm/i915/display/intel_cx0_phy.c |  2 +-
 drivers/gpu/drm/i915/display/intel_dp.c      |  4 +--
 drivers/gpu/drm/i915/display/intel_tc.c      | 38 +++++++++++---------
 drivers/gpu/drm/i915/display/intel_tc.h      |  3 +-
 4 files changed, 26 insertions(+), 21 deletions(-)

Comments

Lucas De Marchi Sept. 6, 2023, 2:49 a.m. UTC | #1

On Fri, Aug 25, 2023 at 11:16:34AM +0300, Luca Coelho wrote:
>Hi,
>
>Here are four patches with some clean-ups in the code that handles the
>max lane count of Type-C connections.
>
>This is done mostly in preparation for a new way to read the pin
>assignments and lane count in future devices.
>
>In v2:
>   * Fix some rebasing damage.
>
>In v3:
>   * Fixed "assigment" typo, as reported by checkpatch.
>
>In v4:
>   * Rebased;
>   * Renamed port_max to lane_max (Lucas' comment).
>
>Please review.

All patches are reviewed. I looked to the CI results and none of the
regressions seem related.

Pushed. Thanks

Lucas De Marchi

Luca Coelho Sept. 6, 2023, 6:28 a.m. UTC | #2

On Tue, 2023-09-05 at 19:49 -0700, Lucas De Marchi wrote:
> On Fri, Aug 25, 2023 at 11:16:34AM +0300, Luca Coelho wrote:
> > Hi,
> > 
> > Here are four patches with some clean-ups in the code that handles the
> > max lane count of Type-C connections.
> > 
> > This is done mostly in preparation for a new way to read the pin
> > assignments and lane count in future devices.
> > 
> > In v2:
> >   * Fix some rebasing damage.
> > 
> > In v3:
> >   * Fixed "assigment" typo, as reported by checkpatch.
> > 
> > In v4:
> >   * Rebased;
> >   * Renamed port_max to lane_max (Lucas' comment).
> > 
> > Please review.
> 
> All patches are reviewed. I looked to the CI results and none of the
> regressions seem related.
> 
> Pushed. Thanks

Great, thanks for checking and pushing, Lucas!

--
Cheers,
Luca.