| Message ID | 20230828192852.2894671-1-jonathan.cavitt@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915/gt: Wait longer for tasks in migrate selftest | expand |
> Possible regressions > > • igt@kms_pipe_crc_basic@nonblocking-crc@pipe-c-dp-6: > □ bat-adlp-11: NOTRUN -> FAIL mmmhhh... this failure doesn't look related. Would you mind restarting the tests? Andi
The thread_global_copy subtest of the live migrate selftest creates a large number of threads and waits 10ms for them all to start. This is not enough time to wait for the threaded tasks to start, as some may need to wait for additional ring space to be granted. Threads that do so are at risk of getting stopped (signaled) in the middle of waiting for additional space, which can result in ERESTARTSYS getting reported erroneously by i915_request_wait. Instead of waiting a flat 10ms for the threads to start, wait 10ms per thread. This grants enough of a buffer for each thread to wait for additional ring space when needed. Signed-off-by: Jonathan Cavitt <jonathan.cavitt@intel.com> CC: Chris Wilson <chris.p.wilson@linux.intel.com> CC: Andi Shyti <andi.shyti@intel.com> Jonathan Cavitt (1): drm/i915/gt: Wait longer for tasks in migrate selftest drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)