From patchwork Thu Sep 21 18:37:27 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Cavitt, Jonathan" X-Patchwork-Id: 13394310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 47D24E7D0A4 for ; Thu, 21 Sep 2023 18:48:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A738910E5E9; Thu, 21 Sep 2023 18:48:15 +0000 (UTC) Received: from mgamail.intel.com (mgamail.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9A08F10E31A for ; Thu, 21 Sep 2023 18:48:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1695322092; x=1726858092; h=from:to:cc:subject:date:message-id:mime-version: content-transfer-encoding; bh=0fDck/0I9q1vXTKSyks0IJGBzZ+EfTHHOQ5zniV+zRg=; b=iyOM2wkjJ++KwI9uhyakDe9yksNyU49y6h7WK2H1dH05FgkiaRPTGCok HEqDK5qvp+gEzcLaTOG7+3WrC5SjCsxSdt07SaMfLk1N4SN/ZfZpXOjLb b+1hWLNJSMHAGBdrwesA4ChzUYNrFMJH5w8gw+VA4iaxb4ReDiiyFWMML uEE8Get/JmQybNzSeKJFbxIQI+aFvpAa/ItVqlCjC0zQnHQiipe2IEKox OHsYRqyswYRELiuxSJ4HcM06tx+yg7jf527nJCAwEdLSaZYF8VZuEeid0 yh1vjXuNwBMb4OCcIEvQO/mNr2McN34yv7ABwW1tcpy6Y6Od7J5pcmXPD g==; X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="383381493" X-IronPort-AV: E=Sophos;i="6.03,166,1694761200"; d="scan'208";a="383381493" Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 11:48:12 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6600,9927,10840"; a="817513082" X-IronPort-AV: E=Sophos;i="6.03,166,1694761200"; d="scan'208";a="817513082" Received: from dut-internal-9dd7.jf.intel.com ([10.165.21.194]) by fmsmga004-auth.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 21 Sep 2023 11:48:11 -0700 From: Jonathan Cavitt To: intel-gfx@lists.freedesktop.org Date: Thu, 21 Sep 2023 11:37:27 -0700 Message-Id: <20230921183729.3763860-1-jonathan.cavitt@intel.com> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 Subject: [Intel-gfx] [PATCH v13 0/2] Apply Wa_16018031267 / Wa_16018063123 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: andi.shyti@intel.com, chris.p.wilson@linux.intel.com, tomasz.mistat@intel.com, jonathan.cavitt@intel.com, rodrigo.vivi@intel.com, gregory.f.germano@intel.com, matthew.d.roper@intel.com, nirmoy.das@intel.com Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Apply Wa_16018031267 / Wa_16018063123. This necessitates submitting a fastcolor blit as WABB and setting the copy engine arbitration to round-robin mode. v2: - Rename old platform check in second patch to match declaration in first patch. - Refactor second patch name to match first patch. v3: - Move NEEDS_FASTCOLOR_BLT_WABB to intel_gt.h. - Refactor NEEDS_FASTCOLOR_BLT_WABB to make it more streamlined to use. - Stop dividing PAGE_SIZE by sizeof(u32) when computing ctx_bb_ggtt_addr for lrc_setup_bb_per_ctx. - Reduce comment complexity. - Fix several checkpatch warnings. v4: - Actually stop dividing PAGE_SIZE by sizeof(u32) when computing ctx_bb_ggtt_addr for lrc_setup_bb_per_ctx. v5: - Stop dividing PAGE_SIZE by sizeof(u32) in check_ring_start during lrc live selftest. v6: - Append MI_BATCH_BUFFER_END to end of all PER_CTX_BB command streams. - No longer skip on empty, as command stream will never be empty (always contains at least MI_BATCH_BUFFER_END). - No longer append MI_NOOP until cachline aligned (was a fragment from INDIRECT_CTX setup). v7: - Use 0x6b instead of 0 for color to maintain functionality. v8: - Revert v7. - Add some reserved kernel space per vm to run the workaround on. v9: - Hide reserved kernel space per vm from userspace. v10: - Revert v7 properly. - Test on updated IGT. v11: - Remove Test-with tag. - Reserve two pages per vm for workaround. v12: - Use Null page for scratch page. v13: - Revert changes the reserve vm space explicitly. - Create dummy context. - Use dummy context for workaround. Signed-off-by: Nirmoy Das Signed-off-by: Jonathan Cavitt CC: Joonas Lahtinen CC: Rodrigo Vivi CC: Tomasz Mistat CC: Gregory F Germano CC: Matt Roper CC: James Ausmus CC: Chris Wilson CC: Andi Shyti Jonathan Cavitt (2): drm/i915: Add WABB blit for Wa_16018031267 / Wa_16018063123 drm/i915: Set copy engine arbitration for Wa_16018031267 / Wa_16018063123 drivers/gpu/drm/i915/gt/intel_context.h | 9 ++ drivers/gpu/drm/i915/gt/intel_context_types.h | 1 + drivers/gpu/drm/i915/gt/intel_engine.h | 2 + drivers/gpu/drm/i915/gt/intel_engine_cs.c | 48 +++++++++ drivers/gpu/drm/i915/gt/intel_engine_regs.h | 6 ++ drivers/gpu/drm/i915/gt/intel_engine_types.h | 1 + drivers/gpu/drm/i915/gt/intel_gt.h | 4 + drivers/gpu/drm/i915/gt/intel_lrc.c | 101 +++++++++++++++++- drivers/gpu/drm/i915/gt/intel_workarounds.c | 5 + drivers/gpu/drm/i915/gt/selftest_lrc.c | 65 +++++++---- .../gpu/drm/i915/gt/uc/intel_guc_submission.c | 13 ++- .../gpu/drm/i915/gt/uc/intel_guc_submission.h | 1 + 12 files changed, 232 insertions(+), 24 deletions(-)