mbox series

[v3,0/6] drm/i915: Bigjoiner modeset sequence redesign and MST support

Message ID 20240409163502.29633-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915: Bigjoiner modeset sequence redesign and MST support | expand

Message

Ville Syrjala April 9, 2024, 4:34 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Final pieces of the MST/bigjoiner modedest redesign.

Changes in v2:
- Reject PSR+bigjoiner combo
- Commit pipes in reverse order to avoid issues with
  slave pipe commits being completed prematurely.
  Should fix the gamma/DSB problems of v1.
- Address review comments
- Part of v1 was merged already separately

Changes in v3:
- Fix a rebase fail in function extraction
- Calculate DSC slices correctly for MST+bigjoiner (Imre)
- Most of v2 already merged

Stanislav Lisovskiy (1):
  drm/i915: Handle joined pipes inside hsw_crtc_enable()

Vidya Srinivas (1):
  drm/i915: Allow bigjoiner for MST

Ville Syrjälä (4):
  drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst()
  drm/i915: Utilize intel_crtc_joined_pipe_mask() more
  drm/i915: Handle joined pipes inside hsw_crtc_disable()
  drm/i915/mst: Add bigjoiner handling to MST modeset sequence

 drivers/gpu/drm/i915/display/intel_ddi.c     |  67 +++--
 drivers/gpu/drm/i915/display/intel_display.c | 252 ++++++++++---------
 drivers/gpu/drm/i915/display/intel_display.h |   6 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c  |  62 +++--
 4 files changed, 228 insertions(+), 159 deletions(-)

Comments

Ville Syrjala April 10, 2024, 2:34 p.m. UTC | #1
On Tue, Apr 09, 2024 at 06:12:09PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)
> URL   : https://patchwork.freedesktop.org/series/131797/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_14550 -> Patchwork_131797v4
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_131797v4 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_131797v4, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131797v4/index.html
> 
> Participating hosts (36 -> 36)
> ------------------------------
> 
>   Additional (4): bat-kbl-2 bat-dg2-11 fi-kbl-8809g fi-bsw-n3050 
>   Missing    (4): bat-arls-4 bat-dg1-7 bat-atsm-1 bat-mtlp-8 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_131797v4:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_selftest@live@active:
>     - bat-jsl-1:          [PASS][1] -> [DMESG-FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14550/bat-jsl-1/igt@i915_selftest@live@active.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131797v4/bat-jsl-1/igt@i915_selftest@live@active.html

<6> [396.898275] i915: Running i915_active_live_selftests/live_active_wait
<3> [396.902316] i915 0000:00:02.0: [drm] *ERROR* live_active_wait i915_active not retired after waiting!
<3> [396.902334] i915 0000:00:02.0: [drm] *ERROR* live_active_wait active __live_active [i915]:__live_retire [i915]
<3> [396.903434] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	count: 0
<3> [396.903443] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	preallocated barriers? no
<3> [396.904085] i915/i915_active_live_selftests: live_active_wait failed with error -22

Looks very much unrelated to these changes. Please wave this one through.
Ville Syrjala April 10, 2024, 3:36 p.m. UTC | #2
On Wed, Apr 10, 2024 at 05:34:13PM +0300, Ville Syrjälä wrote:
> On Tue, Apr 09, 2024 at 06:12:09PM -0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)
> > URL   : https://patchwork.freedesktop.org/series/131797/
> > State : failure
> > 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_14550 -> Patchwork_131797v4
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_131797v4 absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_131797v4, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131797v4/index.html
> > 
> > Participating hosts (36 -> 36)
> > ------------------------------
> > 
> >   Additional (4): bat-kbl-2 bat-dg2-11 fi-kbl-8809g fi-bsw-n3050 
> >   Missing    (4): bat-arls-4 bat-dg1-7 bat-atsm-1 bat-mtlp-8 
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in Patchwork_131797v4:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@i915_selftest@live@active:
> >     - bat-jsl-1:          [PASS][1] -> [DMESG-FAIL][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14550/bat-jsl-1/igt@i915_selftest@live@active.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131797v4/bat-jsl-1/igt@i915_selftest@live@active.html
> 
> <6> [396.898275] i915: Running i915_active_live_selftests/live_active_wait
> <3> [396.902316] i915 0000:00:02.0: [drm] *ERROR* live_active_wait i915_active not retired after waiting!
> <3> [396.902334] i915 0000:00:02.0: [drm] *ERROR* live_active_wait active __live_active [i915]:__live_retire [i915]
> <3> [396.903434] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	count: 0
> <3> [396.903443] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	preallocated barriers? no
> <3> [396.904085] i915/i915_active_live_selftests: live_active_wait failed with error -22
> 
> Looks very much unrelated to these changes. Please wave this one through.

Looks like https://gitlab.freedesktop.org/drm/intel/-/issues/10606
Illipilli, TejasreeX April 11, 2024, 7:07 a.m. UTC | #3
Hi,

https://patchwork.freedesktop.org/series/131797/ - Re-reported.

Thanks,
Tejasree

-----Original Message-----
From: I915-ci-infra <i915-ci-infra-bounces@lists.freedesktop.org> On Behalf Of Ville Syrjälä
Sent: Wednesday, April 10, 2024 8:04 PM
To: intel-gfx@lists.freedesktop.org
Cc: I915-ci-infra@lists.freedesktop.org
Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)

On Tue, Apr 09, 2024 at 06:12:09PM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Bigjoiner modeset sequence redesign and MST support (rev4)
> URL   : https://patchwork.freedesktop.org/series/131797/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_14550 -> Patchwork_131797v4 
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_131797v4 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_131797v4, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131797v4/index.html
> 
> Participating hosts (36 -> 36)
> ------------------------------
> 
>   Additional (4): bat-kbl-2 bat-dg2-11 fi-kbl-8809g fi-bsw-n3050 
>   Missing    (4): bat-arls-4 bat-dg1-7 bat-atsm-1 bat-mtlp-8 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_131797v4:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_selftest@live@active:
>     - bat-jsl-1:          [PASS][1] -> [DMESG-FAIL][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14550/bat-jsl-1/igt@i915_selftest@live@active.html
>    [2]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_131797v4/bat-jsl-1/
> igt@i915_selftest@live@active.html

<6> [396.898275] i915: Running i915_active_live_selftests/live_active_wait
<3> [396.902316] i915 0000:00:02.0: [drm] *ERROR* live_active_wait i915_active not retired after waiting!
<3> [396.902334] i915 0000:00:02.0: [drm] *ERROR* live_active_wait active __live_active [i915]:__live_retire [i915]
<3> [396.903434] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	count: 0
<3> [396.903443] i915 0000:00:02.0: [drm] *ERROR* live_active_wait 	preallocated barriers? no
<3> [396.904085] i915/i915_active_live_selftests: live_active_wait failed with error -22

Looks very much unrelated to these changes. Please wave this one through.

--
Ville Syrjälä
Intel