mbox series

[v2,00/17] Panel Replay eDP support

Message ID 20240521084648.1987837-1-jouni.hogander@intel.com (mailing list archive)
Headers show
Series Panel Replay eDP support | expand

Message

Hogander, Jouni May 21, 2024, 8:46 a.m. UTC
This patch set is implementing eDP1.5 Panel Replay for Intel hw. Also
Region Early Transport information is added into debugfs interface
and patch to disable Region Early Transport by default is reverted as
it is needed by eDP Panel Replay.

v2:
  - printout "Selective Update enabled (Early Transport)" instead of
    "Selective Update Early Transport enabled"
  - ensure that fastset is performed when the disable bit changes

Jouni Högander (17):
  drm/i915/psr: Store pr_dpcd in intel_dp
  drm/panel replay: Add edp1.5 Panel Replay bits and register
  drm/i915/psr: Move printing sink PSR support to own function
  drm/i915/psr: Move printing PSR mode to own function
  drm/i915/psr: modify psr status debugfs to support eDP Panel Replay
  drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid
  drm/i915/psr: Add Early Transport into psr debugfs interface
  drm/display: Add missing aux less alpm wake related bits
  drm/i915/psr: Check panel ALPM capability for eDP Panel Replay
  drm/i915/psr: Inform Panel Replay source support on eDP as well
  drm/i915/psr: enable sink for eDP1.5 Panel Replay
  drm/i915/psr: Check panel Early Transport capability for eDP PR
  drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel Replay
  drm/i915/psr: Check Early Transport for Panel Replay as well
  drm/i915/psr: Modify dg2_activate_panel_replay to support eDP
  drm/i915/psr: Add new debug bit to disable Panel Replay
  Revert "drm/i915/psr: Disable early transport by default"

 .../drm/i915/display/intel_display_types.h    |   2 +
 drivers/gpu/drm/i915/display/intel_psr.c      | 294 ++++++++++++------
 include/drm/display/drm_dp.h                  |  19 +-
 3 files changed, 213 insertions(+), 102 deletions(-)

Comments

Manna, Animesh May 24, 2024, 5:53 a.m. UTC | #1
> -----Original Message-----
> From: Hogander, Jouni <jouni.hogander@intel.com>
> Sent: Tuesday, May 21, 2024 2:17 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: Manna, Animesh <animesh.manna@intel.com>; Kahola, Mika
> <mika.kahola@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
> Subject: [PATCH v2 00/17] Panel Replay eDP support
> 
> This patch set is implementing eDP1.5 Panel Replay for Intel hw. Also Region
> Early Transport information is added into debugfs interface and patch to
> disable Region Early Transport by default is reverted as it is needed by eDP
> Panel Replay.
> 
> v2:
>   - printout "Selective Update enabled (Early Transport)" instead of
>     "Selective Update Early Transport enabled"
>   - ensure that fastset is performed when the disable bit changes
> 
> Jouni Högander (17):
>   drm/i915/psr: Store pr_dpcd in intel_dp
>   drm/panel replay: Add edp1.5 Panel Replay bits and register
>   drm/i915/psr: Move printing sink PSR support to own function
>   drm/i915/psr: Move printing PSR mode to own function
>   drm/i915/psr: modify psr status debugfs to support eDP Panel Replay
>   drm/i915/psr: Add Panel Replay support to intel_psr2_config_et_valid
>   drm/i915/psr: Add Early Transport into psr debugfs interface
>   drm/display: Add missing aux less alpm wake related bits
>   drm/i915/psr: Check panel ALPM capability for eDP Panel Replay
>   drm/i915/psr: Inform Panel Replay source support on eDP as well
>   drm/i915/psr: enable sink for eDP1.5 Panel Replay
>   drm/i915/psr: Check panel Early Transport capability for eDP PR
>   drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel Replay
>   drm/i915/psr: Check Early Transport for Panel Replay as well
>   drm/i915/psr: Modify dg2_activate_panel_replay to support eDP
>   drm/i915/psr: Add new debug bit to disable Panel Replay
>   Revert "drm/i915/psr: Disable early transport by default"

Some restrictions we may have to add for before enabling eDP Panel Replay.
1. With HDCP enable cannot enable panel replay.
2. With 8b/10b encoding only panel replay can be supported, not for 128b/132b encoding.

Regards,
Animesh
> 
>  .../drm/i915/display/intel_display_types.h    |   2 +
>  drivers/gpu/drm/i915/display/intel_psr.c      | 294 ++++++++++++------
>  include/drm/display/drm_dp.h                  |  19 +-
>  3 files changed, 213 insertions(+), 102 deletions(-)
> 
> --
> 2.34.1
Hogander, Jouni May 24, 2024, 7:03 a.m. UTC | #2
On Fri, 2024-05-24 at 05:53 +0000, Manna, Animesh wrote:
> 
> 
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander@intel.com>
> > Sent: Tuesday, May 21, 2024 2:17 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Manna, Animesh <animesh.manna@intel.com>; Kahola, Mika
> > <mika.kahola@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
> > Subject: [PATCH v2 00/17] Panel Replay eDP support
> > 
> > This patch set is implementing eDP1.5 Panel Replay for Intel hw.
> > Also Region
> > Early Transport information is added into debugfs interface and
> > patch to
> > disable Region Early Transport by default is reverted as it is
> > needed by eDP
> > Panel Replay.
> > 
> > v2:
> >   - printout "Selective Update enabled (Early Transport)" instead
> > of
> >     "Selective Update Early Transport enabled"
> >   - ensure that fastset is performed when the disable bit changes
> > 
> > Jouni Högander (17):
> >   drm/i915/psr: Store pr_dpcd in intel_dp
> >   drm/panel replay: Add edp1.5 Panel Replay bits and register
> >   drm/i915/psr: Move printing sink PSR support to own function
> >   drm/i915/psr: Move printing PSR mode to own function
> >   drm/i915/psr: modify psr status debugfs to support eDP Panel
> > Replay
> >   drm/i915/psr: Add Panel Replay support to
> > intel_psr2_config_et_valid
> >   drm/i915/psr: Add Early Transport into psr debugfs interface
> >   drm/display: Add missing aux less alpm wake related bits
> >   drm/i915/psr: Check panel ALPM capability for eDP Panel Replay
> >   drm/i915/psr: Inform Panel Replay source support on eDP as well
> >   drm/i915/psr: enable sink for eDP1.5 Panel Replay
> >   drm/i915/psr: Check panel Early Transport capability for eDP PR
> >   drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel
> > Replay
> >   drm/i915/psr: Check Early Transport for Panel Replay as well
> >   drm/i915/psr: Modify dg2_activate_panel_replay to support eDP
> >   drm/i915/psr: Add new debug bit to disable Panel Replay
> >   Revert "drm/i915/psr: Disable early transport by default"
> 
> Some restrictions we may have to add for before enabling eDP Panel
> Replay.
> 1. With HDCP enable cannot enable panel replay.
> 2. With 8b/10b encoding only panel replay can be supported, not for
> 128b/132b encoding.

Yes, you are right. Thank you for pointing this out. I will add these.

> Regards,
> Animesh
> > 
> >  .../drm/i915/display/intel_display_types.h    |   2 +
> >  drivers/gpu/drm/i915/display/intel_psr.c      | 294 ++++++++++++--
> > ----
> >  include/drm/display/drm_dp.h                  |  19 +-
> >  3 files changed, 213 insertions(+), 102 deletions(-)
> > 
> > --
> > 2.34.1
>
Hogander, Jouni May 27, 2024, 7:24 a.m. UTC | #3
On Fri, 2024-05-24 at 05:53 +0000, Manna, Animesh wrote:
> 
> 
> > -----Original Message-----
> > From: Hogander, Jouni <jouni.hogander@intel.com>
> > Sent: Tuesday, May 21, 2024 2:17 PM
> > To: intel-gfx@lists.freedesktop.org
> > Cc: Manna, Animesh <animesh.manna@intel.com>; Kahola, Mika
> > <mika.kahola@intel.com>; Hogander, Jouni <jouni.hogander@intel.com>
> > Subject: [PATCH v2 00/17] Panel Replay eDP support
> > 
> > This patch set is implementing eDP1.5 Panel Replay for Intel hw.
> > Also Region
> > Early Transport information is added into debugfs interface and
> > patch to
> > disable Region Early Transport by default is reverted as it is
> > needed by eDP
> > Panel Replay.
> > 
> > v2:
> >   - printout "Selective Update enabled (Early Transport)" instead
> > of
> >     "Selective Update Early Transport enabled"
> >   - ensure that fastset is performed when the disable bit changes
> > 
> > Jouni Högander (17):
> >   drm/i915/psr: Store pr_dpcd in intel_dp
> >   drm/panel replay: Add edp1.5 Panel Replay bits and register
> >   drm/i915/psr: Move printing sink PSR support to own function
> >   drm/i915/psr: Move printing PSR mode to own function
> >   drm/i915/psr: modify psr status debugfs to support eDP Panel
> > Replay
> >   drm/i915/psr: Add Panel Replay support to
> > intel_psr2_config_et_valid
> >   drm/i915/psr: Add Early Transport into psr debugfs interface
> >   drm/display: Add missing aux less alpm wake related bits
> >   drm/i915/psr: Check panel ALPM capability for eDP Panel Replay
> >   drm/i915/psr: Inform Panel Replay source support on eDP as well
> >   drm/i915/psr: enable sink for eDP1.5 Panel Replay
> >   drm/i915/psr: Check panel Early Transport capability for eDP PR
> >   drm/i915/psr: Perfrom psr2 checks related to ALPM for Panel
> > Replay
> >   drm/i915/psr: Check Early Transport for Panel Replay as well
> >   drm/i915/psr: Modify dg2_activate_panel_replay to support eDP
> >   drm/i915/psr: Add new debug bit to disable Panel Replay
> >   Revert "drm/i915/psr: Disable early transport by default"
> 
> Some restrictions we may have to add for before enabling eDP Panel
> Replay.
> 1. With HDCP enable cannot enable panel replay.
> 2. With 8b/10b encoding only panel replay can be supported, not for
> 128b/132b encoding.

Thank you Animesh for your review. Just sent new version containing
changes suggested by you. Please check.

BR,

Jouni Högander

> 
> Regards,
> Animesh
> > 
> >  .../drm/i915/display/intel_display_types.h    |   2 +
> >  drivers/gpu/drm/i915/display/intel_psr.c      | 294 ++++++++++++--
> > ----
> >  include/drm/display/drm_dp.h                  |  19 +-
> >  3 files changed, 213 insertions(+), 102 deletions(-)
> > 
> > --
> > 2.34.1
>