From patchwork Thu Jun 13 10:20:17 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Sebastian Andrzej Siewior X-Patchwork-Id: 13696569 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7AFFAC2BA15 for ; Thu, 13 Jun 2024 10:28:31 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BA26810EA10; Thu, 13 Jun 2024 10:28:29 +0000 (UTC) Authentication-Results: gabe.freedesktop.org; dkim=pass (2048-bit key; secure) header.d=linutronix.de header.i=@linutronix.de header.b="xSdPVZXQ"; dkim=permerror (0-bit key) header.d=linutronix.de header.i=@linutronix.de header.b="wdFxaGRh"; dkim-atps=neutral Received: from galois.linutronix.de (Galois.linutronix.de [193.142.43.55]) by gabe.freedesktop.org (Postfix) with ESMTPS id 42C9210EA08; Thu, 13 Jun 2024 10:28:26 +0000 (UTC) From: Sebastian Andrzej Siewior DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1718274504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DXWKi7/fI2Bzg+nHWXwkNMX5JC0Mb24GuGI0J34THNk=; b=xSdPVZXQC/w3+TMjaFY9LNeL1WnHCWeYR5FC+xx/Jl1066L8n3leu371Cayyd0ttCo4sxE z/cspWCM9OJu7EL+EMSsd0GkoFVFc8i+kR0ZwrSIMCKjCZIBpsAaDy+UBWT/Y3ZB9M4jyO 54awbjAit72147q8HreEkglo8gxxOePrykGx56sPfnLpZqMqxVoFsn1KUhW53280w9XNio /7lxEpKA3KjACfm7u8t1anXZbQz4J4joLUkZz4P2eDVYKkJCgGAhS3OZuPE0KGlFKluCGn SogAmLx1co6m/1Le02xxd1FGGyyIXJnoLCms1HHXr2l3qTRUiLZJqElGE52UZw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1718274504; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=DXWKi7/fI2Bzg+nHWXwkNMX5JC0Mb24GuGI0J34THNk=; b=wdFxaGRhjhxVYLZQfEOKKIckoZCMkkpX11LTQtcWVV08Z33R5bdU16TZq1ZSHAeVA0TSfG /0wwd//z9hkogSAA== To: intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org Cc: Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Thomas Gleixner , Tvrtko Ursulin Subject: [PATCH v2 0/8] drm/i915: PREEMPT_RT related fixups. Date: Thu, 13 Jun 2024 12:20:17 +0200 Message-ID: <20240613102818.4056866-1-bigeasy@linutronix.de> MIME-Version: 1.0 X-BeenThere: intel-gfx@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel graphics driver community testing & development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" Hi, The following patches are from the PREEMPT_RT queue. It is mostly about disabling interrupts/preemption which leads to problems. Unfortunately DRM_I915_LOW_LEVEL_TRACEPOINTS had to be disabled because it acquires locks from within trace points. Making the lock a raw_spinlock_t led to higher latencies during video playback https://lore.kernel.org/all/20211006164628.s2mtsdd2jdbfyf7g@linutronix.de/ and I'm not sure if I hit the worse case here. I tested it on a SandyBridge with built-in i915 by using X, OpenGL and playing videos without noticing any warnings. However, some code paths were not entered. I carry them for some time now and most issues were reported by other people and they reported that things work for them since. v1…v2: - The tracing disable bits (4/8) have been reworked after Steven pointed out that something isn't right. - The irq_work() bits have been dropped because they are no longer needed.