| Message ID | 20240628164451.1177612-1-imre.deak@intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915: Dump DSC state to dmesg/debugfs | expand |
On Fri, 28 Jun 2024, Imre Deak <imre.deak@intel.com> wrote: > This is v2 of [1], renaming the helpers from drm_x16 to fxp_q4 as > suggested by Jani. > > [1] https://lore.kernel.org/all/20240614173911.3743172-1-imre.deak@intel.com > > Cc: Jani Nikula <jani.nikula@intel.com> No detailed review, but on the approach and naming, Acked-by: Jani Nikula <jani.nikula@intel.com> > > Imre Deak (9): > drm: Add helpers for q4 fixed point values > drm/display/dsc: Add a helper to dump the DSC configuration > drm/i915: Replace to_bpp_x16() with fxp_q4_from_int() > drm/i915: Replace to_bpp_int() with fxp_q4_to_int() > drm/i915: Replace to_bpp_int_roundup() with fxp_q4_to_int_roundup() > drm/i915: Replace to_bpp_frac() with fxp_q4_to_frac() > drm/i915: Replace BPP_X16_FMT()/ARGS() with FXP_Q4_FMT()/ARGS() > drm/i915: Dump DSC state to dmesg and debugfs/i915_display_info > drm/i915: Remove DSC register dump > > drivers/gpu/drm/display/drm_dp_helper.c | 5 +- > drivers/gpu/drm/display/drm_dsc_helper.c | 91 +++++++++++++++++++ > drivers/gpu/drm/i915/display/icl_dsi.c | 9 +- > drivers/gpu/drm/i915/display/intel_audio.c | 5 +- > drivers/gpu/drm/i915/display/intel_bios.c | 5 +- > drivers/gpu/drm/i915/display/intel_cdclk.c | 5 +- > .../drm/i915/display/intel_crtc_state_dump.c | 3 + > drivers/gpu/drm/i915/display/intel_display.c | 7 +- > .../drm/i915/display/intel_display_debugfs.c | 4 + > .../drm/i915/display/intel_display_types.h | 23 ----- > drivers/gpu/drm/i915/display/intel_dp.c | 51 ++++++----- > drivers/gpu/drm/i915/display/intel_dp_mst.c | 26 +++--- > drivers/gpu/drm/i915/display/intel_fdi.c | 6 +- > drivers/gpu/drm/i915/display/intel_link_bw.c | 4 +- > drivers/gpu/drm/i915/display/intel_vdsc.c | 51 ++++++----- > drivers/gpu/drm/i915/display/intel_vdsc.h | 4 + > include/drm/display/drm_dsc_helper.h | 3 + > include/drm/drm_fixed.h | 23 +++++ > 18 files changed, 222 insertions(+), 103 deletions(-)
On Tue, Jul 02, 2024 at 06:13:45PM +0000, Patchwork wrote: Hi CI team, the failure is unrelated to the changes, could you check the comments about it below? > == Series Details == > > Series: drm/i915: Dump DSC state to dmesg/debugfs (rev3) > URL : https://patchwork.freedesktop.org/series/134906/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_15013 -> Patchwork_134906v3 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_134906v3 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_134906v3, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/index.html > > Participating hosts (42 -> 39) > ------------------------------ > > Additional (1): bat-twl-2 > Missing (4): bat-adln-1 bat-jsl-3 fi-snb-2520m fi-elk-e7500 > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_134906v3: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@i915_selftest@live@execlists: > - fi-bsw-n3050: [PASS][1] -> [ABORT][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-bsw-n3050/igt@i915_selftest@live@execlists.html > [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/fi-bsw-n3050/igt@i915_selftest@live@execlists.html No display output is enabled/gets enabled until the above test, so the changes in this patch are unrelated to the failure. The test gets stuck in the middle of the above test: <6>[ 489.209589] i915: Running execlists ... <6>[ 491.829046] i915: Running intel_execlists_live_selftests/live_preempt_cancel <3>[ 554.835785] INFO: task systemd-udevd:5552 blocked for more than 61 seconds I found the following similar issues that happened on the same machine and test, though they happen a bit earlier in the subtest, so not sure if the root cause is the same: Trybot_135050v5/fi-bsw-n3050/0/dmesg.log: <6>[ 483.853300] i915: Running execlists <6>[ 483.853367] i915: Running intel_execlists_live_selftests/live_sanitycheck ... <6>[ 485.054414] i915: Running intel_execlists_live_selftests/live_timeslice_preempt <0>[ 521.003803] watchdog: BUG: soft lockup - CPU#0 stuck for 26s! [migration/0:18] Patchwork_135436v1/fi-bsw-n3050/0/dmesg.log <6>[ 486.659257] i915: Running execlists <6>[ 486.659355] i915: Running intel_execlists_live_selftests/live_sanitycheck ... <6>[ 487.845981] i915: Running intel_execlists_live_selftests/live_timeslice_preempt <0>[ 517.007302] watchdog: BUG: soft lockup - CPU#0 stuck for 26s! [migration/0:18] > * igt@i915_selftest@live@gem_migrate: > - bat-arlh-2: [PASS][3] -> [INCOMPLETE][4] > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-arlh-2/igt@i915_selftest@live@gem_migrate.html > [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-arlh-2/igt@i915_selftest@live@gem_migrate.html As above display outputs don't get enabled until the above happens (I assume no display is actually connected to it), so the changes in the patch are unrelated to the failure. The machine hang similarly earlier in the same test, though a different subtest, so the root cause could be something else: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14993/bat-arlh-2/igt@i915_selftest@live@evict.html > Known issues > ------------ > > Here are the changes found in Patchwork_134906v3 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@kms_chamelium_edid@dp-edid-read: > - bat-dg2-13: [PASS][5] -> [ABORT][6] ([i915#11552]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-dg2-13/igt@kms_chamelium_edid@dp-edid-read.html > [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-dg2-13/igt@kms_chamelium_edid@dp-edid-read.html > > * igt@kms_frontbuffer_tracking@basic: > - bat-arls-2: [PASS][7] -> [DMESG-WARN][8] ([i915#7507]) > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-arls-2/igt@kms_frontbuffer_tracking@basic.html > [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-arls-2/igt@kms_frontbuffer_tracking@basic.html > > > #### Possible fixes #### > > * igt@i915_selftest@live@gt_heartbeat: > - fi-kbl-7567u: [DMESG-WARN][9] ([i915#11328]) -> [PASS][10] +33 other tests pass > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html > [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html > > * igt@i915_selftest@live@workarounds: > - bat-dg2-11: [DMESG-FAIL][11] ([i915#9500]) -> [PASS][12] > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-dg2-11/igt@i915_selftest@live@workarounds.html > [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-dg2-11/igt@i915_selftest@live@workarounds.html > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209 > [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212 > [i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213 > [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214 > [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216 > [i915#11030]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11030 > [i915#11031]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11031 > [i915#11032]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11032 > [i915#11328]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11328 > [i915#11552]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11552 > [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708 > [i915#7507]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7507 > [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809 > [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318 > [i915#9500]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9500 > [i915#9886]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886 > > > Build changes > ------------- > > * Linux: CI_DRM_15013 -> Patchwork_134906v3 > > CI-20190529: 20190529 > CI_DRM_15013: 0318a12ff6fb8c321458aa2b373e9322896ee951 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_7906: ae91ba26f657bf11264f64bd2dc21f471a5d18f5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_134906v3: 0318a12ff6fb8c321458aa2b373e9322896ee951 @ git://anongit.freedesktop.org/gfx-ci/linux > > == Logs == > > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/index.html
On Mon, Jul 01, 2024 at 02:28:31PM +0300, Jani Nikula wrote: > On Fri, 28 Jun 2024, Imre Deak <imre.deak@intel.com> wrote: > > This is v2 of [1], renaming the helpers from drm_x16 to fxp_q4 as > > suggested by Jani. > > > > [1] https://lore.kernel.org/all/20240614173911.3743172-1-imre.deak@intel.com > > > > Cc: Jani Nikula <jani.nikula@intel.com> > > No detailed review, but on the approach and naming, > > Acked-by: Jani Nikula <jani.nikula@intel.com> Testing the patchset in CI shards is still pending, however based on the available BAT result, I pushed already the first two patches with your ack to drm-misc-next, thanks. > > Imre Deak (9): > > drm: Add helpers for q4 fixed point values > > drm/display/dsc: Add a helper to dump the DSC configuration > > drm/i915: Replace to_bpp_x16() with fxp_q4_from_int() > > drm/i915: Replace to_bpp_int() with fxp_q4_to_int() > > drm/i915: Replace to_bpp_int_roundup() with fxp_q4_to_int_roundup() > > drm/i915: Replace to_bpp_frac() with fxp_q4_to_frac() > > drm/i915: Replace BPP_X16_FMT()/ARGS() with FXP_Q4_FMT()/ARGS() > > drm/i915: Dump DSC state to dmesg and debugfs/i915_display_info > > drm/i915: Remove DSC register dump > > > > drivers/gpu/drm/display/drm_dp_helper.c | 5 +- > > drivers/gpu/drm/display/drm_dsc_helper.c | 91 +++++++++++++++++++ > > drivers/gpu/drm/i915/display/icl_dsi.c | 9 +- > > drivers/gpu/drm/i915/display/intel_audio.c | 5 +- > > drivers/gpu/drm/i915/display/intel_bios.c | 5 +- > > drivers/gpu/drm/i915/display/intel_cdclk.c | 5 +- > > .../drm/i915/display/intel_crtc_state_dump.c | 3 + > > drivers/gpu/drm/i915/display/intel_display.c | 7 +- > > .../drm/i915/display/intel_display_debugfs.c | 4 + > > .../drm/i915/display/intel_display_types.h | 23 ----- > > drivers/gpu/drm/i915/display/intel_dp.c | 51 ++++++----- > > drivers/gpu/drm/i915/display/intel_dp_mst.c | 26 +++--- > > drivers/gpu/drm/i915/display/intel_fdi.c | 6 +- > > drivers/gpu/drm/i915/display/intel_link_bw.c | 4 +- > > drivers/gpu/drm/i915/display/intel_vdsc.c | 51 ++++++----- > > drivers/gpu/drm/i915/display/intel_vdsc.h | 4 + > > include/drm/display/drm_dsc_helper.h | 3 + > > include/drm/drm_fixed.h | 23 +++++ > > 18 files changed, 222 insertions(+), 103 deletions(-) > > -- > Jani Nikula, Intel
Hi, https://patchwork.freedesktop.org/series/134906/ - re-reported. Thanks, Tejasree -----Original Message----- From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Imre Deak Sent: Wednesday, July 3, 2024 1:46 AM To: I915-ci-infra@lists.freedesktop.org Cc: intel-gfx@lists.freedesktop.org Subject: Re: ✗ Fi.CI.BAT: failure for drm/i915: Dump DSC state to dmesg/debugfs (rev3) On Tue, Jul 02, 2024 at 06:13:45PM +0000, Patchwork wrote: Hi CI team, the failure is unrelated to the changes, could you check the comments about it below? > == Series Details == > > Series: drm/i915: Dump DSC state to dmesg/debugfs (rev3) > URL : https://patchwork.freedesktop.org/series/134906/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_15013 -> Patchwork_134906v3 > ==================================================== > > Summary > ------- > > **FAILURE** > > Serious unknown changes coming with Patchwork_134906v3 absolutely need to be > verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_134906v3, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them > to document this new failure mode, which will reduce false positives in CI. > > External URL: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/index.html > > Participating hosts (42 -> 39) > ------------------------------ > > Additional (1): bat-twl-2 > Missing (4): bat-adln-1 bat-jsl-3 fi-snb-2520m fi-elk-e7500 > > Possible new issues > ------------------- > > Here are the unknown changes that may have been introduced in Patchwork_134906v3: > > ### IGT changes ### > > #### Possible regressions #### > > * igt@i915_selftest@live@execlists: > - fi-bsw-n3050: [PASS][1] -> [ABORT][2] > [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-bsw-n3050/igt@i915_selftest@live@execlists.html > [2]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/fi-bsw-n30 > 50/igt@i915_selftest@live@execlists.html No display output is enabled/gets enabled until the above test, so the changes in this patch are unrelated to the failure. The test gets stuck in the middle of the above test: <6>[ 489.209589] i915: Running execlists ... <6>[ 491.829046] i915: Running intel_execlists_live_selftests/live_preempt_cancel <3>[ 554.835785] INFO: task systemd-udevd:5552 blocked for more than 61 seconds I found the following similar issues that happened on the same machine and test, though they happen a bit earlier in the subtest, so not sure if the root cause is the same: Trybot_135050v5/fi-bsw-n3050/0/dmesg.log: <6>[ 483.853300] i915: Running execlists <6>[ 483.853367] i915: Running intel_execlists_live_selftests/live_sanitycheck ... <6>[ 485.054414] i915: Running intel_execlists_live_selftests/live_timeslice_preempt <0>[ 521.003803] watchdog: BUG: soft lockup - CPU#0 stuck for 26s! [migration/0:18] Patchwork_135436v1/fi-bsw-n3050/0/dmesg.log <6>[ 486.659257] i915: Running execlists <6>[ 486.659355] i915: Running intel_execlists_live_selftests/live_sanitycheck ... <6>[ 487.845981] i915: Running intel_execlists_live_selftests/live_timeslice_preempt <0>[ 517.007302] watchdog: BUG: soft lockup - CPU#0 stuck for 26s! [migration/0:18] > * igt@i915_selftest@live@gem_migrate: > - bat-arlh-2: [PASS][3] -> [INCOMPLETE][4] > [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-arlh-2/igt@i915_selftest@live@gem_migrate.html > [4]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-arlh-2 > /igt@i915_selftest@live@gem_migrate.html As above display outputs don't get enabled until the above happens (I assume no display is actually connected to it), so the changes in the patch are unrelated to the failure. The machine hang similarly earlier in the same test, though a different subtest, so the root cause could be something else: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_14993/bat-arlh-2/igt@i915_selftest@live@evict.html > Known issues > ------------ > > Here are the changes found in Patchwork_134906v3 that come from known issues: > > ### IGT changes ### > > #### Issues hit #### > > * igt@kms_chamelium_edid@dp-edid-read: > - bat-dg2-13: [PASS][5] -> [ABORT][6] ([i915#11552]) > [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-dg2-13/igt@kms_chamelium_edid@dp-edid-read.html > [6]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-dg2-13 > /igt@kms_chamelium_edid@dp-edid-read.html > > * igt@kms_frontbuffer_tracking@basic: > - bat-arls-2: [PASS][7] -> [DMESG-WARN][8] ([i915#7507]) > [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-arls-2/igt@kms_frontbuffer_tracking@basic.html > [8]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-arls-2 > /igt@kms_frontbuffer_tracking@basic.html > > > #### Possible fixes #### > > * igt@i915_selftest@live@gt_heartbeat: > - fi-kbl-7567u: [DMESG-WARN][9] ([i915#11328]) -> [PASS][10] +33 other tests pass > [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/fi-kbl-7567u/igt@i915_selftest@live@gt_heartbeat.html > [10]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/fi-kbl-756 > 7u/igt@i915_selftest@live@gt_heartbeat.html > > * igt@i915_selftest@live@workarounds: > - bat-dg2-11: [DMESG-FAIL][11] ([i915#9500]) -> [PASS][12] > [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15013/bat-dg2-11/igt@i915_selftest@live@workarounds.html > [12]: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/bat-dg2-11 > /igt@i915_selftest@live@workarounds.html > > > {name}: This element is suppressed. This means it is ignored when computing > the status of the difference (SUCCESS, WARNING, or FAILURE). > > [i915#10209]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10209 > [i915#10212]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10212 > [i915#10213]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10213 > [i915#10214]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10214 > [i915#10216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/10216 > [i915#11030]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11030 > [i915#11031]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11031 > [i915#11032]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11032 > [i915#11328]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11328 > [i915#11552]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/11552 > [i915#3708]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/3708 > [i915#7507]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/7507 > [i915#8809]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/8809 > [i915#9318]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9318 > [i915#9500]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9500 > [i915#9886]: > https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9886 > > > Build changes > ------------- > > * Linux: CI_DRM_15013 -> Patchwork_134906v3 > > CI-20190529: 20190529 > CI_DRM_15013: 0318a12ff6fb8c321458aa2b373e9322896ee951 @ git://anongit.freedesktop.org/gfx-ci/linux > IGT_7906: ae91ba26f657bf11264f64bd2dc21f471a5d18f5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git > Patchwork_134906v3: 0318a12ff6fb8c321458aa2b373e9322896ee951 @ > git://anongit.freedesktop.org/gfx-ci/linux > > == Logs == > > For more details see: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_134906v3/index.html