mbox series

[v3,0/8] drm/i915: Write source OUI for non-eDP sinks

Message ID 20241016132405.2231744-1-imre.deak@intel.com (mailing list archive)
Headers show
Series drm/i915: Write source OUI for non-eDP sinks | expand

Message

Imre Deak Oct. 16, 2024, 1:23 p.m. UTC
This is v3 of [1] handling a few cases where the source OUI value
written to an eDP sink could be not yet valid or could have gotten
reset after the panel power was disabled (in patches 1, 2, 4, 6, 7).

[1] https://lore.kernel.org/all/20241001123259.616486-1-imre.deak@intel.com

Imre Deak (8):
  drm/i915/dp: Flush modeset commits during connector detection
  drm/i915/dp: Ensure panel power remains enabled during connector
    detection
  drm/i915/dp: Initialize the source OUI write timestamp always
  drm/i915/dp: Track source OUI validity explicitly
  drm/i915/dp: Reuse intel_dp_detect_dsc_caps() for eDP
  drm/i915/dp: Write the source OUI for eDP before detecting sink
    capabilities
  drm/i915/dp: Write the source OUI during connector detection
  drm/i915/dp: Write the source OUI for non-eDP sinks as well

 drivers/gpu/drm/i915/display/g4x_dp.c         |   1 +
 drivers/gpu/drm/i915/display/intel_ddi.c      |   1 +
 .../drm/i915/display/intel_display_types.h    |   1 +
 drivers/gpu/drm/i915/display/intel_dp.c       | 131 ++++++++++++------
 drivers/gpu/drm/i915/display/intel_dp.h       |   2 +
 drivers/gpu/drm/i915/display/intel_dp_mst.c   |   2 +
 drivers/gpu/drm/i915/display/intel_pps.c      |  17 ++-
 drivers/gpu/drm/i915/display/intel_pps.h      |   1 +
 8 files changed, 113 insertions(+), 43 deletions(-)

Comments

Imre Deak Oct. 22, 2024, 1:04 p.m. UTC | #1
Hi CI team,

On Tue, Oct 22, 2024 at 12:27:08PM +0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915: Write source OUI for non-eDP sinks (rev3)
> URL   : https://patchwork.freedesktop.org/series/140061/
> State : failure

the failure is unrelated, see below.

> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_15576 -> Patchwork_140061v3
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_140061v3 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_140061v3, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/index.html
> 
> Participating hosts (45 -> 44)
> ------------------------------
> 
>   Missing    (1): fi-snb-2520m 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_140061v3:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_selftest@live@hangcheck:
>     - bat-jsl-3:          [PASS][1] -> [DMESG-WARN][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-jsl-3/igt@i915_selftest@live@hangcheck.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-jsl-3/igt@i915_selftest@live@hangcheck.html

There is only an eDP panel connected here, but there is no connector
registered for it due to some unrelated and pre-existing PSR issue:
<7> [457.019660] i915 0000:00:02.0: [drm:intel_dp_init_connector [i915]] PSR condition failed: Port not supported

So the changes in the patchset won't have an effect on this machine and
the failure is unrelated:

<3> [456.963285] i915 0000:00:02.0: [drm] *ERROR* GT0: engine workaround lost on application! (reg[7000]=0x0, relevant bits were 0x0 vs expected 0x8000)

and happened on the same platform test before in:
CI_DIN_1561/bat-jsl-1/0/dmesg.log

> Known issues
> ------------
> 
>   Here are the changes found in Patchwork_140061v3 that come from known issues:
> 
> ### IGT changes ###
> 
> #### Issues hit ####
> 
>   * igt@i915_selftest@live:
>     - bat-mtlp-8:         [PASS][3] -> [ABORT][4] ([i915#12216]) +1 other test abort
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-mtlp-8/igt@i915_selftest@live.html
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-mtlp-8/igt@i915_selftest@live.html
>     - bat-jsl-3:          [PASS][5] -> [DMESG-WARN][6] ([i915#12434])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-jsl-3/igt@i915_selftest@live.html
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-jsl-3/igt@i915_selftest@live.html
> 
>   
> #### Possible fixes ####
> 
>   * igt@i915_selftest@live:
>     - bat-arlh-3:         [ABORT][7] ([i915#12133]) -> [PASS][8]
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-arlh-3/igt@i915_selftest@live.html
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-arlh-3/igt@i915_selftest@live.html
> 
>   * igt@i915_selftest@live@workarounds:
>     - bat-arlh-3:         [ABORT][9] ([i915#12061]) -> [PASS][10]
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-arlh-3/igt@i915_selftest@live@workarounds.html
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-arlh-3/igt@i915_selftest@live@workarounds.html
> 
>   
>   [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
>   [i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
>   [i915#12216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12216
>   [i915#12434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12434
> 
> 
> Build changes
> -------------
> 
>   * Linux: CI_DRM_15576 -> Patchwork_140061v3
> 
>   CI-20190529: 20190529
>   CI_DRM_15576: d5bac12430b0d4a980c0498b3c946772950e70ee @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_8081: 9b8c0f6da8898f760bfaa2113455eb84b68a69f4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_140061v3: d5bac12430b0d4a980c0498b3c946772950e70ee @ git://anongit.freedesktop.org/gfx-ci/linux
> 
> == Logs ==
> 
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/index.html
Imre Deak Oct. 22, 2024, 1:25 p.m. UTC | #2
On Tue, Oct 22, 2024 at 04:04:11PM +0300, Imre Deak wrote:
> Hi CI team,
> 
> On Tue, Oct 22, 2024 at 12:27:08PM +0000, Patchwork wrote:
> > == Series Details ==
> > 
> > Series: drm/i915: Write source OUI for non-eDP sinks (rev3)
> > URL   : https://patchwork.freedesktop.org/series/140061/
> > State : failure
> 
> the failure is unrelated, see below.
> 
> > == Summary ==
> > 
> > CI Bug Log - changes from CI_DRM_15576 -> Patchwork_140061v3
> > ====================================================
> > 
> > Summary
> > -------
> > 
> >   **FAILURE**
> > 
> >   Serious unknown changes coming with Patchwork_140061v3 absolutely need to be
> >   verified manually.
> >   
> >   If you think the reported changes have nothing to do with the changes
> >   introduced in Patchwork_140061v3, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
> >   to document this new failure mode, which will reduce false positives in CI.
> > 
> >   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/index.html
> > 
> > Participating hosts (45 -> 44)
> > ------------------------------
> > 
> >   Missing    (1): fi-snb-2520m 
> > 
> > Possible new issues
> > -------------------
> > 
> >   Here are the unknown changes that may have been introduced in Patchwork_140061v3:
> > 
> > ### IGT changes ###
> > 
> > #### Possible regressions ####
> > 
> >   * igt@i915_selftest@live@hangcheck:
> >     - bat-jsl-3:          [PASS][1] -> [DMESG-WARN][2]
> >    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-jsl-3/igt@i915_selftest@live@hangcheck.html
> >    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-jsl-3/igt@i915_selftest@live@hangcheck.html
> 
> There is only an eDP panel connected here, but there is no connector
> registered for it due to some unrelated and pre-existing PSR issue:
> <7> [457.019660] i915 0000:00:02.0: [drm:intel_dp_init_connector [i915]] PSR condition failed: Port not supported
>
> So the changes in the patchset won't have an effect on this machine and
> the failure is unrelated:

Actually the above PSR error doesn't prevent registering the connector,
however for selftests the driver is loaded with disable_display=1, so
all connectors will be reported as disconnected and the result is the
same.

> <3> [456.963285] i915 0000:00:02.0: [drm] *ERROR* GT0: engine workaround lost on application! (reg[7000]=0x0, relevant bits were 0x0 vs expected 0x8000)
> 
> and happened on the same platform test before in:
> CI_DIN_1561/bat-jsl-1/0/dmesg.log
> 
> > Known issues
> > ------------
> > 
> >   Here are the changes found in Patchwork_140061v3 that come from known issues:
> > 
> > ### IGT changes ###
> > 
> > #### Issues hit ####
> > 
> >   * igt@i915_selftest@live:
> >     - bat-mtlp-8:         [PASS][3] -> [ABORT][4] ([i915#12216]) +1 other test abort
> >    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-mtlp-8/igt@i915_selftest@live.html
> >    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-mtlp-8/igt@i915_selftest@live.html
> >     - bat-jsl-3:          [PASS][5] -> [DMESG-WARN][6] ([i915#12434])
> >    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-jsl-3/igt@i915_selftest@live.html
> >    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-jsl-3/igt@i915_selftest@live.html
> > 
> >   
> > #### Possible fixes ####
> > 
> >   * igt@i915_selftest@live:
> >     - bat-arlh-3:         [ABORT][7] ([i915#12133]) -> [PASS][8]
> >    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-arlh-3/igt@i915_selftest@live.html
> >    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-arlh-3/igt@i915_selftest@live.html
> > 
> >   * igt@i915_selftest@live@workarounds:
> >     - bat-arlh-3:         [ABORT][9] ([i915#12061]) -> [PASS][10]
> >    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15576/bat-arlh-3/igt@i915_selftest@live@workarounds.html
> >    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/bat-arlh-3/igt@i915_selftest@live@workarounds.html
> > 
> >   
> >   [i915#12061]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061
> >   [i915#12133]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12133
> >   [i915#12216]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12216
> >   [i915#12434]: https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12434
> > 
> > 
> > Build changes
> > -------------
> > 
> >   * Linux: CI_DRM_15576 -> Patchwork_140061v3
> > 
> >   CI-20190529: 20190529
> >   CI_DRM_15576: d5bac12430b0d4a980c0498b3c946772950e70ee @ git://anongit.freedesktop.org/gfx-ci/linux
> >   IGT_8081: 9b8c0f6da8898f760bfaa2113455eb84b68a69f4 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
> >   Patchwork_140061v3: d5bac12430b0d4a980c0498b3c946772950e70ee @ git://anongit.freedesktop.org/gfx-ci/linux
> > 
> > == Logs ==
> > 
> > For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140061v3/index.html