mbox series

[0/9] drm/i915/scaler: Scaler code cleanups

Message ID 20241029211030.13255-1-ville.syrjala@linux.intel.com (mailing list archive)
Headers show
Series drm/i915/scaler: Scaler code cleanups | expand

Message

Ville Syrjälä Oct. 29, 2024, 9:10 p.m. UTC
From: Ville Syrjälä <ville.syrjala@linux.intel.com>

Bunch of cleanups/refactoring in the scaler code.

Ville Syrjälä (9):
  drm/i915/scaler: s/intel_crtc/crtc/ etc.
  drm/i915/scaler: Remove redudant junk from skl_scaler.h
  drm/i915/scaler: Pass the whole atomic state into
    intel_atomic_setup_scalers()
  drm/i915/scaler: Clean up intel_atomic_setup_scalers() a bit
  drm/i915/scaler: Convert the scaler code to intel_display
  drm/i915/scaler: Carve up intel_atomic_setup_scalers()
  drm/i915/scaler: Move pfit scaler into pfit state
  drm/i915/scaler: Make scaler in_use a bool
  drm/i915/scaler: Extract intel_allocate_scaler()

 drivers/gpu/drm/i915/display/intel_crtc.c     |   2 +-
 .../drm/i915/display/intel_crtc_state_dump.c  |   4 +-
 drivers/gpu/drm/i915/display/intel_display.c  |   4 +-
 .../drm/i915/display/intel_display_debugfs.c  |   2 +-
 .../drm/i915/display/intel_display_types.h    |   9 +-
 drivers/gpu/drm/i915/display/intel_psr.c      |   2 +-
 drivers/gpu/drm/i915/display/skl_scaler.c     | 294 +++++++++---------
 drivers/gpu/drm/i915/display/skl_scaler.h     |  11 +-
 8 files changed, 165 insertions(+), 163 deletions(-)

Comments

Ville Syrjälä Oct. 31, 2024, 4:03 p.m. UTC | #1
On Wed, Oct 30, 2024 at 01:05:25AM -0000, Patchwork wrote:
> == Series Details ==
> 
> Series: drm/i915/scaler: Scaler code cleanups
> URL   : https://patchwork.freedesktop.org/series/140694/
> State : failure
> 
> == Summary ==
> 
> CI Bug Log - changes from CI_DRM_15607 -> Patchwork_140694v1
> ====================================================
> 
> Summary
> -------
> 
>   **FAILURE**
> 
>   Serious unknown changes coming with Patchwork_140694v1 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_140694v1, please notify your bug team (I915-ci-infra@lists.freedesktop.org) to allow them
>   to document this new failure mode, which will reduce false positives in CI.
> 
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140694v1/index.html
> 
> Participating hosts (47 -> 46)
> ------------------------------
> 
>   Missing    (1): fi-snb-2520m 
> 
> Possible new issues
> -------------------
> 
>   Here are the unknown changes that may have been introduced in Patchwork_140694v1:
> 
> ### IGT changes ###
> 
> #### Possible regressions ####
> 
>   * igt@i915_module_load@load:
>     - bat-arls-1:         [PASS][1] -> [ABORT][2]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_15607/bat-arls-1/igt@i915_module_load@load.html
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_140694v1/bat-arls-1/igt@i915_module_load@load.html

Looks like this failed because we apparently depend on some extra
scaler state copying being done in intel_crtc_prepare_cleared_state().
I'll need to figure out what to do about that eventually, but for now
I'll probably just drop '[PATCH 7/9] drm/i915/scaler: Move pfit
scaler into pfit state' which should avoid this problem.