| Message ID | 20250207223159.14132-1-ville.syrjala@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | drm/i915/vrr: Fix DSB+VRR usage for PTL+ | expand |
Hi, See comment below and re-report. > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > Patchwork > Sent: Wednesday, 12 February 2025 4.08 > To: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ i915.CI.BAT: failure for drm/i915/vrr: Fix DSB+VRR usage for PTL+ > (rev5) > > Patch Details > Series: drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev5) > URL: https://patchwork.freedesktop.org/series/144153/ > State: failure > Details: https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/index.html > > CI Bug Log - changes from CI_DRM_16111 -> Patchwork_144153v5 > > > Summary > > > FAILURE > > Serious unknown changes coming with Patchwork_144153v5 absolutely need > to be verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_144153v5, please notify your bug team (I915-ci- > infra@lists.freedesktop.org) to allow them to document this new failure > mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/index.html > > > Participating hosts (44 -> 43) > > > Missing (1): fi-snb-2520m > > > Possible new issues > > > Here are the unknown changes that may have been introduced in > Patchwork_144153v5: > > > IGT changes > > > Possible regressions > > > * igt@i915_selftest@live@guc_multi_lrc: > > * fi-bsw-n3050: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/fi-bsw- > n3050/igt@i915_selftest@live@guc_multi_lrc.html> -> ABORT <https://intel- > gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/fi-bsw- > n3050/igt@i915_selftest@live@guc_multi_lrc.html> > Seems to be known issue https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13656 I wonder why not part of filters ? > Known issues > > > Here are the changes found in Patchwork_144153v5 that come from known > issues: > > > IGT changes > > > Issues hit > > > * igt@i915_pm_rpm@module-reload: > > * bat-adls-6: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-adls-6/igt@i915_pm_rpm@module-reload.html> -> > FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/bat- > adls-6/igt@i915_pm_rpm@module-reload.html> (i915#13633 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633> ) > * bat-dg1-7: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-dg1-7/igt@i915_pm_rpm@module-reload.html> -> > FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/bat- > dg1-7/igt@i915_pm_rpm@module-reload.html> (i915#13633 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633> ) > > * igt@i915_selftest@live: > > * bat-twl-1: NOTRUN -> ABORT <https://intel-gfx- > ci.01.org/tree/drm-tip/Patchwork_144153v5/bat-twl- > 1/igt@i915_selftest@live.html> (i915#12919 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919> / > i915#13503 <https://gitlab.freedesktop.org/drm/i915/kernel/- > /issues/13503> ) > > * igt@i915_selftest@live@gt_contexts: > > * bat-twl-1: NOTRUN -> ABORT <https://intel-gfx- > ci.01.org/tree/drm-tip/Patchwork_144153v5/bat-twl- > 1/igt@i915_selftest@live@gt_contexts.html> (i915#12919 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919> ) > > * igt@i915_selftest@live@workarounds: > > * bat-arls-6: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-arls-6/igt@i915_selftest@live@workarounds.html> > -> DMESG-FAIL <https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/bat-arls- > 6/igt@i915_selftest@live@workarounds.html> (i915#12061 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) +1 other > test dmesg-fail > > * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence: > > * bat-dg2-11: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc- > frame-sequence.html> -> SKIP <https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/bat-dg2- > 11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html> > (i915#9197 <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197> > ) +3 other tests skip > > > Possible fixes > > > * igt@dmabuf@all-tests: > > * bat-apl-1: INCOMPLETE <https://intel-gfx- > ci.01.org/tree/drm-tip/CI_DRM_16111/bat-apl-1/igt@dmabuf@all- > tests.html> (i915#12904 <https://gitlab.freedesktop.org/drm/i915/kernel/- > /issues/12904> ) -> PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/bat-apl-1/igt@dmabuf@all-tests.html> +1 other > test pass > > * igt@i915_selftest@live@workarounds: > > * bat-adlp-6: INCOMPLETE <https://intel-gfx- > ci.01.org/tree/drm-tip/CI_DRM_16111/bat-adlp- > 6/igt@i915_selftest@live@workarounds.html> (i915#9413 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9413> ) -> PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/bat-adlp- > 6/igt@i915_selftest@live@workarounds.html> +1 other test pass > > > Build changes > > > * Linux: CI_DRM_16111 -> Patchwork_144153v5 > > CI-20190529: 20190529 > CI_DRM_16111: 76120b67a3d5e7a38cbc92fc39846297130fc6d0 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_8228: 8228 > Patchwork_144153v5: 76120b67a3d5e7a38cbc92fc39846297130fc6d0 @ > git://anongit.freedesktop.org/gfx-ci/linux
Hi, https://patchwork.freedesktop.org/series/144153/ - Re-reported. i915.CI.BAT - Re-reported. Thanks, Ravali. -----Original Message----- From: I915-ci-infra <i915-ci-infra-bounces@lists.freedesktop.org> On Behalf Of Saarinen, Jani Sent: 12 February 2025 13:50 To: intel-gfx@lists.freedesktop.org; Ville Syrjala <ville.syrjala@linux.intel.com>; I915-ci-infra@lists.freedesktop.org Subject: RE: ✗ i915.CI.BAT: failure for drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev5) Hi, See comment below and re-report. > -----Original Message----- > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of > Patchwork > Sent: Wednesday, 12 February 2025 4.08 > To: Ville Syrjala <ville.syrjala@linux.intel.com> > Cc: intel-gfx@lists.freedesktop.org > Subject: ✗ i915.CI.BAT: failure for drm/i915/vrr: Fix DSB+VRR usage > for PTL+ > (rev5) > > Patch Details > Series: drm/i915/vrr: Fix DSB+VRR usage for PTL+ (rev5) > URL: https://patchwork.freedesktop.org/series/144153/ > State: failure > Details: https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/index.html > > CI Bug Log - changes from CI_DRM_16111 -> Patchwork_144153v5 > > > Summary > > > FAILURE > > Serious unknown changes coming with Patchwork_144153v5 absolutely need > to be verified manually. > > If you think the reported changes have nothing to do with the changes > introduced in Patchwork_144153v5, please notify your bug team > (I915-ci- > infra@lists.freedesktop.org) to allow them to document this new > failure mode, which will reduce false positives in CI. > > External URL: https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/index.html > > > Participating hosts (44 -> 43) > > > Missing (1): fi-snb-2520m > > > Possible new issues > > > Here are the unknown changes that may have been introduced in > Patchwork_144153v5: > > > IGT changes > > > Possible regressions > > > * igt@i915_selftest@live@guc_multi_lrc: > > * fi-bsw-n3050: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/fi-bsw- > n3050/igt@i915_selftest@live@guc_multi_lrc.html> -> ABORT > <https://intel- > gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/fi-bsw- > n3050/igt@i915_selftest@live@guc_multi_lrc.html> > Seems to be known issue https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13656 I wonder why not part of filters ? > Known issues > > > Here are the changes found in Patchwork_144153v5 that come from known > issues: > > > IGT changes > > > Issues hit > > > * igt@i915_pm_rpm@module-reload: > > * bat-adls-6: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-adls-6/igt@i915_pm_rpm@module-reload.html> -> > FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/bat- > adls-6/igt@i915_pm_rpm@module-reload.html> (i915#13633 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633> ) > * bat-dg1-7: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-dg1-7/igt@i915_pm_rpm@module-reload.html> -> > FAIL <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/bat- > dg1-7/igt@i915_pm_rpm@module-reload.html> (i915#13633 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/13633> ) > > * igt@i915_selftest@live: > > * bat-twl-1: NOTRUN -> ABORT <https://intel-gfx- > ci.01.org/tree/drm-tip/Patchwork_144153v5/bat-twl- > 1/igt@i915_selftest@live.html> (i915#12919 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919> / > i915#13503 <https://gitlab.freedesktop.org/drm/i915/kernel/- > /issues/13503> ) > > * igt@i915_selftest@live@gt_contexts: > > * bat-twl-1: NOTRUN -> ABORT <https://intel-gfx- > ci.01.org/tree/drm-tip/Patchwork_144153v5/bat-twl- > 1/igt@i915_selftest@live@gt_contexts.html> (i915#12919 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12919> ) > > * igt@i915_selftest@live@workarounds: > > * bat-arls-6: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-arls-6/igt@i915_selftest@live@workarounds.html> > -> DMESG-FAIL <https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/bat-arls- > 6/igt@i915_selftest@live@workarounds.html> (i915#12061 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/12061> ) +1 > other test dmesg-fail > > * igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence: > > * bat-dg2-11: PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/CI_DRM_16111/bat-dg2-11/igt@kms_pipe_crc_basic@nonblocking-crc- > frame-sequence.html> -> SKIP <https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/bat-dg2- > 11/igt@kms_pipe_crc_basic@nonblocking-crc-frame-sequence.html> > (i915#9197 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9197> > ) +3 other tests skip > > > Possible fixes > > > * igt@dmabuf@all-tests: > > * bat-apl-1: INCOMPLETE <https://intel-gfx- > ci.01.org/tree/drm-tip/CI_DRM_16111/bat-apl-1/igt@dmabuf@all- > tests.html> (i915#12904 > <https://gitlab.freedesktop.org/drm/i915/kernel/- > /issues/12904> ) -> PASS <https://intel-gfx-ci.01.org/tree/drm- > tip/Patchwork_144153v5/bat-apl-1/igt@dmabuf@all-tests.html> +1 other > test pass > > * igt@i915_selftest@live@workarounds: > > * bat-adlp-6: INCOMPLETE <https://intel-gfx- > ci.01.org/tree/drm-tip/CI_DRM_16111/bat-adlp- > 6/igt@i915_selftest@live@workarounds.html> (i915#9413 > <https://gitlab.freedesktop.org/drm/i915/kernel/-/issues/9413> ) -> > PASS > <https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_144153v5/bat-adlp- > 6/igt@i915_selftest@live@workarounds.html> +1 other test pass > > > Build changes > > > * Linux: CI_DRM_16111 -> Patchwork_144153v5 > > CI-20190529: 20190529 > CI_DRM_16111: 76120b67a3d5e7a38cbc92fc39846297130fc6d0 @ > git://anongit.freedesktop.org/gfx-ci/linux > IGT_8228: 8228 > Patchwork_144153v5: 76120b67a3d5e7a38cbc92fc39846297130fc6d0 @ > git://anongit.freedesktop.org/gfx-ci/linux
From: Ville Syrjälä <ville.syrjala@linux.intel.com> Apparently PTL (or I suppose it could have already happened in either MTL or LNL, didn't have either one to check) changes the way the VRR hardwre works by ending the safe window as soon as the push send is triggered. Reorder our DSB programming sequence to account for that, and try to make sure we catch any vblank evasion fails that could cause problems with the new order. v2: Fix up the issues with wiating for the vblank delay so we can make do with a single check of the push bit. Also do the check for the mmio path. Avoid legacy cursor updates making a mess of things. Decode the DSB errors. Ville Syrjälä (8): drm/i915/dsb: Move the +1 usec adjustment into dsb_wait_usec() drm/i915/vrr: Don't send push for legacy cursor updates drm/i915/vrr: Account for TRANS_PUSH delay drm/i915/dsb: Compute use_dsb earlier drm/i915/dsb: Introduce intel_dsb_poll() drm/i915/vrr: Reorder the DSB "wait for safe window" vs. TRANS_PUSH drm/i915/vrr: Check that the push send bit is clear after delayed vblank drm/i915/dsb: Decode DSB error interrupts drivers/gpu/drm/i915/display/intel_color.c | 9 +++- drivers/gpu/drm/i915/display/intel_crtc.c | 3 +- drivers/gpu/drm/i915/display/intel_display.c | 31 +++++++------ drivers/gpu/drm/i915/display/intel_dsb.c | 47 +++++++++++++++++--- drivers/gpu/drm/i915/display/intel_dsb.h | 3 ++ drivers/gpu/drm/i915/display/intel_vrr.c | 31 +++++++++++++ drivers/gpu/drm/i915/display/intel_vrr.h | 2 + 7 files changed, 101 insertions(+), 25 deletions(-)